mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Matthew Schwartz <mattschwartz@gwmail.gwu.edu>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: John Schoenick <johns@valvesoftware.com>,
	Kyle Gospodnetich <me@kylegospodneti.ch>,
	Hans de Goede <hdegoede@redhat.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Matthew Schwartz <mattschwartz@gwu.edu>
Subject: Re: [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo
Date: Thu, 27 Jun 2024 13:11:13 -0500	[thread overview]
Message-ID: <a160a3b4-1193-490c-aa25-8761142f4e08@amd.com> (raw)
In-Reply-To: <20240627175947.65513-2-mattschwartz@gwu.edu>

On 6/27/2024 12:59, Matthew Schwartz wrote:
> From: John Schoenick <johns@valvesoftware.com>
> 
> Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
> 
> Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>

Your S-o-b should be the last thing in the patch commit log.

> Suggested-by: Matthew Schwartz <mattschwartz@gwu.edu>

I think in this case the specific Suggested-by should be for:

Suggested-by: John Schoenick <johns@valvesoftware.com>

> Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f > ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3d127127e7cb..ac8319d38e37 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
>   		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>   		},
>   		.driver_data = (void *)&lcd800x1280_rightside_up,
> +	}, {	/* Valve Steam Deck */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> +		},
> +		.driver_data = (void *)&lcd800x1280_rightside_up,
>   	}, {	/* VIOS LTH17 */
>   		.matches = {
>   		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),


  reply	other threads:[~2024-06-27 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 17:59 [PATCH 0/2] drm: panel-orientation-quirks: Add quirk for Steam Deck Galileo revision and re-label the Deck panel quirks to specify hardware revision Matthew Schwartz
2024-06-27 17:59 ` [PATCH 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo Matthew Schwartz
2024-06-27 18:11   ` Mario Limonciello [this message]
2024-06-27 18:27     ` [PATCH V2 " Matthew Schwartz
2024-06-27 17:59 ` [PATCH 2/2] drm: panel-orientation-quirks: Add labels for both Valve Steam Deck revisions Matthew Schwartz
2024-06-27 18:12   ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a160a3b4-1193-490c-aa25-8761142f4e08@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=johns@valvesoftware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mattschwartz@gwmail.gwu.edu \
    --cc=mattschwartz@gwu.edu \
    --cc=me@kylegospodneti.ch \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®