From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3543DC4167D for ; Fri, 25 Nov 2022 10:02:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229568AbiKYKCu (ORCPT ); Fri, 25 Nov 2022 05:02:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiKYKCr (ORCPT ); Fri, 25 Nov 2022 05:02:47 -0500 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D20FB4B4; Fri, 25 Nov 2022 02:02:45 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 709865C009B; Fri, 25 Nov 2022 05:02:42 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Fri, 25 Nov 2022 05:02:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1669370562; x=1669456962; bh=sWYE/iIwCB vIU0xfDNveElelu0+FYSafuJcobyMBNYw=; b=C+oiFxD0ZqCbkXOpvygFUOnO7O bSJ+1QmD2EvTApYfH8/4uFWWcAKR5NhzDD92jb1q/mfnXbgXVecsdwHhfmwMxrq4 ck/yh1BktL/NvzprB0boZ7L+MdUJ4lHwQdbplWZch5+fj55xPnMEiTaLe1yLtWDd YI57gzoGLDpg0LxV8i1Uk7zOb7R4qBB+3lVxSDbHOEm8Ueo+M/n/NLI38aE097d0 aVmQc0WvWNQd7NE+t682JUReleLk9AYeaiF+Hi1AkbVkQavZH0jAI2eu7P1Wnx6g OX/qm8v75+kYVyEsTtt8aTuNdVGyimhauGE3F+BQrnOjsd7oKwSfsSPL2+Fg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669370562; x=1669456962; bh=sWYE/iIwCBvIU0xfDNveElelu0+F YSafuJcobyMBNYw=; b=wiDYy/YysHRfab9xMajQeRyxikkuhZyszOQkwwJdYfdU UgwqobLJ5xNIugL3Mbwmk5C2VK49S5hkADKoWu3uq6Yv8W276VzDWGFE18wgZeRJ x5tL2bQu+F5RlDKCvmboVcFt6Eebbtkc74+Ehidm5Qx9o0SYG+cxg3tkZvxhFVnj YgzE4fatoIir0zPxEaisi1/Y8gUnLfzTVuzXJfp16fsnyfEAzKo6yYMORCrM1+Lg AoE0SjAN4nrLfODbVq82Ew+3GxBkCLVZ/xBWeKa1jJSmScYNJTf9gEwQFP627cJ5 LswIJqcVvssBJA+bbohMghGyfwsgLgrftdwp7PRMAg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieehgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5993FB60086; Fri, 25 Nov 2022 05:02:40 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20221123084557.945845710@linuxfoundation.org> Date: Fri, 25 Nov 2022 11:02:19 +0100 From: "Arnd Bergmann" To: "Naresh Kamboju" , "Greg Kroah-Hartman" , YueHaibing Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, "Linus Torvalds" , "Andrew Morton" , "Guenter Roeck" , shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, "Pavel Machek" , "Jon Hunter" , "Florian Fainelli" , "Sudip Mukherjee" , srw@sladewatkins.net, rwarsow@gmx.de, Netdev , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , =?UTF-8?Q?Daniel_D=C3=ADaz?= Subject: Re: [PATCH 5.10 000/149] 5.10.156-rc1 review Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022, at 09:05, Naresh Kamboju wrote: > On Fri, 25 Nov 2022 at 12:57, Greg Kroah-Hartman wrote: >> On Thu, Nov 24, 2022 at 09:17:36PM +0530, Naresh Kamboju wrote: >> > >> > Daniel bisected this reported problem and found the first bad commit, >> > >> > YueHaibing >> > net: broadcom: Fix BCMGENET Kconfig >> >> But that is in 5.10.155, 5.15.79, 6.0.9, and 6.1-rc5. It is not new to >> this -rc release. > > It started from 5.10.155 and this is only seen on 5.10 and other > branches 5.15, 6.0 and mainline are looking good. I think the original patch is wrong and should be fixed upstream. The backported patch in question is a one-line Kconfig change doing diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index f4e1ca68d831..55dfdb34e37b 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -77,7 +77,7 @@ config BCMGENET select BCM7XXX_PHY select MDIO_BCM_UNIMAC select DIMLIB - select BROADCOM_PHY if ARCH_BCM2835 + select BROADCOM_PHY if (ARCH_BCM2835 && PTP_1588_CLOCK_OPTIONAL) help This driver supports the built-in Ethernet MACs found in the Broadcom BCM7xxx Set Top Box family chipset. which fixes the build on kernels that contain 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET") and enable BCMGENET=y but PTP_1588_CLOCK_OPTIONAL=m, which otherwise leads to a link failure. The patch unfortunately solves it by replacing it with a runtime failure by no longer linking in the PHY driver (as found by Naresh). I think the correct fix would be to propagate the dependency down to BCMGENET: diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index f4e1ca68d831..f4ca0c6c0f51 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -71,6 +71,7 @@ config BCM63XX_ENET config BCMGENET tristate "Broadcom GENET internal MAC support" depends on HAS_IOMEM + depends on PTP_1588_CLOCK_OPTIONAL || !ARCH_BCM2835 select MII select PHYLIB select FIXED_PHY With this change, the broken config is no longer possible, instead forcing BCMGENET to be =m when building for ARCH_BCM2835 with PTP_1588_CLOCK=m. Arnd