From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Joey Gouly <joey.gouly@arm.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bill Wendling <morbo@google.com>,
Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] neighbour: Fix __randomize_layout crash in struct neighbour
Date: Tue, 28 Nov 2023 14:12:08 -0600 [thread overview]
Message-ID: <a1656a7c-7eb0-4a21-8c49-89014beeb7ed@embeddedor.com> (raw)
In-Reply-To: <20231128111028.GA2382233@e124191.cambridge.arm.com>
>> diff --git a/include/net/neighbour.h b/include/net/neighbour.h
>> index 07022bb0d44d..0d28172193fa 100644
>> --- a/include/net/neighbour.h
>> +++ b/include/net/neighbour.h
>> @@ -162,7 +162,7 @@ struct neighbour {
>> struct rcu_head rcu;
>> struct net_device *dev;
>> netdevice_tracker dev_tracker;
>> - u8 primary_key[0];
>> + u8 primary_key[];
>> } __randomize_layout;
>>
>> struct neigh_ops {
>
> Fixes the crash for me!
Awesome. :)
--
Gustavo
prev parent reply other threads:[~2023-11-28 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 21:33 Gustavo A. R. Silva
2023-11-28 0:29 ` Kees Cook
2023-11-28 1:33 ` Gustavo A. R. Silva
2023-11-28 11:10 ` Joey Gouly
2023-11-28 20:12 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1656a7c-7eb0-4a21-8c49-89014beeb7ed@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=joey.gouly@arm.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®