From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenjian15@huawei.com,
wangpeiyang1@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, sudongming1@huawei.com,
xujunsheng@huawei.com, shiyongbang@huawei.com,
libaihan@huawei.com, jdamato@fastly.com, horms@kernel.org,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V9 net-next 11/11] net: add ndo_validate_addr check in dev_set_mac_address
Date: Wed, 11 Sep 2024 16:41:03 +0200 [thread overview]
Message-ID: <a167de50-9759-4ba6-97a6-96cd6356fdc3@lunn.ch> (raw)
In-Reply-To: <dbc5f648-4fc0-48f6-be71-cbecd1f54522@huawei.com>
> This patch may not work as expected.
>
> ndo_validate_addr() has only one parameter.
> The sa parameter of the MAC address is not transferred to the function.
> So ndo_validate_addr() checks the old MAC address, not the new MAC address.
Yes, i agree. The current API does not lend itself to validation
before change.
> I haven't found a better way to fix it yet.
Maybe in dev_set_mac_address(), make a copy of dev->dev_addr. Call
ops->ndo_set_mac_address(). If there is no error call
ndo_validate_addr(). If that returns an error, call
ops->ndo_set_mac_address() again with the old MAC address, and then
return the error from ndo_validate_addr().
It is not great, but it is the best i can think of.
Since this is not as simple i was expecting, feel free to drop it from
your patchset, and submit it as a standalone patch.
Andrew
prev parent reply other threads:[~2024-09-11 14:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 7:59 [PATCH V9 net-next 00/11] Add support of HIBMCGE Ethernet Driver Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 01/11] net: hibmcge: Add pci table supported in this module Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 02/11] net: hibmcge: Add read/write registers supported through the bar space Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module Jijie Shao
2024-09-10 12:21 ` Andrew Lunn
2024-09-10 13:54 ` Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 04/11] net: hibmcge: Add interrupt " Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 05/11] net: hibmcge: Implement some .ndo functions Jijie Shao
2024-09-10 8:20 ` Kalesh Anakkur Purayil
2024-09-10 12:14 ` Andrew Lunn
2024-09-10 12:20 ` Kalesh Anakkur Purayil
2024-09-10 12:34 ` Andrew Lunn
2024-09-10 13:58 ` Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 06/11] net: hibmcge: Implement .ndo_start_xmit function Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 07/11] net: hibmcge: Implement rx_poll function to receive packets Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 08/11] net: hibmcge: Implement some ethtool_ops functions Jijie Shao
2024-09-10 8:41 ` Kalesh Anakkur Purayil
2024-09-10 7:59 ` [PATCH V9 net-next 09/11] net: hibmcge: Add a Makefile and update Kconfig for hibmcge Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 10/11] net: hibmcge: Add maintainer " Jijie Shao
2024-09-10 7:59 ` [PATCH V9 net-next 11/11] net: add ndo_validate_addr check in dev_set_mac_address Jijie Shao
2024-09-10 8:39 ` Kalesh Anakkur Purayil
2024-09-10 14:01 ` Jijie Shao
2024-09-11 13:30 ` Jijie Shao
2024-09-11 14:41 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a167de50-9759-4ba6-97a6-96cd6356fdc3@lunn.ch \
--to=andrew@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jonathan.cameron@huawei.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®