From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: Xiubo Li <xiubli@redhat.com>,
"idryomov@gmail.com" <idryomov@gmail.com>,
"cfsworks@gmail.com" <cfsworks@gmail.com>
Cc: Milind Changire <mchangir@redhat.com>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"brauner@kernel.org" <brauner@kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] ceph: Remove error return from ceph_process_folio_batch()
Date: Thu, 8 Jan 2026 20:08:46 +0000 [thread overview]
Message-ID: <a16c48a05998429d26f68887cad4abec045869c7.camel@ibm.com> (raw)
In-Reply-To: <20260107210139.40554-3-CFSworks@gmail.com>
On Wed, 2026-01-07 at 13:01 -0800, Sam Edwards wrote:
> Following the previous patch, ceph_process_folio_batch() no longer
> returns errors because the writeback loop cannot handle them.
>
> Since this function already indicates failure to lock any pages by
> leaving `ceph_wbc.locked_pages == 0`, and the writeback loop has no way
> to handle abandonment of a locked batch, change the return type of
> ceph_process_folio_batch() to `void` and remove the pathological goto in
> the writeback loop. The lack of a return code emphasizes that
> ceph_process_folio_batch() is designed to be abort-free: that is, once
> it commits a folio for writeback, it will not later abandon it or
> propagate an error for that folio.
>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> ---
> fs/ceph/addr.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 3462df35d245..2b722916fb9b 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1283,16 +1283,16 @@ static inline int move_dirty_folio_in_page_array(struct address_space *mapping,
> }
>
> static
> -int ceph_process_folio_batch(struct address_space *mapping,
> - struct writeback_control *wbc,
> - struct ceph_writeback_ctl *ceph_wbc)
> +void ceph_process_folio_batch(struct address_space *mapping,
> + struct writeback_control *wbc,
> + struct ceph_writeback_ctl *ceph_wbc)
> {
> struct inode *inode = mapping->host;
> struct ceph_fs_client *fsc = ceph_inode_to_fs_client(inode);
> struct ceph_client *cl = fsc->client;
> struct folio *folio = NULL;
> unsigned i;
> - int rc = 0;
> + int rc;
>
> for (i = 0; can_next_page_be_processed(ceph_wbc, i); i++) {
> folio = ceph_wbc->fbatch.folios[i];
> @@ -1322,12 +1322,10 @@ int ceph_process_folio_batch(struct address_space *mapping,
> rc = ceph_check_page_before_write(mapping, wbc,
> ceph_wbc, folio);
> if (rc == -ENODATA) {
> - rc = 0;
> folio_unlock(folio);
> ceph_wbc->fbatch.folios[i] = NULL;
> continue;
> } else if (rc == -E2BIG) {
> - rc = 0;
> folio_unlock(folio);
> ceph_wbc->fbatch.folios[i] = NULL;
> break;
> @@ -1369,7 +1367,6 @@ int ceph_process_folio_batch(struct address_space *mapping,
> rc = move_dirty_folio_in_page_array(mapping, wbc, ceph_wbc,
> folio);
> if (rc) {
> - rc = 0;
> folio_redirty_for_writepage(wbc, folio);
> folio_unlock(folio);
> break;
> @@ -1380,8 +1377,6 @@ int ceph_process_folio_batch(struct address_space *mapping,
> }
>
> ceph_wbc->processed_in_fbatch = i;
> -
> - return rc;
> }
>
> static inline
> @@ -1685,10 +1680,8 @@ static int ceph_writepages_start(struct address_space *mapping,
> break;
>
> process_folio_batch:
> - rc = ceph_process_folio_batch(mapping, wbc, &ceph_wbc);
> + ceph_process_folio_batch(mapping, wbc, &ceph_wbc);
> ceph_shift_unused_folios_left(&ceph_wbc.fbatch);
> - if (rc)
> - goto release_folios;
>
> /* did we get anything? */
> if (!ceph_wbc.locked_pages)
I don't see the point of removing the returning error code from the function. I
prefer to have it because this method calls other ones with complex
functionality. And I would like still save the path of returning error code from
the function. So, I don't agree with this patch.
Thanks,
Slava.
next prev parent reply other threads:[~2026-01-08 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 21:01 [PATCH v2 0/6] ceph: CephFS writeback correctness and performance fixes Sam Edwards
2026-01-07 21:01 ` [PATCH v2 1/6] ceph: Do not propagate page array emplacement errors as batch errors Sam Edwards
2026-01-08 20:05 ` Viacheslav Dubeyko
2026-01-07 21:01 ` [PATCH v2 2/6] ceph: Remove error return from ceph_process_folio_batch() Sam Edwards
2026-01-08 20:08 ` Viacheslav Dubeyko [this message]
2026-01-09 0:29 ` Sam Edwards
2026-01-07 21:01 ` [PATCH v2 3/6] ceph: Free page array when ceph_submit_write fails Sam Edwards
2026-01-07 21:01 ` [PATCH v2 4/6] ceph: Split out page-array discarding to a function Sam Edwards
2026-01-08 20:11 ` Viacheslav Dubeyko
2026-01-07 21:01 ` [PATCH v2 5/6] ceph: Assert writeback loop invariants Sam Edwards
2026-01-08 20:12 ` Viacheslav Dubeyko
2026-01-07 21:01 ` [PATCH v2 6/6] ceph: Fix write storm on fscrypted files Sam Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16c48a05998429d26f68887cad4abec045869c7.camel@ibm.com \
--to=slava.dubeyko@ibm.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cfsworks@gmail.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchangir@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®