From: Jing Zhang <renyu.zj@linux.alibaba.com>
To: John Garry <john.g.garry@oracle.com>, Ian Rogers <irogers@google.com>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
Zhuo Song <zhuo.song@linux.alibaba.com>,
Shuai Xue <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v4 1/4] perf metric: Event "Compat" value supports matching multiple identifiers
Date: Wed, 26 Jul 2023 14:15:37 +0800 [thread overview]
Message-ID: <a16f4eb7-24c2-fc42-964d-0b84effae9a5@linux.alibaba.com> (raw)
In-Reply-To: <4c20d8fd-b478-5b0a-0558-3b59dead0751@oracle.com>
在 2023/7/25 下午4:20, John Garry 写道:
> On 23/07/2023 09:21, Jing Zhang wrote:
>> The jevent "Compat" is used for uncore PMU alias or metric definitions.
>>
>> The same PMU driver has different PMU identifiers due to different hardware
>> versions and types, but they may have some common PMU event/metric. Since a
>> Compat value can only match one identifier, when adding the same event
>> alias and metric to PMUs with different identifiers, each identifier needs
>> to be defined once, which is not streamlined enough.
>>
>> So let "Compat" value supports matching multiple identifiers. For example,
>> the Compat value {abcde;123*} can match the PMU identifier "abcde" and the
>> the PMU identifier with the prefix "123", where "*" is a wildcard.
>> Tokens in Unit field are delimited by ';' with no spaces.
>>
>> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
>> ---
>> tools/perf/util/metricgroup.c | 27 ++++++++++++++++++++++++++-
>
> Why only support for metrics? Why not support for regular events aliases? I would have expected pmu_add_sys_aliases_iter_fn() to have been updated for this.
>
Oh, you are right. I forgot to modify pmu_add_sys_aliases_iter_fn().
> On the basis that we will support regular events aliases, we need perf tool self-test cases for this in tools/perf/test/pmu-events.c (I think that pmu-events.c would be the most appropriate file)
>
Ok, I will support it for regular events aliases and add self-test cases in the next version.
Thanks,
Jing
next prev parent reply other threads:[~2023-07-26 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 8:21 [PATCH v4 0/4] Add metric for Arm CMN Jing Zhang
2023-07-23 8:21 ` [PATCH v4 1/4] perf metric: Event "Compat" value supports matching multiple identifiers Jing Zhang
2023-07-25 8:20 ` John Garry
2023-07-26 6:15 ` Jing Zhang [this message]
2023-07-23 8:21 ` [PATCH v4 2/4] perf jevents: Support more event fields Jing Zhang
2023-07-25 9:41 ` John Garry
2023-07-26 6:40 ` Jing Zhang
2023-07-23 8:21 ` [PATCH v4 3/4] perf vendor events: Add alias for Arm CMN PMU events Jing Zhang
2023-07-23 8:21 ` [PATCH v4 4/4] perf vendor events: Add metrics for Arm CMN Jing Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16f4eb7-24c2-fc42-964d-0b84effae9a5@linux.alibaba.com \
--to=renyu.zj@linux.alibaba.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®