From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E97C433F5 for ; Tue, 15 Mar 2022 12:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348430AbiCOMqz (ORCPT ); Tue, 15 Mar 2022 08:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233130AbiCOMqx (ORCPT ); Tue, 15 Mar 2022 08:46:53 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5605A46164 for ; Tue, 15 Mar 2022 05:45:41 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KHtMN0Gnzz9sp2; Tue, 15 Mar 2022 20:41:52 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 20:45:39 +0800 Subject: Re: [PATCH] mm/mlock: Use vma_lookup() instead of find_vma() To: Matthew Wilcox CC: , , , References: <20220314151728.20800-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 15 Mar 2022 20:45:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/15 20:39, Matthew Wilcox wrote: > On Tue, Mar 15, 2022 at 08:24:04PM +0800, Miaohe Lin wrote: >> On 2022/3/15 0:16, Matthew Wilcox wrote: >>> On Mon, Mar 14, 2022 at 11:17:28PM +0800, Miaohe Lin wrote: >>>> Using vma_lookup() verifies the start is contained in the found vma. This >>>> results in easier to read the code. >>> >>> This conflicts with the maple tree. >> >> IIUC, maple tree is the implementation detail of the vma and this patch >> should not be conflict with it. But there might be some trival conflict. >> Am I supposed to delay this patch until the maple tree's work is done? > > This function is rewritten as part of the maple tree patchset. > There's no point in merging it now, or later. > I see. Thanks for explanation. > . >