From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755247AbdFLQFS (ORCPT ); Mon, 12 Jun 2017 12:05:18 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36528 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbdFLQFP (ORCPT ); Mon, 12 Jun 2017 12:05:15 -0400 Subject: Re: [net-next] net: phy: marvell: Show complete link partner advertising To: Thomas Bogendoerfer , andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk References: <20170612133237.E20945085BC@solo.franken.de> From: Florian Fainelli Message-ID: Date: Mon, 12 Jun 2017 09:05:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170612133237.E20945085BC@solo.franken.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > Give back all modes advertised by the link partner. This change brings > the marvell phy driver in line with all other phy drivers. > > Signed-off-by: Thomas Bogendoerfer I thought Russell had a similar patch but I can't find it applied in net-next, so: Reviewed-by: Florian Fainelli drivers/net/phy/lxt.c has a similar pattern that would be worth fixing too. > --- > drivers/net/phy/marvell.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c > index 4c5246fed69b..8400403b3f62 100644 > --- a/drivers/net/phy/marvell.c > +++ b/drivers/net/phy/marvell.c > @@ -1139,7 +1139,6 @@ static int marvell_read_status_page_an(struct phy_device *phydev, > int status; > int lpa; > int lpagb; > - int adv; > > status = phy_read(phydev, MII_M1011_PHY_STATUS); > if (status < 0) > @@ -1153,12 +1152,6 @@ static int marvell_read_status_page_an(struct phy_device *phydev, > if (lpagb < 0) > return lpagb; > > - adv = phy_read(phydev, MII_ADVERTISE); > - if (adv < 0) > - return adv; > - > - lpa &= adv; > - > if (status & MII_M1011_PHY_STATUS_FULLDUPLEX) > phydev->duplex = DUPLEX_FULL; > else > -- Florian