From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D778EC001DD for ; Thu, 13 Jul 2023 15:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231996AbjGMP70 (ORCPT ); Thu, 13 Jul 2023 11:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbjGMP7Y (ORCPT ); Thu, 13 Jul 2023 11:59:24 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E98D1BEB; Thu, 13 Jul 2023 08:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kbRaRAb0JOL2/28VqRGpCqPBtBaSf/qjgEEPz4Ozblw=; b=0YXzfhdXgCkaLlwHWfhq7w7NBW B2yrKFup3FthFeXz+uny9omFu8uiDopmfNCRlhggOeUmyNdYrKGpvg0BFkhNVzp4j+/EijFlqpEDw yQT2CMGgWn0IUnANOuPuAnvUVnW5lUC6888a0ba4McrU1KWCPA+LVlSPS+Bo6KLGYF7c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qJyip-001Gmy-Eb; Thu, 13 Jul 2023 17:59:15 +0200 Date: Thu, 13 Jul 2023 17:59:15 +0200 From: Andrew Lunn To: Krzysztof Kozlowski Cc: Pranavi Somisetty , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, harini.katakam@amd.com, git@amd.com, radhey.shyam.pandey@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: net: xilinx_gmii2rgmii: Convert to json schema Message-ID: References: <20230713103453.24018-1-pranavi.somisetty@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +examples: > > + - | > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + phy: ethernet-phy@0 { > > + reg = <0>; > > + }; > > Drop this node, quite obvious. Dumb question. Isn't it needed since it is referenced by phy-handle = <&phy> below. Without it, the fragment is not valid DT and so the checking tools will fail? > > + gmiitorgmii@8 { > > + compatible = "xlnx,gmii-to-rgmii-1.0"; > > + reg = <8>; > > + phy-handle = <&phy>; > > + }; > > + }; Andrew