From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F26133F5A5 for ; Fri, 19 Jun 2026 19:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781897411; cv=none; b=qmA0mILX5RxFvA/xthL/7FT0uFgV+7srP6nc7wjttQ3zfLim3p2zYGcLjfMKmg4bSZ5KBftiqOWiZP5zaZKks4QhIr0oIsWt45wc3uexpeSt/DVy3SmUZ/O3KXOv3r5d1Rza4lNziRG55gsFNg7zM25/pyzyxifrv0QB8N2L3kw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781897411; c=relaxed/simple; bh=Oh2ybLLGC9jnpxFv2cvrWqY59mjTNtmLCVMVU0nxLTA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WRNXtO8ie1EdwAx5dbphdegtyqFeW/xSdpjiaZS1DDOtvL8DtXJyIBuN/fghf7jIuG9LOva+5x5uqwo/5CNSSvgu2FmgF103IpJg6fYauLida8AdVlkP73Egd9alIa68FSodixbU7xOIow+lVBaFg9W0W81WP2FiEEF3dKWATTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IF5Oom64; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IF5Oom64" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36d630c0e35so2412650a91.3 for ; Fri, 19 Jun 2026 12:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781897409; x=1782502209; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=7uOIAj81pDb7DXTvtaboe/dWyr0Wn96ZBecKWdg1P6Q=; b=IF5Oom6449vLnhIMgVWPw4Sr5Oh81jM7a9PwpYu6wYYunqkVz9heUGHhcr0VWahYtJ tzx5IPAKjMKnGkVssX3/4FDQbK7g3txsFEENFeZubKiNKnhpcwRVw0/PPEUec9khuwWi i6Da77lAVwHBTwfASrJ21I1T2OVcZMp8f3wnb+JUGP6KHOjrWY2nSowv/YRt2Vs/V6E9 y49McxBlxBZmuBc2N2EWb5jNzFXIbYMifVd3ER9PzgQUJEpkE6VNUdK7TzVshWBtLb8p 4rDsdyqOiZcQ+O+fKwM9SuqwRJZ6NDlPuC8ZJy6PTVtCI9+AlM4Fm4Yu2OKOq1othuqy pERQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781897409; x=1782502209; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7uOIAj81pDb7DXTvtaboe/dWyr0Wn96ZBecKWdg1P6Q=; b=lKBUXOCpeRTuKuXsEykd9sxEnzabnft+N4zhCZYjqsyafAh2MNFbCHyRMBumwkxX3B OP4IQxQISkOWpCnYgUsCWjBb1gZLhdjOP3AJUZgveN4ChyjO3gQ3JOokD9/d0F+RKHXm aSBd7PMLdg4/I2MQmQdhJ5jnVo93+FbghH166Nt7LL+8OT/BU4sY9jywAgnGzrvi9nV3 Pa/a+AHe9Wgc2+Livl5N++fRiHw5IVvMKNdYyXlH4IFzfefE7R9sQVVGNr1TjxwXHHCw UG++dm7Go9gmd4sRy3T4T51E6KgjVdHzVST91USGSvvmFbuAiZRk/J/dr4+A7ABu9oEt Zp7A== X-Forwarded-Encrypted: i=1; AFNElJ9wg0Z6TIAc0wPWKzE/GIEynVfhc55kVk0gPvH3jzj+pI99aCOmHv4jnl7GYcidfA8SPvJcMbiAAh+kCnU=@vger.kernel.org X-Gm-Message-State: AOJu0YyIbsIqYZMFRGbGRcezkv3lz1Nx9nQUZ0bJIC0Z0rMclyQ8PyYH 7g70yQq1DR9JeKOp5PcMIlFYpJC68Nqa2wwp8qAVlDGA29HQLuvjs3VE X-Gm-Gg: AfdE7cmKl8ggkhp5Xr7Yn5rjrRtdnfMjLgiKE5mNZADLH0TM1BsetyT9skY9nA/yHzo vRzP35fKYAFheH0/qE+Shrb2ZMXDM3mS/FlVzLqVeevMNIOFkxN05LWlOVMQ8VGfXH3/KailFYE RULKATGNCkZvWi6yZlM06xN87f1JOzSmfrFO/Sfugg9VHE9PO+j2JUq367YMOw0V2JZVbOnEKXT mVU5PL6dpE3JT55dH2EWjkG3eRm3JoZduTaegxfy0IbUGHM0B8seGaaCrgGCH1Da16kal57KL49 6XxI49qlA46iyrmWF+cZ+aB8LZWJRNtwbaBuHje9Efsg8MQHKDq9z23v2m896yBNqRd0Xeo5q/O lIY1mKlTVXB1YHzwd7OLGwy7k0x/a3v5DJOXr++WSYe99SGwh84P2RaRyAAPya1kAPq+Gju3dQa ESmIaswmK0tAHtaNgXdqNhO5EskcFGO96XYkqBe5Pveg== X-Received: by 2002:a17:90b:2709:b0:35f:b987:4dac with SMTP id 98e67ed59e1d1-37d15e51976mr5755105a91.12.1781897409221; Fri, 19 Jun 2026 12:30:09 -0700 (PDT) Received: from [192.168.0.226] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d1558c6cfsm3705447a91.8.2026.06.19.12.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 12:30:08 -0700 (PDT) Message-ID: Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Cover refcount acquire node offsets From: Eduard Zingerman To: Yiyang Chen , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi Cc: John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , Viktor Malik , Leon Hwang , Dave Marchevsky , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 19 Jun 2026 12:30:05 -0700 In-Reply-To: <264dd4a10d3abdd037e01ccc6da44e5a5758dee2.1781852308.git.chenyy23@mails.tsinghua.edu.cn> References: <264dd4a10d3abdd037e01ccc6da44e5a5758dee2.1781852308.git.chenyy23@mails.tsinghua.edu.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-06-19 at 07:59 +0000, Yiyang Chen wrote: [...] > diff --git a/tools/testing/selftests/bpf/progs/refcounted_kptr.c b/tools/= testing/selftests/bpf/progs/refcounted_kptr.c > index 61906f480..7955a9973 100644 > --- a/tools/testing/selftests/bpf/progs/refcounted_kptr.c > +++ b/tools/testing/selftests/bpf/progs/refcounted_kptr.c > @@ -741,6 +741,39 @@ int list_push_back_uninit_head(void *ctx) > return ret; > } > =20 > +SEC("tc") > +__description("refcount_acquire_list_pop_container: acquire normalized l= ist pop") > +__success __retval(0) > +int refcount_acquire_list_pop_container(void *ctx) > +{ > + struct node_data *node, *base, *ref; > + struct bpf_list_node *list_node; > + long err; > + > + node =3D bpf_obj_new(typeof(*node)); > + if (!node) > + return -1; > + > + bpf_spin_lock(&lock); > + err =3D bpf_list_push_front(&head, &node->l); > + if (err) { > + bpf_spin_unlock(&lock); > + bpf_obj_drop(node); > + return -2; > + } > + > + list_node =3D bpf_list_pop_front(&head); > + bpf_spin_unlock(&lock); > + if (!list_node) > + return -3; > + > + base =3D container_of(list_node, struct node_data, l); > + ref =3D bpf_refcount_acquire(base); > + bpf_obj_drop(ref); > + bpf_obj_drop(base); > + return 0; > +} > + Why do you think the positive test case is necessary? [...]