From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3577C05027 for ; Thu, 26 Jan 2023 14:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232341AbjAZOyc (ORCPT ); Thu, 26 Jan 2023 09:54:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231879AbjAZOy3 (ORCPT ); Thu, 26 Jan 2023 09:54:29 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD5DAE4; Thu, 26 Jan 2023 06:54:28 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id DD5BC320094D; Thu, 26 Jan 2023 09:54:27 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 26 Jan 2023 09:54:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674744867; x=1674831267; bh=O65c494cb3 exhJTXkFN/i23AZGvt2EvCcOJToJAR7dw=; b=b0VSJuSxH+vNMSrXy1BMSovjo6 s/ReTGShWA135o7NrieDIxYUV/wOvVBCQYvR0iNPtj6cK9nQHDBAmpbitbf6LfFu gdllSCcQYxuvoTLeqS1/pjJC6IaDS7zt74H/0gVjqL+E5pmp2QKC6JQNIoxjVWnR q57tXCB1c4YUXMrbOQLIqGk4UXQbW4TKPfjW/mzxV78qxJuQmH20k2z177/vzztt UtLJs1+hRKNUKSv2Vw2xLH+RmKezly7SXFSq6Q4ad1jNJ4uxal76ybG6QI98BvAc SrIUkhE3GQNftBVyZzGHy3IBRisbIgJcdBpgeX8cCL69kqGSxauoVrENZIiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674744867; x=1674831267; bh=O65c494cb3exhJTXkFN/i23AZGvt 2EvCcOJToJAR7dw=; b=PHj0Fnbh3jRfff0EzC9TYbbdKKtVF8Dob6X8pf6kmfSH LiECumpSUVOaCIT0tslzyGA9N2kyS08AhWxVoEBn2aVVMZmN4UswVqUrKpicqHup ZLw74pidZ0aaDCNEfiFveN1ShGRSMP/DTgiP6KkKCeAD6Qjg16O6oyAeEOifIZzI g8O35qlP+ho9Nmb4685bnsTYIXezKikomgNnSzTPbJjijVTyNlCAetsAfRi4jB+q 8uHArkl9lzqT1EK4VVQ/5k+4vu8zqHTPDd89k/u4jh3N4aOdvhy7dPonojjy0rG6 lYDMiuxxzS90ESsXMmH8IKadO1lVWpf1W4AZ2LvaxQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvgedgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5289CB60086; Thu, 26 Jan 2023 09:54:27 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230126132801.2042371-1-arnd@kernel.org> <20230126132801.2042371-8-arnd@kernel.org> Date: Thu, 26 Jan 2023 15:54:07 +0100 From: "Arnd Bergmann" To: "Andy Shevchenko" , "Arnd Bergmann" Cc: "open list:GPIO SUBSYSTEM" , "Bartosz Golaszewski" , "Christophe Leroy" , "Dmitry Torokhov" , "Linus Walleij" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2023, at 15:08, Andy Shevchenko wrote: > On Thu, Jan 26, 2023 at 02:28:00PM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> This is a rarely used feature that has nothing to do with the >> client-side of_gpio.h. >> >> Split it out with a separate header file and Kconfig option >> so it can be removed on its own timeline aside from removing >> the of_gpio consumer interfaces. > > One nit-pick below, otherwise > Reviewed-by: Andy Shevchenko > >> >> +config OF_GPIO_MM_GPIOCHIP >> + bool >> + help >> + This adds support for the legacy 'struct of_mm_gpio_chip' interface >> + from PowerPC. Existing drivers using this interface need to select >> + this symbol, but new drivers should use the generic gpio-mmio > > gpio-regmap > > I would even not mention gpio-mmio. Makes sense, thanks! Arnd