mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guo Zhengkui <guozhengkui@vivo.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"zhengkui_guo@outlook.com" <zhengkui_guo@outlook.com>
Subject: Re: [PATCH linux-next v2] selftests: net: change fprintf format specifiers
Date: Sat, 19 Mar 2022 15:09:02 +0800	[thread overview]
Message-ID: <a183d3e8-563e-6e0c-9796-4053e2bad6b7@vivo.com> (raw)
In-Reply-To: <20220318093300.2938e068@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 2022/3/19 0:33, Jakub Kicinski wrote:
> On Fri, 18 Mar 2022 15:50:13 +0800 Guo Zhengkui wrote:
>> `cur64`, `start64` and `ts_delta` are int64_t. Change
>> format specifiers in fprintf from '%lu' to '%ld'.
>>
>> It has been tested with gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
>> on x86_64.
> 
> No, not like that. Please read up on printing int64_t.

Sorry for misunderstanding. I wrongly thought that it's just for 64-bit.

So I should use `PRId64`.

Zhengkui

  reply	other threads:[~2022-03-19  7:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 11:50 [PATCH] selftests: net: fix warning when compiling selftest/net Guo Zhengkui
2022-03-17  3:22 ` Jakub Kicinski
2022-03-17  6:51   ` Guo Zhengkui
2022-03-18  7:50     ` [PATCH linux-next v2] selftests: net: change fprintf format specifiers Guo Zhengkui
2022-03-18 16:33       ` Jakub Kicinski
2022-03-19  7:09         ` Guo Zhengkui [this message]
2022-03-19  7:37         ` [PATCH linux-next v3] " Guo Zhengkui
2022-03-22  0:00           ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a183d3e8-563e-6e0c-9796-4053e2bad6b7@vivo.com \
    --to=guozhengkui@vivo.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=zhengkui_guo@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®