From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BB434CFC0 for ; Fri, 21 Nov 2025 11:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763724479; cv=none; b=u2tBOxp90vM1rxNJAlw3nHJNfRlbRsBRgn0lOlKUMKGwJ7RhusZ0zPjQSC5rwujEDR4YhPJCjB51asrUL1hGLdQPn0UgV1AXaL+uBcYkf2TpquGdmtVbOfwX07+gJRcrBNih7ZZUI2GqyradFTmPYt/302gr9vhpsnuJuJMJbeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763724479; c=relaxed/simple; bh=FR/l64BfQtWcy5AmGa/x0Kd+BcD5MaBGaBHWSqd/0I4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i/KRx1KYs1IpSZbaVUfqb4YHj32Juz6mKDIdjZGzEktBqgSbYFYkTQt1HzCVQbTgKmPX2DklD3lcan1fyTWzP2ZuoWG1LdtCgVKE47RlOqmgkTh2XnG3NW8TJVu/jgTf9BoDVhgQPQ+UsBK3dW3nMpnf3r6WY+eiPbTxBigBKYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JIkOPlmJ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIkOPlmJ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7bb710d1d1dso2854031b3a.1 for ; Fri, 21 Nov 2025 03:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763724476; x=1764329276; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1R2yvLJT9l2sebGa7bGBLAEk2UsFTKZ/XGXxsCh1YW8=; b=JIkOPlmJU4yMwEm0Q/rJCsJtNZOFHhTRj3qJeP3miCbTw66YUADhTzPObPOFSRLgCs PPnINZ3RZHjy0IE39DxdBC8ij2J8Crvp7TP7iX7Aq7EhLwtHBzpzLHnPkp+9Vmqath6h 2X0Iua5WmymRsU6U9gtI+eXXyjFtcoFRcRF5da4U77DCBpoymEO+0jJ0dK9w6IUKCVQQ hfMP3EW/mPgKi18kd+CDNBYJznZ5CqMVfvo3tYLFzc+sNEsYpWQKJDZE19BGinY2ynPr hGmIijDurGzDoUM4Xb4a+zbeOrJFEWpkxy0/AFkUEC5cazs9NAh5YbKjPvSOBIJmXbr1 iRZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763724476; x=1764329276; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1R2yvLJT9l2sebGa7bGBLAEk2UsFTKZ/XGXxsCh1YW8=; b=KsgAtEHO8vnECeISbytrOQ3k5ujvfW0JUpFUfaRW1821ZzfK1sonyWEt5DY0dIiV+3 hyG6HaCPceJeOy3zs1c+wShIF193a0BiuhdbqLl2moH7rqlRJ2oZdQV67QXXzlJszuKV Mki3ICV8L2soeul25kmx8/i9s+me6a8as1W8IdBEIF10nWjgvRL2/1H45ytVMpuj5Nbu IQT8MtwSZvDwrW79Qjczjzw6flYTHj6COBseRaUWYlBW8NMo3s9/4A3kZx7686ky9lNx 3lVX9kCT5JFF0fA443/dvoyA/ZuZWBpCD1SQE8WvqK8IkrzznRk3VR1LQxO8O+PEQ3qm EqZw== X-Forwarded-Encrypted: i=1; AJvYcCW3Eb1C7+VqRX27X9Nvlz/j2PzH6LeCA2ncXBWygJ7Chy3HcZ+u3umopxYhVNsdMUCufHtdq3iDd0BFpdw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd6F97vpwkDFluSqg3oXwr2nrnOMYDJgTj0XwCxQn83rcqoiXF 7swoQYsjOvhjytQLlbDh+gNlzP0xTJ9gVOns9VZlu4sTuL3v6uEUS4eM X-Gm-Gg: ASbGnctPLXI1HAwCVlqcJ+JUt3pYCC9S9CVyZSgyjXThjWNyAjEI+haqy3rVLCdfZTN YP6KI5uSP2bHIkos8Q5eePqn5ImcYkYLFyDUOf9D6+3oH82dJF/8quuHzQdb+bg66zwnxNRJQyO hDN+rgj5QaZkDJa0vnG7vhRcyuUrdlqlkcnGadMQQiC3cwUr/OcGSSC+Sz3UdnpIXhiNbk++BH9 b5+5gFmU+1XDV3HwebcLL2UW6t+iFbQ1/bQIvzW4gxLj1OJvhZEFhou24RXnu2ZaY9YRPuKAASH vFjKRs3R3weE719ELAEBJsN8jM8Gtu96maJ/zL5LE14oshWHw8y0qYSdEX58wu0HlGogj6iIYLo KsUy3fIbsY8wtgbEMSQLNlbdc/7Hwe/ss1QpdkvHOZrqYQ1w96v0SIwBkfZWEGS+IGpIsSc1lhi macHj3wgyhFjg5wYqcTOUHXZ9D+smvZn5ZosQzSBG5/0srAiey50iehQYaDxxyH+D4 X-Google-Smtp-Source: AGHT+IGx1kj8XCwGhrb2uV3Nnb7QEjcdqvgrN3fzzNee0TinoDaJQazabZ6HTuolBNuWue92taBcWQ== X-Received: by 2002:a05:6a20:3ca3:b0:35f:cfb:1efb with SMTP id adf61e73a8af0-3614edd7f17mr3004978637.29.1763724476323; Fri, 21 Nov 2025 03:27:56 -0800 (PST) Received: from [192.168.68.63] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd7604de4cdsm5274052a12.20.2025.11.21.03.27.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 03:27:55 -0800 (PST) Message-ID: Date: Fri, 21 Nov 2025 03:27:54 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8960: expressatt: Add Light/Proximity Sensor To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251119-expressatt_nfc_accel_magn_light-v1-0-636f16f05cf4@gmail.com> <20251119-expressatt_nfc_accel_magn_light-v1-1-636f16f05cf4@gmail.com> <742601dc-32d8-41ff-8e2b-a960f6fe77ab@oss.qualcomm.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: <742601dc-32d8-41ff-8e2b-a960f6fe77ab@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> + >> + i2c-gpio-sensors { >> + compatible = "i2c-gpio"; > > Are you using gpio-i2c for any specific reason? Would GSBI2 not be > connected to this pair? (I am not sure FWIW) This is interesting! Downstream uses i2c-gpio and I (well, Claude) used that. Seems like downstream doesn't define a GSBI2, so I guessed it's structure in the dts and it seems to work! Thanks for the suggestion. No GSBI2: https://codeberg.org/LogicalErzor/Android_Kernel_Samsung_D2/src/branch/cm-14.1/arch/arm/mach-msm/board-express-gpiomux.c#L411 >> + amstaos,proximity-diodes = <0>; > Try comparing the values the upstream and downstream drivers write > to the device, maybe you're missing something Yeah, I'll continue to try and do that. In the meantime I'll send a v2 so I can get further comments.