From: Sebastien Boisvert <sboisvert@gydle.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
akpm@linux-foundation.org, mjeanson@efficios.com,
rostedt@goodmis.org, lttng-dev@lists.lttng.org,
linux-kernel@vger.kernel.org
Subject: Re: [lttng-dev] [PATCH v2] mm: Rename mm_vmscan_lru_shrink_inactive trace event variables
Date: Wed, 22 May 2019 10:39:44 -0400 [thread overview]
Message-ID: <a187c72c-9ca2-7668-fc60-e9c310c30d5c@gydle.com> (raw)
In-Reply-To: <9b9a8da4-556a-8972-cf87-071ce5099ad0@virtuozzo.com>
On 2019-05-22 6:17 a.m., Kirill Tkhai wrote:
> Rename nr_activate{0,1} into nr_activate{anon,file} since this
Rename nr_activate{0,1} into nr_activate{anon,file}
^
add an underscore here
(nr_activate_anon, nr_activate_file).
> is exported into userspace, e.g., it's shown here:
>
> /sys/kernel/debug/tracing/events/vmscan/mm_vmscan_lru_shrink_inactive/format
>
> v2: Changed suggested person (sorry, Mathieu :))
>
> Suggested-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> ---
> include/trace/events/vmscan.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
> index a5ab2973e8dc..c316279715f4 100644
> --- a/include/trace/events/vmscan.h
> +++ b/include/trace/events/vmscan.h
> @@ -348,8 +348,8 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
> __field(unsigned long, nr_writeback)
> __field(unsigned long, nr_congested)
> __field(unsigned long, nr_immediate)
> - __field(unsigned int, nr_activate0)
> - __field(unsigned int, nr_activate1)
> + __field(unsigned int, nr_activate_anon)
> + __field(unsigned int, nr_activate_file)
> __field(unsigned long, nr_ref_keep)
> __field(unsigned long, nr_unmap_fail)
> __field(int, priority)
> @@ -364,8 +364,8 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
> __entry->nr_writeback = stat->nr_writeback;
> __entry->nr_congested = stat->nr_congested;
> __entry->nr_immediate = stat->nr_immediate;
> - __entry->nr_activate0 = stat->nr_activate[0];
> - __entry->nr_activate1 = stat->nr_activate[1];
> + __entry->nr_activate_anon = stat->nr_activate[0];
> + __entry->nr_activate_file = stat->nr_activate[1];
> __entry->nr_ref_keep = stat->nr_ref_keep;
> __entry->nr_unmap_fail = stat->nr_unmap_fail;
> __entry->priority = priority;
> @@ -377,7 +377,7 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
> __entry->nr_scanned, __entry->nr_reclaimed,
> __entry->nr_dirty, __entry->nr_writeback,
> __entry->nr_congested, __entry->nr_immediate,
> - __entry->nr_activate0, __entry->nr_activate1,
> + __entry->nr_activate_anon, __entry->nr_activate_file,
> __entry->nr_ref_keep, __entry->nr_unmap_fail,
> __entry->priority,
> show_reclaim_flags(__entry->reclaim_flags))
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
next prev parent reply other threads:[~2019-05-22 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:44 [PATCH] " Kirill Tkhai
2019-05-22 10:17 ` [PATCH v2] " Kirill Tkhai
2019-05-22 14:39 ` Sebastien Boisvert [this message]
2019-05-23 16:13 ` [PATCH v3] " Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a187c72c-9ca2-7668-fc60-e9c310c30d5c@gydle.com \
--to=sboisvert@gydle.com \
--cc=akpm@linux-foundation.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lttng-dev@lists.lttng.org \
--cc=mjeanson@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®