From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E5026C3B0 for ; Mon, 8 Dec 2025 16:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765211900; cv=none; b=ISMdRiQrv1dlYp0ZNpn1zinDbZ2HyZ2ltK5u0nY0l2DKOASgRC0XuwTGaB0tX0vpbz9Nfp1LyZ68QAsaMPjC36JmcEooXLAjaHxVzK36n29lNJ4AM3ZRSw2aS+OatZiDRNNbTzr/mHY3Le1lVihxOa1LU0gbDCq7HlJ+nbgQQmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765211900; c=relaxed/simple; bh=3Jn8acQZ7QuhgQ7B8N0UAPFkcToKf6t8l6ew/re6yPI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GyIoJqDF5+R35YMWKRCG84grwpbVcpZrysnLaS5Vw7c6DIBB1wdIOu/mKz4AwRdaWO5yLV3T1QkBa691uC30R/fbD2G20qNDjN4pMCiEqCRt5XUDtKeyzzlNWANcwNzOe36SuMVPaw16JJXlgtycFRDsXMR2zsLZljl99YOqLZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=XinMbN0W; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="XinMbN0W" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 3BA1C3FBAB for ; Mon, 8 Dec 2025 16:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1765211891; bh=aTNY4Xh/ROKfLe2vsQMihdbK2756ZAjBs/JjXED0kyk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XinMbN0W0YAvm8JAsNww4z+9UVFNsAazR8I3x1OFu+DYTxEezI72ZAa3EPF68QWvO sSIpX4pXfjaG/U63AhWktIukVHdkgJ5NcrGzeWHSGml4wmLBvNFBPhAqfItc4oExgL FpeoNPXPDXW1C2V4kJthBdX8jp65pEeN6V/RsaiBz3ighbCPeUyeax5IfzfZlroJ+p PzobsejnWxB9vdMVs+CRnSnxOs2X2okgxlmSuzETR2Gk5B44s8fWELL266dkZEEgu3 DF3I1TXT6SP+wmz4p+AR20kjUkOux7SJ3Zw0XZl9YgWWm6BWC1Fxiv2K/1M5rlowOm ap4T5Wgd5vpug7SqUBBB6hFlRdrSMH8on9gdFAwCjFrzGKN9EmFhkQVifyI5RbEtrB trhXZMfdEKDzg3gHwogtIBSNRZ5tnVdNkymqzYYih+aKHupvjCPi0dYMWWWS5vlDqG c6C8ZTdXM5FDv8Brqj5GFb87VyDCtrfLUPYiTDAbwCmT93XMpPmewKv8hszVwNxI3n Byg/6bgTzleMzhxm0d5Ng16rsf5Gl7z4Xq2O7hXAx3WgXMQ+Ms8ifEicKVUxvrbWix jt0bHex7EMrAqV5yGapHnys1T20eBf6vnmGMKeYzYOU4nmbPMeESnLSzMvVlLaQpFH olBFfIvRC52DeV0GP7FNz85Y= Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4775f51ce36so38480365e9.1 for ; Mon, 08 Dec 2025 08:38:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765211890; x=1765816690; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aTNY4Xh/ROKfLe2vsQMihdbK2756ZAjBs/JjXED0kyk=; b=vUHcIgk54kftUypPhmJwmQPMRf/tCy01RzZLS7oh9KILpKyry+9bS2sxxFuaMCW4jK Q/MMi1aBhLznFFhQDQCpQbq9117lMpAlnv5aXFVkJxiUSvApm2zuAXIy1ympgqfotAg3 IkXX6zdXK7vDEawgUTEqlLfVXq+7FJxCWS3q9j++0V0Lqf0Pr27cEHNj5BgOPNo0yuiK Hu853pNZBdVH3/kdTbN/iEZ0bH5x3vqbpF2AYpwbbGiPfyl3QVLaTySP7OJOMG3hNg26 hY9MQWyCFWi+LAJaOLPA2VQxkvY3ZNSGmfvUf+PWbkcjJ/cbG3hUiq1jXtI3nZeVVwah RqRQ== X-Forwarded-Encrypted: i=1; AJvYcCXo3iRd4TjNeUeTnC/eYsvnwNYdUHAEWRYskyXBxX4K63I5QFz7IjA8/vItHo+A5640Fv98ARBUgDVu5iI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2IkpmcWlsiRpI8+hPIvA6iBcB7PwWKLTOLCKM025eyG7505hR kTF1TN1+yRWKm25BEQSQXlE8r8Hm6nd+NiCR+tAkXUG/ovesP63Nl4ydhTpF25nAKF+EW/bjxbp kaVKs5lMPyas4KoSUbJS7dc02QQ6I6ar7fFXCTg670KUHyUZYz6ngsHBwfwoYGithWhwCBEQeaL 1XzBYlpw== X-Gm-Gg: ASbGncsbdGHq/C2pl6vVN0G4mPNpd/he8SyyRgnqCxnHKxMDyMVrqoODXTpFoBQH1Lh tVx8Y7uI4aBijc4migSHcO7ML2IdOAuY6NPMzSa7JCNGYNzooJx1jD4LhvZAqw2ZCWCwvXFoWKf 7cxHsZTjrSzf2QUUZSsbjXx8nFVU1QyvIyrCk5ieLLcsJBE6AMhzSRv3r9durL0fToteYabu7Zl CEEQMUAFlzOqCo5ntf9VyE2u6P5TlST5bidducsVkU/nsYP4I3igue3EXoQ45gA1cP+daWGzxHf 40vjsLRWVk/u35Coo+aYSX/GvL7sl48RPqLYASsqXbGl83EeA1BotOii/qZfHlqzFU2IsnHBqHV p/jgKSYGPLy/4SkPg1NtuUhNz/jq6mGQ0Q14c3AWutsFGt/STeelIbKcC+7CvtqwvUt5l2mVrWp 9FwrP/Nmg= X-Received: by 2002:a05:600c:a48:b0:477:9d54:58d7 with SMTP id 5b1f17b1804b1-47939e43adcmr74225205e9.29.1765211889680; Mon, 08 Dec 2025 08:38:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWjq5KbylI+YdbbKo6HpBQI4IH+OKq2snRjF/orQKP8xyyNE6QdOCUkPtdXSTe5KyQiB8V1w== X-Received: by 2002:a05:600c:a48:b0:477:9d54:58d7 with SMTP id 5b1f17b1804b1-47939e43adcmr74224985e9.29.1765211889203; Mon, 08 Dec 2025 08:38:09 -0800 (PST) Received: from [192.168.103.125] (ip-005-147-080-091.um06.pools.vodafone-ip.de. [5.147.80.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7cbe9065sm26455128f8f.8.2025.12.08.08.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 08:38:08 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2025 17:38:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] riscv: dts: starfive: Append starfive,jh7110 compatible to VisionFive 2 Lite To: Conor Dooley , E Shattow Cc: Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Hal Feng , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Emil Renner Berthing , Conor Dooley References: <20251206204540.112614-1-e@freeshell.de> <20251208-jogging-morally-9b787b7ab1b8@spud> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: <20251208-jogging-morally-9b787b7ab1b8@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/8/25 17:29, Conor Dooley wrote: > On Sat, Dec 06, 2025 at 12:45:30PM -0800, E Shattow wrote: >> Append starfive,jh7110 compatible to VisionFive 2 Lite and VisionFive 2 >> Lite eMMC in the "least compatible" end of the list. JH7110S on these >> boards is the same tape-out as JH7110 however rated for thermal, voltage, >> and frequency characteristics for a maximum of 1.25GHz operation. >> >> Link to previous discussion suggesting this change: >> https://lore.kernel.org/lkml/1f96a267-f5c6-498e-a2c4-7a47a73ea7e7@canonical.com/ >> >> Fixes: 900b32fd601b ("riscv: dts: starfive: Add VisionFive 2 Lite board device tree") >> Fixes: ae264ae12442 ("riscv: dts: starfive: Add VisionFive 2 Lite eMMC board device tree") >> Suggested-by: Heinrich Schuchardt >> Signed-off-by: E Shattow > > You can't do this without modifying the binding too, as this doesn't > pass dtbs_check. > > However, is this actually correct? The frequency of operation and the > temperature range aren't a superset of what the jh7110 can do, what is > the actual advantage of having it? If there's some software that this > would make a difference for, please mention it in the commit message. Appending "starfive,jh7110" would reduce the number of compatible strings to check in the OpenSBI platform driver. Best regards Heinrich > > Cheers, > Conor. > >> --- >> .../dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts | 2 +- >> .../boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts >> index e27a662d4022..7544efa95de4 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite-emmc.dts >> @@ -9,7 +9,7 @@ >> >> / { >> model = "StarFive VisionFive 2 Lite eMMC"; >> - compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110s"; >> + compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110s", "starfive,jh7110"; >> }; >> >> &mmc0 { >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts >> index b96eea4fa7d5..b9913991a1b7 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-lite.dts >> @@ -9,7 +9,7 @@ >> >> / { >> model = "StarFive VisionFive 2 Lite"; >> - compatible = "starfive,visionfive-2-lite", "starfive,jh7110s"; >> + compatible = "starfive,visionfive-2-lite", "starfive,jh7110s", "starfive,jh7110"; >> }; >> >> &mmc0 { >> >> base-commit: 5e5ea7f61610239fca058011e7d4f342b34d1558 >> -- >> 2.50.0 >>