From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793707633; b=oCOGB/61ua1PuG2NCAZdOZuS49MKfOU15uGBMzzITV3WdMFeU/8mY/0TkjRP3KnSErA7 J5zuE+zmRhEdwYB4V3zu99DsNLJWz4AOf4EFEVu7JEubhhQBNSWpYQzWT2Qfm+6fSeTvt xIj3SMwfiBoONnIioWzb3xTgFEq0s68huf/3aklcxPr7PTTeoIc/9HBlIEdFPHIWMldy+ y0zJhfm0wVbsU/KtuU1JKDyfC2OcDRFN0aPlIISDXpxSrWOQxz2sy6vI2wbpjI3polidS nyowVgwzMqhQ6Z+BwFqQj72H65yjle9inA3EyRNukUuBxedKC9z5G0slhHZvs8Hbodw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793707633; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=ySKYasBAII9CIYefFSpb/rg/yMp8IEyXS3kf72/gGBA=; b=vhIOB0C7KIx1coSn5Bi1AkecdhUkwwY/crEt9enCOPXZAxNnxNAbMAaotdPeF92p0lVc +jXyT7NAPBteqj2AzAYIm11NNrYvAEVgWq1V811T1KIKg+RaDADCHVOo5Xlm9OaWGWjdk jFIGZSqbLVzKf2WWg6gXy7/LfkwTOAOoDBjbXaARyhRG8E6fMfq9ksT8gCrQcHG/BTG/U NyYmGYbNjQkhoUApwjtyIULmTmPLScRjWptgfYReVtTlPr8ERWgpjusfcAtbIL9wtb91y v387HTqwpyUIxU9tRXybPbHxdNpFKi/Rzuo8s67kAM1Lqpg0bpLzcHBWCQnhK9e+QpA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=m3WUwboX; arc=none smtp.remote-ip=209.85.221.41 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 461CE606A331 for ; Tue, 3 Nov 2026 12:07:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 461CE606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=m3WUwboX Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-48df4e9d2d4so2208210f8f.3 for ; Tue, 03 Nov 2026 04:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1793707631; x=1794312431; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ySKYasBAII9CIYefFSpb/rg/yMp8IEyXS3kf72/gGBA=; b=m3WUwboXryGP5oVHnpI0HTzT9uj7fYvhet6mk4sWWx0x4PrenYceEUJlv3euNPKAEo BbArikY82AVFcsR3v3ktJXu59DemC8n06or/d9t8esVwbC+0zqTm+veRMq9ktkjRDpWK FFldoBEWsCAFy3szNe2uF5pilY/Qdbzg/BIQA9g3Yxs9pWFLrBebl8W3+IY9hDUTNj7j A+aixhJV8XJQnDBA7LLphsWRsi2u5wYREm1FJDZ9B+3M3ep8ZkgORTwBQh+2smHpbCKd hIE1bmbd9UxOBmBJtP6w+vYznTkRkhYQS4gTSNHh+ca/oAGe7BqS99MI3g8T6Gb/c8Ow AkkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793707631; x=1794312431; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ySKYasBAII9CIYefFSpb/rg/yMp8IEyXS3kf72/gGBA=; b=gPdFGIaiOqdDxW+f38EzzMMNgk4nU6ll5qZsA86o/Bz6WaSP5V2+KiUfo1oaIRy93w bOLKPytSuhPYLE1SnEb4oDZQckDtzqZTZkjBU5MGB6GZxpt+btJaP6sPJ3Umxd118AW9 Ioi+ShavVZYr7H9HcizXF4xavNFLKyc3toVN1ksz9lgy26LvsyGDlw2H7VX1/KfaY9cS rQ0JiW3D9EQpxS+Sz1Jw848UIz6jF4uMyZkbZ8CtOUm1jof8jaOq8tKsQ9T+8FhZkugW LRii0h1815BACzu2VoX+A+G7Eb1n1sdV06UBWnUtbNUOBYVskj0Y20KYKBD/XXx/ABGq k3/g== X-Forwarded-Encrypted: i=1; AKwUvBx7M0zmf/2j+M1G2hfUocWLBU+o6TgEwG2/HP7A45KPdmCgiiWLg6ZB/TfLYIgt1kyO8KWFTIuWkXbWNZs=@vger.kernel.org X-Gm-Message-State: APuU4Z8jANq6XvPF8nArtfq4H6etWZZX6na8N2EISEp3OSmwMFWVS3HL CCT7pwcC4AksYosApLo17T//GP1TkPuvFY5bjxfrhlp37uF9JQVUahpEqZ418RR7Fc8= X-Gm-Gg: AYBFou3wlFhcg7O0qeMMxYPhCKzCiW9qRQl7g/P7UWKpTdENjml5Srcyqd05G9ukLml X5SZsabFR9QIUiuPkicbxL+qSJjjM/0rfbw5npWT5+XSVPaHcWBSDG5GkK4KXAiv0oXi0Pha2Y6 AwHSsb60xQlabTB5J+WE5EZMQH5PLrk+AcRgTj1v6yo9lk2+re5aL+ue+1DPo5GjBirJhFv/Gj3 LJLFZE1pRFSoRelj0N+gycRK0O5ee2fble4vkH6WbXUYh0aE0bdSjPnzcbvNEl3s4k3VChse/s0 WkWeh0zSq4SzoEnie5gUxinvipbEZ1jpjmy6Z5XOzYzJJ4z3VHUBqMgIlbiefigLkpQ0h5o5VFg xzM1fC3YSzkTC60aMERWCJ43i5NCU/T/6s1DHcp8QaJ+riyS/IwXJaX2JJQokPxFu388KJL103H 1f8viBCLf4Uziq5Z67Nwx4M25VANzhK/2Jt4OsyuuGq2eBaJfiRZJEVM7eKXtnkv4f/IaRhZE0L 3eRGSDDJE40H3/gg3/Nu3GwpTZ1POQ8d0v8i7L9vXoepdbdq7sl40Wp+BJ03DUi8ZiTGOG66Sp7 LYAIDihV0C876fM3CxwAQFxVUleiS3Mn X-Received: by 2002:a05:6000:4311:b0:48e:20ed:d5e7 with SMTP id ffacd0b85a97d-48e6e2ff167mr26869683f8f.34.1793707630565; Tue, 03 Nov 2026 04:07:10 -0800 (PST) Received: from [192.168.1.3] ([37.18.141.193]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b8c0b6sm23904045f8f.41.2026.11.03.04.07.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2026 04:07:10 -0800 (PST) Message-ID: Date: Tue, 3 Nov 2026 12:07:09 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] perf vendor events arm64 AmpereOneX: Deprecate BPU_FLUSH_MEM_FAULT To: TAKANO Mitsuhiro Cc: Namhyung Kim , Ian Rogers , John Garry , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ilkka Koskinen , linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo References: <42801873-8908-07a6-aed1-c7076c689e8e@os.amperecomputing.com> <20261103112609.3772250-1-takano32@gmail.com> Content-Language: en-US From: James Clark In-Reply-To: <20261103112609.3772250-1-takano32@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/11/2026 11:26, TAKANO Mitsuhiro wrote: > AmpereOne named event 0x121 BPU_FLUSH_MEM_FAULT until > commit 10a149e4b4a9 ("perf vendor events arm64 AmpereOne: Rename > BPU_FLUSH_MEM_FAULT to GPC_FLUSH_MEM_FAULT") renamed it. The next patch > in that series, 16438b652b46, added the AmpereOneX tables with the old > name in memory.json, so 0x121 carries two names: GPC_FLUSH_MEM_FAULT in > core-imp-def.json and BPU_FLUSH_MEM_FAULT in memory.json, and the > default perf list output shows both. The old name has been in every > release since v6.8, so deleting it would break scripts that use it. > > Mark the entry deprecated instead of deleting it, as Ian Rogers asked: > perf list then shows 0x121 once while those scripts keep working. The > x86 tables use the same wording, and > commit eda39f98bbc5 ("perf vendor events amd: Reintroduce deprecated > Zen 5 core events") brought back deprecated AMD events for the same > reason. The flag is only read when listing; the entry still registers > event=0x121, so perf stat -e bpu_flush_mem_fault resolves as before, and > regenerating the tables changes nothing but that flag. > perf list --deprecated still prints the name in the text output; the > JSON path does not consult the flag, so perf list -j cannot show it. > No metric expression and no other file refers to either name. > > The duplicate came in because jevents checks repeated names, not event > codes, and one encoding carrying several names is legitimate, so nothing > is added for that here. No AmpereOneX machine was available, so the > listing was not run on hardware; Ilkka Koskinen, who added both tables, > tried v1 and v2 and reports that they behave as expected, and his > Acked-by is for this variant. The JSON edit and this changelog were > written with an LLM assistant, Hermes Agent, working from the code and > the thread; the checks above were run here. > > Fixes: 16438b652b46 ("perf vendor events arm64 AmpereOneX: Add core PMU events and metrics") > Suggested-by: Ian Rogers > Link: https://lore.kernel.org/20261021224527.167637-1-takano32@gmail.com > Link: https://lore.kernel.org/CAP-5=fX+2eRGCHcU43sqU=gi9iKvxqyS6ipwRSnvFcap3D+QzQ@mail.gmail.com > Link: https://lore.kernel.org/42801873-8908-07a6-aed1-c7076c689e8e@os.amperecomputing.com > Acked-by: Ilkka Koskinen > Signed-off-by: TAKANO Mitsuhiro > --- > v2: keep the entry and mark it deprecated instead of deleting it, > as Ian Rogers suggested, and word both descriptions the way > the x86 tables do. Ilkka Koskinen Acked-by v1 and asked for it > to be carried over to v2; the description wording was added on > top of that, as said in this thread. > v1: https://lore.kernel.org/20261021224527.167637-1-takano32@gmail.com > > .../perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json > index 6c06bc928415..114f95e41e0d 100644 > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json > @@ -35,9 +35,10 @@ > "ArchStdEvent": "MEM_ACCESS_CHECKED_WR" > }, > { > - "PublicDescription": "Flushes due to memory hazards", > + "PublicDescription": "This event is deprecated. Refer to new event GPC_FLUSH_MEM_FAULT Flushes due to memory hazards", Extremely minor nit, but there should be a full stop before 'Flushes'. But if marking it deprecated makes it not show in Perf list, then it doesn't make a difference. Reviewed-by: James Clark > "EventCode": "0x121", > "EventName": "BPU_FLUSH_MEM_FAULT", > - "BriefDescription": "Flushes due to memory hazards" > + "BriefDescription": "This event is deprecated. Refer to new event GPC_FLUSH_MEM_FAULT", > + "Deprecated": "1" > } > ] > > base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4