From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS
Date: Fri, 27 Oct 2023 09:36:22 +0200 [thread overview]
Message-ID: <a1895327-b520-4f3a-a427-0947ac46495c@linaro.org> (raw)
In-Reply-To: <20231025-topic-sm8650-upstream-remoteproc-v1-1-a8d20e4ce18c@linaro.org>
On 25/10/2023 09:35, Neil Armstrong wrote:
> Document the DSP Peripheral Authentication Service on the SM8650 Platform.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +++++++++++++++++++++-
> 1 file changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 58120829fb06..316371c8ee6e 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -19,6 +19,9 @@ properties:
> - qcom,sm8550-adsp-pas
> - qcom,sm8550-cdsp-pas
> - qcom,sm8550-mpss-pas
> + - qcom,sm8650-adsp-pas
> + - qcom,sm8650-cdsp-pas
> + - qcom,sm8650-mpss-pas
>
> reg:
> maxItems: 1
> @@ -49,6 +52,7 @@ properties:
> - description: Memory region for main Firmware authentication
> - description: Memory region for Devicetree Firmware authentication
> - description: DSM Memory region
> + - description: DSM Memory region 2
>
> required:
> - compatible
> @@ -63,6 +67,7 @@ allOf:
> enum:
> - qcom,sm8550-adsp-pas
> - qcom,sm8550-cdsp-pas
> + - qcom,sm8650-adsp-pas
> then:
> properties:
> interrupts:
> @@ -71,7 +76,25 @@ allOf:
> maxItems: 5
> memory-region:
> maxItems: 2
> - else:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,sm8650-cdsp-pas
> + then:
> + properties:
> + interrupts:
> + minItems: 5
maxItems
> + interrupt-names:
> + minItems: 5
maxItems
> + memory-region:
> + minItems: 3
maxItems: 3
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,sm8550-mpss-pas
> + then:
> properties:
> interrupts:
> minItems: 6
> @@ -79,12 +102,26 @@ allOf:
> minItems: 6
> memory-region:
> minItems: 3
You need to add here maxItems.
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,sm8650-mpss-pas
> + then:
I am not sure if keeping it in the same binding as sm8550 avoids that
much duplication.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-27 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:35 [PATCH 0/3] remoteproc: qcom: Introduce DSP support for SM8650 Neil Armstrong
2023-10-25 7:35 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS Neil Armstrong
2023-10-27 7:36 ` Krzysztof Kozlowski [this message]
2023-10-30 8:29 ` Neil Armstrong
2023-10-30 9:31 ` Krzysztof Kozlowski
2023-10-25 7:35 ` [PATCH 2/3] remoteproc: qcom: pas: make region assign more generic Neil Armstrong
2023-10-25 7:35 ` [PATCH 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support Neil Armstrong
2023-10-25 8:51 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1895327-b520-4f3a-a427-0947ac46495c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®