From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: yu kuai <yukuai3@huawei.com>
Cc: benh@kernel.crashing.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH 3/4] video: fbdev: remove set but not used variable 'vSyncPol'
Date: Mon, 2 Mar 2020 16:42:25 +0100 [thread overview]
Message-ID: <a18c91bf-2517-00d5-3943-0e01a12346f0@samsung.com> (raw)
In-Reply-To: <20200119121730.10701-4-yukuai3@huawei.com>
On 1/19/20 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/aty/radeon_base.c: In function
> ‘radeonfb_set_par’:
> drivers/video/fbdev/aty/radeon_base.c:1653:48: warning: variable
> ‘cSync’ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/aty/radeon_base.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index 0666f848bf70..7d2ee889ffcd 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info)
> struct fb_var_screeninfo *mode = &info->var;
> struct radeon_regs *newmode;
> int hTotal, vTotal, hSyncStart, hSyncEnd,
> - vSyncStart, vSyncEnd, cSync;
> + vSyncStart, vSyncEnd;
> u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5};
> u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5};
> u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock;
> @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info)
> else if (vsync_wid > 0x1f) /* max */
> vsync_wid = 0x1f;
>
> - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0;
> -
> format = radeon_get_dstbpp(depth);
> bytpp = mode->bits_per_pixel >> 3;
>
next prev parent reply other threads:[~2020-03-02 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:17 [PATCH 0/4] cleanup patches for unused variables yu kuai
2020-01-19 12:17 ` [PATCH 1/4] video: fbdev: remove set but not used variable 'hSyncPol' yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-01-19 12:17 ` [PATCH 2/4] video: fbdev: remove set but not used variable 'vSyncPol' yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-01-19 12:17 ` [PATCH 3/4] " yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz [this message]
2020-01-19 12:17 ` [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp' yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18c91bf-2517-00d5-3943-0e01a12346f0@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®