From: Shawn Lin <shawn.lin@rock-chips.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: shawn.lin@rock-chips.com, martin.petersen@oracle.com,
heiko@sntech.de, linux-scsi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion
Date: Wed, 26 Feb 2025 14:49:42 +0800 [thread overview]
Message-ID: <a18fb035-3e7f-443a-8b24-9a51cba5604a@rock-chips.com> (raw)
In-Reply-To: <20250226021157.77934-1-jiapeng.chong@linux.alibaba.com>
在 2025/2/26 10:11, Jiapeng Chong 写道:
> ./drivers/ufs/host/ufs-rockchip.c:268:70-75: WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19055
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
Thanks Jiapeng.
> ---
> drivers/ufs/host/ufs-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
> index 5b0ea9820767..350cb0f8d0c2 100644
> --- a/drivers/ufs/host/ufs-rockchip.c
> +++ b/drivers/ufs/host/ufs-rockchip.c
> @@ -265,7 +265,7 @@ static int ufs_rockchip_runtime_suspend(struct device *dev)
> clk_disable_unprepare(host->ref_out_clk);
>
> /* Do not power down the genpd if rpm_lvl is less than level 5 */
> - dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5 ? true : false);
> + dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5);
>
> return ufshcd_runtime_suspend(dev);
> }
next prev parent reply other threads:[~2025-02-26 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 2:11 Jiapeng Chong
2025-02-26 6:49 ` Shawn Lin [this message]
2025-03-04 2:26 ` Martin K. Petersen
2025-03-11 1:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18fb035-3e7f-443a-8b24-9a51cba5604a@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abaci@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®