Re: [PATCH v4] ppc/fadump: collect dump when CPU_STATE_DATA is less than reserved

[Shivang Upadhyay <shivangu@linux.ibm.com>]

On Thu, 2026-09-24 at 15:06 +0530, Mukesh Kumar Chaurasiya wrote:
> > +			 */
> > +			if (!(bytes_dumped == source_len ||
> > +			(type == RTAS_FADUMP_CPU_STATE_DATA &&
> > bytes_dumped <= source_len))) {
> > +
> Extra line here.
I'll fix this in next revision.

> >   				pr_err("Dump taken by platform is
> > incomplete (%d)\n", i);
> > +				pr_debug("type -> %d, bytes_dumped
> > -> %llx, source_len -> %llx\n",
> > +					 type, bytes_dumped,
> > source_len);
> >   				rc = -EINVAL;
> >   			}
> Can bytes_dumped be greater than source_len? 
> If yes then the error is misinformed that it's incomplete instead
> it's corrupted.
> If No then shouldn't the internal check bytes_dumped <= source_len
> should handle it?
> 
Yes, It can be more. The wording on error here can be better. I should
change that in next revision.

Thanks for your review.

~Shivang.
>