From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01A9320CCE7 for ; Thu, 23 Jan 2025 09:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737624967; cv=none; b=iNg9SNAoT9c7ZfsBZg7vY2nZYbDfvZKVF/DEnz0i87MxY/M1i0Puke0EuottOOrwkummEoLwitNCe/2saij8evjdtayEu1XQVInYmsPxOHmFE3dmISxtlAMVCnGSc5t0LTtQBsqp1wNzdHnJhdmIY/LlkE/J2zRdccu5fkz4coI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737624967; c=relaxed/simple; bh=dqawR7XNzIGe0xKiLtAeHwJKbpEBmKW8gR9cV5OZiSA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AJAnnx4H+9lJJW5deM5KPX7MN64zzbsFjdhI97e/eaql1xin7Irpqj1nEdqNF/PJxNdfYmu2iIHNSy+XZ5hdwzYJls5Wm2qO9bnHFytLAbhSl8K+EDi6i1DtkfLQIXE8xYFLlSbK1rt2K2qtPDiTm1E7zBN2o3nxqXDEOCDddcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BUirntqp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BUirntqp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737624964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UnYFcRPw5BnzfejUEGROZP2MFra+jRL2jq0Ys6OTnCE=; b=BUirntqpD0R/lQZrLMX5tL2SOhGgPxv+QghbjcxF1IBs5+dJNEKYSKTJxKWfo3tJbSAv9N 6VlyqWn5Jdrz1esmPrSMuShuSw+PR7KRyRydudiUvD7BUNeq644sizQ8aDzxsne5g3AQZh IshImgjUg2j3eghhiZA5e9+JI0vsviU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-pQ91FWc2MtOfxjKjTanfaA-1; Thu, 23 Jan 2025 04:36:01 -0500 X-MC-Unique: pQ91FWc2MtOfxjKjTanfaA-1 X-Mimecast-MFC-AGG-ID: pQ91FWc2MtOfxjKjTanfaA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43624b08181so3620595e9.0 for ; Thu, 23 Jan 2025 01:36:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737624960; x=1738229760; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UnYFcRPw5BnzfejUEGROZP2MFra+jRL2jq0Ys6OTnCE=; b=K7tBAc6j9XrS50W2JM0Tm4zDQ4jJwBR7wUHvplDV/411+UyRzn6zKleCkrgxq5VtIM CNBgD2Qf4vzI+lyL6WzCDzphme5YFfDuWkFPa6O7n74qjaxAAea8QZaqqfYx1c5nHXOy fso61vk1Be6fCa/01CRIxa/u+guEvE4o625A260OrzpvWKhJUDlggDmPepJSgKa/nNbo YGdd1my0kwp9S6/NtRVTCDoiCiduVOR7d0XDINfHcB3BrtIuwhNVKPYVTw7U6MqEcNgK drcnQ6euIIKY/9n+HFOUfneEwN0ITc2I76vqir+MW859FGWDifQ+pfPFPgOJwk/ldA3C rDaQ== X-Forwarded-Encrypted: i=1; AJvYcCWPJOW6u1abvKLvrshJGqS1GLQvAfO8uq7koaYMNU/1TYCkA+6PmnFoeb/mgaKP7rRhahgFhs9iFC435RY=@vger.kernel.org X-Gm-Message-State: AOJu0YztcNt7k0BNy/TtGUme0TfB2w2W5JHTs1Yf/4d7TJPsmvlG7CN/ 85qk96yF37ZZigeCmFlCEnwSpct4jFWB2uSXySwuxD9JVAjG4Szog+KfTH9y0LF5G/Cua7VhVVN uzKeEWAevQCMmD5LQFRvYZZ80uZBgRL1kjn/uglRdQXN/lTMxyGnU5nizaePJEA== X-Gm-Gg: ASbGnctisMbiRaRWWLtgpPffJwL2MOqwdVXn6jzKmq7Wu6vHzf/DICcZhb7BP+4Vj1/ PyVYjY+iPktaYonTdXKoDhhCWV1WPIDlMdBOIsMf4h5oFa68xCy+UbXFdDTyC0ThoAP3bMflQ5Y 8Vd3VrS/+GSWbTq8njipGxyK1Nel92J/rnmPL5MeN1PfKnoPpwN9hRpHPobS+nivazKLs9mCeeV zURoIRIxnUJKu2LRr0Ctk7C4qTLoZKoVjLXfDUz7i9b+Fec4zfu6sB/P5G7KptNNYn0hOWhg9EO FPMOtDymLw2UX81N6etjQSNP X-Received: by 2002:a05:600c:1d0c:b0:434:f9ad:7222 with SMTP id 5b1f17b1804b1-438b885652fmr22198765e9.7.1737624960114; Thu, 23 Jan 2025 01:36:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEioYh+fOt8E8oEIKF32FkxJEk+epzAyprXFxCf2o/rfVP//pqtUxaTni9qOyL9m9HdyOe9YA== X-Received: by 2002:a05:600c:1d0c:b0:434:f9ad:7222 with SMTP id 5b1f17b1804b1-438b885652fmr22198425e9.7.1737624959693; Thu, 23 Jan 2025 01:35:59 -0800 (PST) Received: from [192.168.88.253] (146-241-15-169.dyn.eolo.it. [146.241.15.169]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b31a0f47sm54375985e9.15.2025.01.23.01.35.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 01:35:59 -0800 (PST) Message-ID: Date: Thu, 23 Jan 2025 10:35:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] ipv4: ip_gre: Fix set but not used warning in ipgre_err() if IPv4-only To: Geert Uytterhoeven , "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Simon Horman , Kuniyuki Iwashima Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot References: <67956320a8ee663f2582cc75f0e8047d69da5f6a.1737371364.git.geert@linux-m68k.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <67956320a8ee663f2582cc75f0e8047d69da5f6a.1737371364.git.geert@linux-m68k.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/20/25 2:12 PM, Geert Uytterhoeven wrote: > if CONFIG_NET_IPGRE is enabled, but CONFIG_IPV6 is disabled: > > net/ipv4/ip_gre.c: In function ‘ipgre_err’: > net/ipv4/ip_gre.c:144:22: error: variable ‘data_len’ set but not used [-Werror=unused-but-set-variable] > 144 | unsigned int data_len = 0; > | ^~~~~~~~ > > Fix this by moving all data_len processing inside the IPV6-only section > that uses its result. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202501121007.2GofXmh5-lkp@intel.com/ > Signed-off-by: Geert Uytterhoeven ## Form letter - net-next-closed The merge window for v6.14 has begun. Therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after Feb 3rd. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle --- Note: this is possibly somewhat borderline, but I prefer to avoid exceptions unless there is something really ... exceptional ;) /P