From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576A938B for ; Fri, 30 May 2025 08:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748592422; cv=none; b=I4WYhqFL8fCrOEvzPmm5t3GcnCCbpjKVteUAnmlw2kjUcQ+tRhLQacGONvBTm/Du0ObBjoCCsSV+KGW22p3GmceoRgj4uPcjEZIlA2pr+GjTEHVpBMqJkoVN8niWU3f18ZIxkXNVNo4c/0fyviFxisf1f9xog1AzXf9Mw/sfQjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748592422; c=relaxed/simple; bh=1MCaFvumFxkZrMchTN7K2ItI5FI8429EhqZG3F27pFs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E2T2GkHVXWjjQZvja2yE2poipYNWNPqy1nCcM1BeJpHzyV4XB1ImLTu1Bd+tKK3WyjbUCk9LCYdP9qTekf1vnVcbC3IcmX/Lc5bL2fluFyTod1dmksk0GvBwLH75tFwl8GGTlbkoFpoRSYm2GWdRZ1GzFz1E4e1UzzV2k3cVa5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b/FLCOQm; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b/FLCOQm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748592420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6Dzf/b6l9QGCtMTCvICyRITM8gExIaAXao9oUV4gRsA=; b=b/FLCOQmyO6YaAyO57zd3kMrnWVfPfLjewa2KHIKGTzqqIRCkaRK2Y/md9vMetBLhzzjxx veSPpTK+rurYBxw+7aZfAJHEdCQhzzVcbRsvjckkGLItWlQOAA5A192+i97tvyfGWXWIKm Pe6BsYyPzlY8wDH2LBEcQBfWci8rAu0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-GuSWWQmbP7WD8pwGbSJUQA-1; Fri, 30 May 2025 04:06:58 -0400 X-MC-Unique: GuSWWQmbP7WD8pwGbSJUQA-1 X-Mimecast-MFC-AGG-ID: GuSWWQmbP7WD8pwGbSJUQA_1748592417 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f3796779so899040f8f.1 for ; Fri, 30 May 2025 01:06:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748592414; x=1749197214; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6Dzf/b6l9QGCtMTCvICyRITM8gExIaAXao9oUV4gRsA=; b=eXqB0Hp8oQLtezM0J/jRj2ChrgaeMYuxB9EA7wUTsv5zZHvmfVg/hrSUAdFOYEL8Kz 3DvkDla6URlx9aciiu2e3ac7qTAp9FhLkrm7ckg883a2SQjC5tyju4jfIbdnGK2P22Xx 9dk1aKD12z4AsEVLCkuGHR2Ai76lX5kccfJeaJuZGCgTLzSdDhEdy0MMB2SWqjc1A12B AsDqxRZ3VMqsJVNcM4YeP5oiqj3FJ7QJ9cqk2MecxtdxoOep/CqGK0ZsMbT1a6qZQ3lT nwB7FWjHgRKy8cVJgNgTshHeOZd4yLAW+IL2xE7janCM8g28Dzvs1QwVy+kxFTg8wsMf v/iQ== X-Forwarded-Encrypted: i=1; AJvYcCXxie5cQJ+Q6Jli00TJ0Ug/Rz3PQItCK2eToC/HvmonAYb+cD2HNwA9r7wqXu7EE5mEKo2/R0w16WBFaf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhwsbm+9jGTX4Gl6qTKjpo2tWol1zCPVk1Nq2t5L+lrJLYgFrP q3stM92pz1G+en4P3zXcOAKQQF0+SVY15ZAFPIYQDr9wg89oqAXXbd78Op5CsNKeF/d9Gvfi3+Z dGdOF3HE6MZrnySUvicFNOAqcrqrbYeHlFyKzEG2EmhMOZaBvlJlrR8QP8eh/GSpUmw== X-Gm-Gg: ASbGncuax2N8Oa+VlO9i7wG99VKlT0WfzmjOjco64cZWauI+4IPFs3ZavZgVfNaiO51 z++oUDeDMAYXakFtz0MoADcjSst7xOdIVfnXcoEAvXYXvPIE57sXH7LUfrP482Jlux2zrKog6/B R9i0fx4AlTR+VZ5NeHQQZNMiJ+v8Dv2mHBglVEgysJaVHLQY/XKC5FuvQEhqpYzeHoehvHEgdA9 rJ0tLWP9FNlqxpKhq9mVkw08Vv0ob9r53In8SlGO0rr9s5Q6g0PWwXe5hcdGIg8k8pHWuS8uUFH TkdiaJpYmwQmqu/mcinuSAuD3zcgQPosGvL7CAnGotTxAumyc41wtugewD4bYGLPtDS2JQOXykW V6dACAIHfF3XELnQSKi9ozpfYBbhktL7X8/nDGlE= X-Received: by 2002:a5d:4e84:0:b0:3a4:f7e6:2b29 with SMTP id ffacd0b85a97d-3a4f7e62b33mr1233186f8f.5.1748592414505; Fri, 30 May 2025 01:06:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFitKTov933TL6/U7IMqJv7qvimg/JjiUTLT8m5lvXzWlGBTnGMyap/xgTwc/uDHj8b7FUqpQ== X-Received: by 2002:a5d:4e84:0:b0:3a4:f7e6:2b29 with SMTP id ffacd0b85a97d-3a4f7e62b33mr1233158f8f.5.1748592414107; Fri, 30 May 2025 01:06:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe2b35dsm4136917f8f.0.2025.05.30.01.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 01:06:53 -0700 (PDT) Message-ID: Date: Fri, 30 May 2025 10:06:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] kdump: crashkernel reservation from CMA To: Michal Hocko Cc: Baoquan He , Donald Dutile , Jiri Bohac , Vivek Goyal , Dave Young , kexec@lists.infradead.org, Philipp Rudo , Pingfan Liu , Tao Liu , linux-kernel@vger.kernel.org, David Hildenbrand References: <04904e86-5b5f-4aa1-a120-428dac119189@redhat.com> <427fec88-2a74-471e-aeb6-a108ca8c4336@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29.05.25 09:46, Michal Hocko wrote: > On Wed 28-05-25 23:01:04, David Hildenbrand wrote: > [...] >> I think we just have to be careful to document it properly -- especially the >> shortcomings and that this feature might become a problem in the future. >> Movable user-space page tables getting placed on CMA memory would probably >> not be a problem if we don't care about ... user-space data either way. > > I think makedumpfile could refuse to capture a dump if userspace memory > is requested to enforce this. Yeah, it will be tricky once we support placing other memory on CMA regions. E.g., there was the discussion of making some slab allocations movable. But probably, in such a configuration, we would later simply refuse to active CMA kdump. > >> The whole "Direct I/O takes max 1s" part is a bit shaky. Maybe it could be >> configurable how long to wait? 10s is certainly "safer". > > Quite honestly we will never know and rather than making this > configurable I would go with reasonably large. Couple of seconds > certainly do not matter for the kdump situations but I would go as far > as minutes. I recall that somebody raised that kdump downtime might be problematic (might affect service downtime?). So I would just add a kconfig option with a default of 10s. But even better if we can avoid the kconfig and just make it 10s for all setups. I would not suggest having a different (runtime/boottime) way of configuring this. -- Cheers, David / dhildenb