From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 740C51BEF84 for ; Thu, 30 Jan 2025 18:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738263457; cv=none; b=FdTT1np++1rzEErAljVFl6xwV2n/XLFp9UmtVlkpQlK7titVlgdw1/6AzRhvQANXKM0tSt4cyIJwL6+POcn0fKOk/J0/PN40JEJqorqmD69tpQ0xz/1uP0eaZ5w3vNb+g1itgl8y5LvtucnCOu8hMyb2hNIbUWrhDE4FHCQuljM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738263457; c=relaxed/simple; bh=xKVjO+DBLQqR9NnXt8CftOf626OcccVGBG288Hk/e9Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FtmtB4iJLVK5rh9X698zSsjmDOvAMhqq6bwckYH81HwUNJlZCpXwErgsb70+eukXCeDv87cDg1TUuBcEOBfTc0LSQwYJChLeIBwRZqNduRxVoGkAhcIwxldotu1Uxht1mIl/AAwZm4S/KeUC0XcRDyAOUDwSXW21DKBH9PoVmL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U9VipNld; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U9VipNld" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50UHqkSF011885 for ; Thu, 30 Jan 2025 18:57:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fiMHQ0z1wbr+JNPD50hh7kKgwucGaVyznKp+iYzAJgg=; b=U9VipNldWNJDJI8J MPZ6NKYfl4iCuugmpyGCTkTTYYgMnfypTigcgfg66658Oli5XMS/Ve7aB6c7CjPX l38GUHVEk4kPA0Ubsd3oWeOoXI/F7u0lfg+4ZJ9f8xtBYelC1g65w2MCvA/EdCzW SqANtiNzd1KpqG1unPMk6NH3zZpxWzaLsdftDJn3YAhBf9WU9FfJx34+rLvKHcoG 4xHgHW7/dksEh58Xrpgkmmy+whg+ndILgv692f2OxpBQffjOHQJHuw+NN2QwB1Wc h+DThgqzrecBt9hxeKJaST59iVyWmiMU+aCJTgDmd8qyio+qkv65r+hMMY83BoYY I89DjA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44ge6b05hb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 30 Jan 2025 18:57:34 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2f816a85facso2192353a91.3 for ; Thu, 30 Jan 2025 10:57:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738263453; x=1738868253; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fiMHQ0z1wbr+JNPD50hh7kKgwucGaVyznKp+iYzAJgg=; b=JKVGgiiSahWqwt9CLDqrA2a4oRPbCmHeoLuWCdXSl/86aTiL9ibzWgIsP69QwXrof6 e3YNAn8AauM2VDqPLkKYCvCKK05orEyjz3owlaCAadViXQ4J0ewWO4ZbEqp/GQbJ/gxy 7QrETkJ3+DKGEkymQ2RofSC59gs3HUR/4HX7h/w0PWcnDpBT5SRYSagMxSqvNO01dAzq fff1aAqzCj4lXhs9R64UjHok8tfjA8sPtFpM9vtjG8UuL1oGFHOdAjWDR7eX8wJffj/m eNvS6R+JLDR0jcFEM1ktqZsNibzfyAETJN1p3yB7pKgb9PAl0QL0RGE5zJk06WpvcxtX Ipew== X-Forwarded-Encrypted: i=1; AJvYcCW104KIiHxfzdJuouJNXUhI4dxmBdxtOnAiSFmfExrw10G1KZEEG2kjmx4sOo7HotGFy3CfE7RPZ8ZHCyE=@vger.kernel.org X-Gm-Message-State: AOJu0YyeUdAIJhDLpHvMNOXaYaTUSmJ0HQEUCXA45+DSpQMzAL2pgNNJ vJVI4XtKcsA2u4O80RErrB5U1G4FyLHicRkXJV/XacwfZ58HvendnBApVTd73RXjv0SHIvmghad CedwU6MVCO5427AVU9hXPnNzjlwu0yL/lSSfgZGyOFoIZ49fM3XQgWqvnIwnTVI0= X-Gm-Gg: ASbGncu/yIwhA4KzMhxKVMPSbo1EosZXG3Ay8DXpEVPG/P14qUlERasboQolnOreIM1 Sl41a3PH56t1sYhUDeaYxJBUa6OIQaVcz97cy2/QpsuBxGsWl18x9CFUw5aptmX6nblM6As6QbE mYDq34LQDY8AQY0WVqoWkur+Pe5bd1JoHj65IZgqsScb0GAj8k1Sq40+ungLGVfTzybMyUJM33t 260Lz7qWZgMcvM+98vTi92SDjfvXOFXUAL1AePHdsiwzQ6PW2h6bR3+VvJ6YeBPW7Ro4QTm5aMB 3hw7/X0hiA5PGUzA8M+UKfKHn2l2jQHUV5Z7ZMDwixCBmk3yPnq5Ou/FzpG5tZC8x0+FqxW6Fw= = X-Received: by 2002:a17:90b:53c8:b0:2ee:c04a:4281 with SMTP id 98e67ed59e1d1-2f83abb3525mr11527658a91.6.1738263452797; Thu, 30 Jan 2025 10:57:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IG273BYwPCYJOD7Mxuz4ETYiF2JHgiTLRjcgdzwlh75QgkyHtg29AyuhDibvbFwEv67cIBh4w== X-Received: by 2002:a17:90b:53c8:b0:2ee:c04a:4281 with SMTP id 98e67ed59e1d1-2f83abb3525mr11527636a91.6.1738263452421; Thu, 30 Jan 2025 10:57:32 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f8489d450fsm2036646a91.28.2025.01.30.10.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 10:57:32 -0800 (PST) Message-ID: Date: Thu, 30 Jan 2025 10:57:30 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] wifi: ath12k: remove return for empty tx bitrate in mac_op_sta_statistics To: Aditya Kumar Singh , Remi Pommarel Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Kalle Valo , Jeff Johnson References: <38c2a7c4f7eaf57b9306bb95a9e6c42b7d987e05.1738169458.git.repk@triplefau.lt> <9c12e9b9-35a4-47f1-bd17-6b4641de92a4@oss.qualcomm.com> <94db4020-b1c7-4aee-b22c-6fe6d357e593@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <94db4020-b1c7-4aee-b22c-6fe6d357e593@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: X7noT4b8K6Ud1K_ZF9jELW_8feRVt_yx X-Proofpoint-ORIG-GUID: X7noT4b8K6Ud1K_ZF9jELW_8feRVt_yx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-30_08,2025-01-30_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 mlxlogscore=813 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501300144 On 1/30/2025 1:18 AM, Aditya Kumar Singh wrote: > On 1/30/25 14:19, Remi Pommarel wrote: >> On Thu, Jan 30, 2025 at 12:21:54PM +0530, Aditya Kumar Singh wrote: >>> On 1/29/25 22:25, Remi Pommarel wrote: >>>> Currently in ath12k_mac_op_sta_statistics() there is the following >>>> logic: >>>> >>>> if (!arsta->txrate.legacy && !arsta->txrate.nss) >>>> return; >>>> >>>> Because ath12k_sta_statistics is used to report many info to iw wlan0 link, >>>> if it return for empty legacy and nss of arsta->txrate, then the other >>>> stats after it will not be set. >>>> >>>> To address this issue remove the return and instead invert the logic to set >>>> the txrate logic if (arsta->txrate.legacy || arsta->txrate.nss). >>>> >>>> The same was done also in both ath10k with commit 1cd6ba8ae33e ("ath10k: >>>> remove return for NL80211_STA_INFO_TX_BITRATE") and ath11k as well with >>>> commit 1d795645e1ee ("ath11k: remove return for empty tx bitrate in >>>> mac_op_sta_statistics"). >>>> >>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 >>> >>> MISSING_BLANK_LINE >>> 'Tested-on:' tag missing blank line after it. >>> >>> You missed v1 comment? :) >> >> Yes sorry I think your mail never reached me, did you CC me ? Do you >> need a respin ? >> > > No problem. No need of respin just because of this. I think Jeff can fix > in pending? > > It's strange that the v1 reply appears to be delivered from my mail box > and it is sent to the list. I see even Jeff replying to that. But none > of those are captured in patchwork. Not sure. it was only sent to the ath12k list perhaps you need to include linux-wireless@vger.kernel.org > > Anyways, v1 comment was regarding this blank line and one suggestion > that in future submissions, please use base commit tag. > I've fixed the blank line in pending: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=c7b9df20d6a48a279f4b537920049094701da14b