From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933211AbdBPTma (ORCPT ); Thu, 16 Feb 2017 14:42:30 -0500 Received: from mail-by2nam01on0054.outbound.protection.outlook.com ([104.47.34.54]:38724 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932694AbdBPTmZ (ORCPT ); Thu, 16 Feb 2017 14:42:25 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [RFC PATCH v4 03/28] x86: Add the Secure Memory Encryption CPU feature To: Borislav Petkov References: <20170216154158.19244.66630.stgit@tlendack-t1.amdoffice.net> <20170216154236.19244.7580.stgit@tlendack-t1.amdoffice.net> <20170216181355.bjxo2h6vlhukz4ih@pd.tnic> CC: , , , , , , , , , Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Brijesh Singh , Ingo Molnar , Alexander Potapenko , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Thomas Gleixner , Larry Woodman , Dmitry Vyukov From: Tom Lendacky Message-ID: Date: Thu, 16 Feb 2017 13:42:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170216181355.bjxo2h6vlhukz4ih@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR17CA0025.namprd17.prod.outlook.com (10.173.128.139) To DM5PR12MB1146.namprd12.prod.outlook.com (10.168.236.141) X-MS-Office365-Filtering-Correlation-Id: aa20bb67-308a-4510-9877-08d456a3ec32 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DM5PR12MB1146; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;3:qNjw1gmlIj4Yo7CKodbZ2h5JvFVfqXERGJUX9k8NgbvxEe7Mp6/dKeX32QXt9K5TDblrvY5LKLCOfo38n3qWzJLdpyohVXaoKfyznPt5evi+TyU4ckHgVk0l3fOXR1c2uB9rgu4lVPMn6SQrEfD3BviArqj0Y0zvzottkqJLqqu3UBPATwFY3C1PCMjJIAskNHYw7vE3/ZoUsCZLXDyXpVfvovYNBdrGPCROKM/kcntJgV+cD8K4jwdh8djirL6cBBRkA1LKFW9yVRO0WJwn7aOOxzvA0HB9zVxblH8xzVs=;25:6nzcFnX4fOz7cNxNutrukpAX3SzNRhTGouqlXnZdfsVMzHelOz+icaLuo7Mb20r2sMk71qLUlSviZ7KDWjQfYrNUTDKRMJspXNK4IgW5Z6Iy6by5AGajTJmvQVF42TegV55eaTiNzE5CdFojCKe1KZeZuIkJL07U4keZLQIE4/Gt+ZJY0ggrOiSYab9ep924dZxrq5K52ibyuySQD6TyDI5xDGLgVC8TKMUbMjeTKL8uv5vQYVaM4jvhsSfeg+QwyF87C/fl9WtUmZ3zK2aY1LA5/6rmEQ8A9H2QnB/36ufeEoZSESGfbjpbLlnEUmUZbx2Ke64aeqGnBTnLbndyFq9VHvyNgxPIRJTXYeFkD1fg7xuB2qM6/xCnS0QLlH5t5jpM3Dju9Qs6AN0N3rHfB+Y8R0/xVxwIX7i14BhZ+C+B7bib9Ilcq4KDR7y2d9T7Gq3BTdbYvfyvx2W1evstwQ== X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;31:8vmx0EqoOv3shha96h/yEu8hFCb5rtUprOYp0CmWC476Aw9QwVeoIB+643bm+4bHut3m0XsavvEoMTgWb/6neQ0pJ/5YGiViMJi/C5xDJIMuWOmrZ5hZkxRSjt4JUHFwbvn9XWc1C/RsSif6FK8/Yfwzhyfa2fri1tQsyAYAYWsVsQP5eqoJlLAF5UTXN+qSow5NdGTobs+idxfYiC/N+zxcdlBsdwUjINix0PW7PyiObEgA9NoiC4qmDwMT91zY;20:Shnede1VAJttMOR+XABm/H3b8vw6bjF2NfrpX1QyDV3U2apN/6CU4TkfSO9h8KIrQNfdkACX7r1L6JHpO9XPlDx+kyJ9Vc0c+uNh9UdF8+teRMDf6uB/Rql52GgFAaSJcyKuwg/Y8cS6QL0pw7Z1wh9xADzqDHZBTRvKt10Vl4i3ZLkmpUfCfhU4VHajPLNHE+CIjXov/sjWWZ1TtG0+TZSo41acETc7Xj4oxfZwGxr9e1LkqNd8/FGa0vCDvFO5JnCcox5TsK2H33x5e3PV5hV2c36qw6Q99vDwQTeETg18TM8eYUzYCc9NUWwRDqNc6nIj2e5AHa8sH9oOkSG/D4iLFxEfud1kTTUHbbZcJzxeDPQUd5ht9DOTUYRC70ndlHcUCRo8vKRDIQkQ1+pIvyp/G61T0hQeRmL/35dDb83Fryupii22AIcj19IoWj+u4K2uxGeey58ZxJ1Lhr4gzl0ateUJefLqdWi+vbe7ms5hwheQrdTfnFgYOWiR1Qvi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(42068640409301)(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558025)(6072148);SRVR:DM5PR12MB1146;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1146; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;4:x1NaGXNWkbNKnzrtmX00mKwTl3rmKj4Cfc3+JVUfjq+HfHrYcdLNd7QrezmYPBEVlEv9WivIoSsfjb6VFfcNSDJ8nO4B+zj4aUE53K4VpfwVMS2XNVi/YEuXBSDh/uJzUIJc1tW6xvYSqsJsliE2zaQ6DjW9D0d7Cb7exVEIcNTXiO5xKZyFEYkeM3DU/qS1f33AV4ARndRJ7X1FPpCfIXM1ivKZlUH1kxtBslccLe+oGRkFg6ZxDVySFt82wlASLUEFOzd1I5cq25msuoI0BuB2edqc+7eUxIJ85hKjPIlsy5GRIIlbAg9tqRlvtPZ+oyDUncGMcKQJUypCu7OxnK6MInRmSFOrzH4TkAGWlbGpvomN+Y+JMer0OcJvHTRKlRRHoFd6CJozJlyiVTr5Nq/aPHDNgdIHmRNvptTwOg0PIWVOC/ZpPEQlIz8dWcsRLkO8Uh9J7K9ie7byG8ho+nFGao56F+fX1D/mVVfHYMhtPzOxn+j0T5aEyh97ZdpWyjjfHg8V/qNNH2iD8UpreXHsPsab24QZEpNWIF6zT0sE/ZQn9naDxExTQhJvzDw8+943tBxL3/pvhGLCoszlUWRhdxAPKA6U9ungcmOPyiwkpwVz5/CBajjHNdi+GzzTAZ0EWxftuvwjVchIzBF6lsMcJRaLDGcKl0QXODPR+fHOYx9x4zVdePjyr+AkZH4Bomn8UqyPqDSVWedKCdUh5Zm9KE2vcbzfp6UVmNHhin4= X-Forefront-PRVS: 0220D4B98D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39860400002)(39450400003)(39840400002)(39850400002)(39410400002)(24454002)(377454003)(189002)(199003)(77096006)(36756003)(31686004)(6916009)(2906002)(101416001)(76176999)(50986999)(47776003)(54356999)(6116002)(3846002)(6486002)(92566002)(6306002)(33646002)(389900003)(2950100002)(53546006)(229853002)(54906002)(4326007)(53936002)(5660300001)(25786008)(90366009)(68736007)(305945005)(230700001)(6666003)(7736002)(81166006)(81156014)(4001350100001)(31696002)(106356001)(83506001)(65956001)(66066001)(65806001)(97736004)(38730400002)(5890100001)(110136004)(105586002)(189998001)(6246003)(8676002)(64126003)(7416002)(86362001)(23676002)(65826007)(50466002)(42186005)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1146;H:[10.236.18.82];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ2OzIzOjJycUFBVkprcjRHTk9nZmY1TytCZ25zM2Ni?= =?utf-8?B?SVR3aWpqcHlhTTE0QWx4RFNxVGtndXQ2a21JZjhDT21rYWt1MUY3dmsvOGo0?= =?utf-8?B?bU5RbHlDOUhuMjhXblR2MnBYdEZOVHlHWk9EaHpMbkd3U0RPSzR5K0NmZnQ5?= =?utf-8?B?YXVodVdBang4VGVld2REOTJ0ek8yZjNmeEZaclYzNGpsMkFxNzN4bkxMTmhB?= =?utf-8?B?QnZlSVdtNDNUMWgvcTVvYXYvM0N1TzJNSlBwQ2ovaVlqOUMrdE1FbWpMR0Iy?= =?utf-8?B?MExGZ2hmZDZBQ2NjUTJNT1Rtbks1bzFsWUVVb0k2YjlOK0dqd3JYYWtaRUh5?= =?utf-8?B?Wk9CZWZBcFNBQWMwUnhDMHhlU0g4NWVmd0VwRUc1NGVJYy95TTVJSnJqSFNX?= =?utf-8?B?WHV2T3lkMFhxWUFKVVBwZ1JUd2Z5UVJHd05nOTR0SE1iN3ZuOG9nTnNsVmNZ?= =?utf-8?B?N0ptUEh4aG5EOUdiVWt4YVV5UVNQaUVLb1d4Y1NsTFduMmUyRXcxQXhQdFVs?= =?utf-8?B?UC9mR0hiWnBlbGVBVXlKbkh5M2RJNXg4cGZyNmY2bXQzeGpRQWJ5M2pKUmdI?= =?utf-8?B?bUczRTVoYkQ5NHdJUWpyQmN0cjZRcFNmeERhWDZkMlJhVkxVS3prUmF6ZnBj?= =?utf-8?B?bjN2b2pJd1RhYWxCOWFMWGlxR1g0WkFiT1poZEFwUjdQQit0bEltZTZBV0hH?= =?utf-8?B?SjBJS1p0cUZFUlFtQ2tJUGVYcGkrTjFsRWdVUm41Q01SSHZDR2hHRDBvVDdV?= =?utf-8?B?dktGMnRqeUlpNmFnSlFGL3RNcmRabkY4REdMNW1sWnZJRk90aWZCQy9OU3Y5?= =?utf-8?B?NmkvdHZVRk0rcFFlcnVtMy9BamlJTzV1YTdDcGFVWXZ4SXNXNFVad0N0ak1i?= =?utf-8?B?R2pMWkk4Y2wyZmdOR2JtS0xoMUNkbHJ1MXhqL0RNZlNFTzZTNHNKeUZMSjFP?= =?utf-8?B?ZE42MlkzVFhOcTJ6SVpoTGZzYm05NUtMaFhkVWdJcU4veDRxTmp3dDcwcThM?= =?utf-8?B?THA5N092UEg1WHNWV2dEZ3NNSTVoR2tDN09XVW9RRWJwQWV3UGJFQWM3S1VQ?= =?utf-8?B?aWt5dnhuS0ZIRnQ3RkZhNnptdGY2NVV3NmxZQTQ2YmhLbU1YcEp2TUtoL05o?= =?utf-8?B?WlJnZ05Sa08yWWVvM0RiSmU2M1F3U0ljZTRCYkgrM0F6QWNTNzBGSGhNbVNz?= =?utf-8?B?VDl3LzZRcnVNUlRCSzdTOFpMVm9ST2R1NHY3Qm41VTF4Zk5aaURBZHlySzE2?= =?utf-8?B?MVNybkpJa0tuTENzSmJnQ0grVVpRMnN5MmFhSHo2Rzk3SUhxUWhlVWZLUFNJ?= =?utf-8?B?aFJMcFBhT3ZLaG1jQ0RvNkc5VVljdmh0SnNSOTdMMVUrdkF6YUlTV1M5YWFD?= =?utf-8?B?WEpkNDNHWWd2bkk1QStibW9sajNIWlhoUDk5V095MEZmL084YUtJZlo2MTZC?= =?utf-8?B?L0ZvckxSdkRuK0FPMjVIY2tVQnh3cHViTTZpOE9Sb0g2cDluNmhHVmQ5RnpV?= =?utf-8?B?dEVjVnR2c0MwRkU4ZDJXY09WRGJYN09VMnVueHpKUzdRM3VmbUNMa0VhQlVt?= =?utf-8?B?WDRkM2V4OFV6S2ZKcUpRQkdLU0I5WDQveGdEUkdRdERSM3kxd3dlZy85OTV1?= =?utf-8?B?aWR2TFBEYmlxUGw0akZ4Qm5tZ2dOcUhFUkNvRzlLOCtqTlZCQTVha3Zncm5i?= =?utf-8?B?eG9VYytXZ3lkYU1xUXZVbTlNNEJPcjkxcFN5RXVUQTUwN2JxcjFzc0t6Mmgy?= =?utf-8?B?YlF5WGpQWEdCNWRzS2p3UVJFckZWMkc0TFRDRTdRZ2grZDlMMUpKSjBpSEx2?= =?utf-8?B?UUJET2tzaEpkWDhxYy9hZWNxaEgyQlV6bW9seWRkMmRJUGNTZGpMWk9yRGhJ?= =?utf-8?B?VzBhWU1DSDlNbUhtbEg5U3plNmY5TENCSFFwVXl3WGJPMldoU0VMeGN4Mjdu?= =?utf-8?B?NlFEUHdxbUlFK3U5YXU1b3JsaVBHQnlrVXJoZDQveTcrMkNMbXV2c0pwWkVq?= =?utf-8?B?aUVEL1lPZEIrYk5tRWpOMS9jME1ZT1BzZ25kb2dudkxoV3RiOWhZd3NsTkhX?= =?utf-8?B?S1RFNTltMTYwRWtTelp0MXRFYVMvNWhOWEgrMkQwVTBZMmQrZ200QXIydWR0?= =?utf-8?B?c1JWWGI4QWlTbFdoSnIyYXQ2bnFVakh3OTN0ejEzOE5aeGM3VVlHS09tZkdR?= =?utf-8?Q?gAVUMgVXXyo1YTJoeNoZvDptSbk+HsvBVxQEayM0IY=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;6:HMjKi0s7ijLwNdfSdjjSHB5tw+244BVtvwMmzEnqLtHLYXW+H/kK5yZbhtFII+Kd68Z8qhFEr91QFjp0CmoA/6wlnNn8EKunfhpbZxHEVIg9XPvVVr2wm7AIDIzsm14rZMsCiFDAB7DJqmshJRA6/BCNJTw5xdq8M7KvW+9jIh4U4oXk77JvzdVSTqETi6U1TGb+vbJDgC8vjHHAZQnxCHnb5dLShI88KYvYE4T2rHhs66IzjJpVzaiNKgX4K1JftT+xG15I2O0qUiqlfux8eHSbHayZ1tbEW87ETzd1GmHDOae+m3sYALLGkBQ6FaHLUwJTXK+63MMJ19tXp4YOCN5JNyp6yzKO6NUEIXBlRnZv2i/aEzofAU5v/8lgkkUK9ygdy2md751om+1x5Ms9LJzlKMdk8+fr0T8LfcbjWtI=;5:9vskuXfMCf+b68DsP3uPwYb3QlXfDA+GzR4X+2N6HLqTwLKMceusnUYxdm2/Ifwwfql5X2xsvultARRI8DQvVYUStZjVNqDvIgZHE5P2E68/sqTwFLf0+3IIzHdMFIiGQbSYjQp9zl6xl9n9yyMwTg==;24:LjNgbsdml+syYYR/KKxhazciIyKQGO+EdEJTF2P1gnDQwWHz78wWZz0Dhdz/LJnTaDfoMHLKgyX++dad4dA8rZlWOwqlYVzUkd0fPlenX94= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;7:Uq3VrvhqWZt583BWPEJNmGvNHe/7mL8p6EcXwspTAhM4vYdohYPxLwIGjvSgbK9C55IA8aOGZmBjaWyZY7HRJoGbPB6sZMOyVBAdpQVnxDGHHRR38xWTuNNE1EF5wzbJnJ1SSv3Y9Fcv/NE7PnOy2MC+kkGKWqhhW2z58PK7tc1XtmKRcWOhP5vYA1iwC4/zvUVvnI/5vS/IetD8NF1oo0DErwsWeznltFXbZHm5Yfs9fOe91nGDsurz1w32G3z8g/ZCablBOyT0Fn+UkjRcXt+rME4ZZQoWFp34io7wznLVhn7NueeAlAJ6JNL1Oqgz4aScOtDNaRczaiyOj0BWFA==;20:5Mys5tNuMUhMN5A8Q7MEXMX98j6aSUJEKEp/T19r7iRUbf8kjPlnKidsK40hKtFitw07eIvELdQ9YtsXIA1hi0LgXE3oiXdhecrlPJatJvVKHjfWTkeK3RilsXDjBHmNhojKrGYZ/4+nqy4W+ukalKFRWF7uq1v5lfXlFIKHu0HPy4sjxPkbTfyLs/w86ASVR8l1ypabYUN459dLO6GyVaXZFhG2X43hZoZsnp05F2fLTkNIDNcdeo5Aht5fxEuK X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2017 19:42:20.0682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2017 12:13 PM, Borislav Petkov wrote: > On Thu, Feb 16, 2017 at 09:42:36AM -0600, Tom Lendacky wrote: >> Update the CPU features to include identifying and reporting on the >> Secure Memory Encryption (SME) feature. SME is identified by CPUID >> 0x8000001f, but requires BIOS support to enable it (set bit 23 of >> SYS_CFG MSR). Only show the SME feature as available if reported by >> CPUID and enabled by BIOS. >> >> Signed-off-by: Tom Lendacky >> --- >> arch/x86/include/asm/cpufeature.h | 7 +++++-- >> arch/x86/include/asm/cpufeatures.h | 5 ++++- >> arch/x86/include/asm/disabled-features.h | 3 ++- >> arch/x86/include/asm/msr-index.h | 2 ++ >> arch/x86/include/asm/required-features.h | 3 ++- >> arch/x86/kernel/cpu/common.c | 19 +++++++++++++++++++ >> 6 files changed, 34 insertions(+), 5 deletions(-) > > What happened here? > > You had it already: > > https://lkml.kernel.org/r/20161110003459.3280.25796.stgit@tlendack-t1.amdoffice.net > > The bit in get_cpu_cap() with checking the MSR you can add at the end of > init_amd() for example. I realize it's a bit more code and expands the changes but I thought it would be a bit clearer as to what was going on this way. And then the follow on patch for the physical address reduction goes in nicely, too. If you prefer I stay with the scattered feature approach and then clear the bit based on the MSR at the end of init_amd() I can do that. I'm not attached to either method. Thanks, Tom >