From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=212.18.0.10 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795259379; b=gUDIQM0lFA9Ne6izUsTtW4ZzXiJ4JpJXDeuAd1VzJKVAvM6106ULcUipoIj0tDM9wxGG IL+zQGzbMXHY73On7RUbKHrUusbXy8W8yY+t4+t/2BR9B+DZtCZpkwtPxUIGD99hWO6fY 8ROQAQ5ULjpTt3XGG4JsNbDZHAj+0HMt3hHrt0l3996TD2oWrZiILrkrSYTeLpGkh5Eyx zcllveuoDuVMLun6jcMijY5mQtI/VU01iZaFUT/UBoYdsqA+cZ2Ei2ydv0z3k4/RhX+pE CbLu68L2Lm8DanWWv0tMYAj8/ZSdTAmimgSBQJhbu9INd8hTJKb4wANLLiH09N+51rQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795259379; h=DMARC-Filter:Received:DKIM-Signature:Received:X-Auth-Info: X-Auth-Info:Received:Received:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=nIWCIl4xLmtB84iRieZH0tm1YRmVF/7wcnmyIAkVNjc=; b=FstbbeqHwz7h1DdVz2CxYjPHyLeKdEpyDhClIjYPAJHI/r522fK9z9y34u9/FZ6i2F3L Vl2HfwOOYNrByEt44AWi22mZQpQ1gJTr4YyhN4Zg/Q2/ZKbpP3Bz1722rHL2ltz+UBLhI oYiB5j/+Fl3IT5VqaUoC55qGmJuensR2ILDrpDf6/kcR5UjRzOWBEgDNxNZe8BEIlIOnI cQEofntwoUR0MPvsIzLZhQZp7iugWaysVuxsFQM1hGPPOxILIIFRlnZ+q+vWR5fD5FYbT 9zI5KAY88Na9a054LIF9jWnVde+QaUAZjO7+Ql0D73jk+0ZLTWAM2tAvyDJNxYhHseQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=muenchen-mail.de; spf=pass smtp.mailfrom=muenchen-mail.de; dkim=pass header.d=muenchen-mail.de header.i=@muenchen-mail.de header.a=rsa-sha256 header.s=r1 header.b=LH+tj7Lb; arc=none smtp.remote-ip=212.18.0.10 Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02FE5606A32C; Sat, 21 Nov 2026 11:09:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 02FE5606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=muenchen-mail.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=muenchen-mail.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=muenchen-mail.de header.i=@muenchen-mail.de header.a=rsa-sha256 header.s=r1 header.b=LH+tj7Lb Received: from mail-out.m-online.net (localhost [127.0.0.1]) by mail-out.m-online.net (Postfix) with ESMTP id 4jWqGk3FJYz1sP1g; Sat, 21 Nov 2026 12:09:34 +0100 (CET) DKIM-Signature: a=rsa-sha256; bh=nIWCIl4xLmtB84iRieZH0tm1YRmVF/7wcnmyIAkVNjc=; c=relaxed/relaxed; d=muenchen-mail.de; h=Date:From:To:Message-ID:Subject; s=r1; t=1795259374; v=1; b=LH+tj7LbDItWc7DNBhdW9+/bSdmoS4H6V/EtW4xY4l0PKcmd8pxZ8V/asx9PF/xW eT9VJW0BWZE+GwT3hceILSvmLgCDIgWa7fuAo3ER2tROmPgMt8ah9i3lUy8wl2UT yoEss4sik8tpMVUK9p4tMXxmKCESPcxRe8BsusCFQcqAbl1sAsoH7K1on+AcQyK6 FbZrk8jCyjHkSDSHWLk5i1yGdCD09UytxOybmc5e3cTvSsHqn59tcrJwFg1lIfQ9 nvjTP/gR85Fw1aUtlkP7IwEBDQa8V2XMdOO4PbiUb/v3obVxhDxcVR7h64dRgwc7 LEd9cjPAJ4Z4dnEpRhBgcg== Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4jWqGh1c3wz1sP22; Sat, 21 Nov 2026 12:09:32 +0100 (CET) X-Auth-Info: IHaH2TR3WvIGRr5sxN7MbW9dpk6Rd4SEz0O6VTWDB3jm97DjI6gRwBmaT81pWHNE X-Auth-Info: IHaH2TR3WvIGRr5sxN7MbW9dpk6Rd4SEz0O6VTWDB3jm97DjI6gRwBmaT81pWHNE Received: from wiesel.intern (ppp-212-114-181-207.dynamic.mnet-online.de [212.114.181.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA id 4jWqGf3l8Tz1qqlT; Sat, 21 Nov 2026 12:09:30 +0100 (CET) Received: from [IPV6:fdea:9b79:8984:1:7c3b:4612:a548:c3c8] (unknown [IPv6:fdea:9b79:8984:1:7c3b:4612:a548:c3c8]) by wiesel.intern (Postfix) with ESMTP id E7C8879A0114; Sat, 21 Nov 2026 12:09:29 +0100 (CET) Message-ID: Date: Sat, 21 Nov 2026 12:09:29 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead To: Drew Fustini Cc: Marcel Holtmann , Luiz Augusto von Dentz , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org References: <20261020132604.90708-1-thomas.gerner@muenchen-mail.de> <20261020132604.90708-3-thomas.gerner@muenchen-mail.de> Content-Language: en-US From: Thomas Gerner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 21.11.26 um 00:34 schrieb Drew Fustini: > On Tue, Oct 20, 2026 at 03:26:04PM +0200, Thomas Gerner wrote: >> On the BeagleV-Ahead the bluetooth module of the Ampak AP6203BM is >> identified by the btbcm driver as BCM4362A2. The module is connected by >> UART4, several gpio pins and an I2S interface. The I2S is currently not >> used as there is currently no driver. >> >> Signed-off-by: Thomas Gerner >> --- >> Changes in v2: >> - use default pinctrl definition for bluetooth in and out pins > Thanks for sending v2. Sorry for the delay in review. > >> >> .../boot/dts/thead/th1520-beaglev-ahead.dts | 85 +++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts >> index e16484a47653..7161a9d4c61f 100644 >> --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts >> +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts >> @@ -76,6 +76,23 @@ led-5 { >> }; >> }; >> >> + reg_vbat_1v8: regulator-vbat-1v8 { >> + compatible = "regulator-fixed"; >> + regulator-boot-on; >> + regulator-max-microvolt = <1800000>; >> + regulator-min-microvolt = <1800000>; >> + regulator-name = "vbat-1v8"; >> + }; >> + >> + reg_vbat_3v3: regulator-vbat-3v3 { >> + compatible = "regulator-fixed"; >> + enable-active-high; > enable-active-high has no effect without a gpio. > >> + regulator-boot-on; >> + regulator-max-microvolt = <3300000>; >> + regulator-min-microvolt = <3300000>; >> + regulator-name = "vbat-3v3"; >> + }; > Nothing can switch these two rails so regulator-always-on describes them > better than regulator-boot-on. I see. With the next version I will consider this. The regulator definitions are here only to prevent the hci driver form printing a message about missing regulator. Once we have the final regulators for the AON subsystem we should check this definitions and replace them if appropriate. > >> + >> hdmi-connector { >> compatible = "hdmi-connector"; >> type = "d"; >> @@ -152,6 +169,28 @@ led-pins { >> }; >> >> &padctrl0_apsys { >> + bluetooth_pins: bluetooth-0 { >> + in-pins { >> + bias-disable; >> + drive-strength = <1>; >> + function = "gpio"; >> + input-enable; >> + input-schmitt-enable; >> + pins = "GPIO2_30"; >> + slew-rate = <0>; >> + }; >> + >> + out-pins { >> + bias-disable; >> + drive-strength = <3>; >> + input-disable; >> + input-schmitt-disable; >> + pins = "SDIO1_DETN", /* GPIO2_29 */ >> + "SDIO1_WPRTN"; /* GPIO2_28 */ >> + slew-rate = <0>; >> + }; >> + }; >> + >> gmac0_pins: gmac0-0 { >> tx-pins { >> pins = "GMAC0_TX_CLK", >> @@ -268,6 +307,30 @@ reg-on-pins { >> }; >> }; >> >> +&padctrl1_apsys { >> + uart4_pins: uart4-0 { >> + rx-pins { >> + bias-disable; >> + drive-strength = <1>; >> + function = "uart"; >> + input-enable; >> + pins = "UART4_RXD", "UART4_CTSN"; >> + input-schmitt-enable; >> + slew-rate = <0>; >> + }; >> + >> + tx-pins { >> + bias-disable; >> + drive-strength = <3>; >> + function = "uart"; >> + input-disable; >> + pins = "UART4_TXD", "UART4_RTSN"; >> + input-schmitt-disable; >> + slew-rate = <0>; >> + }; >> + }; >> +}; >> + >> &sdio0 { >> bus-width = <4>; >> max-frequency = <198000000>; >> @@ -314,3 +377,25 @@ &uart0 { >> pinctrl-0 = <&uart0_pins>; >> status = "okay"; >> }; >> + >> +&uart4 { >> + pinctrl-0 = <&uart4_pins>; >> + pinctrl-names = "default"; >> + uart-has-rtscts; >> + >> + status = "okay"; >> + >> + bluetooth { >> + compatible = "brcm,bcm4329-bt"; >> + device-wakeup-gpios = <&gpio2 29 GPIO_ACTIVE_HIGH>; >> + interrupt-parent = <&gpio2>; >> + interrupts = <30 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "host-wakeup"; >> + max-speed = <921600>; >> + pinctrl-0 = <&bluetooth_pins>; >> + pinctrl-names = "default"; >> + shutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* BT-REG-ON */ > This triggers checkpatch: > > WARNING: please, no space before tabs > #230: FILE: arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts:397: > +^I^Ishutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; ^I/* BT-REG-ON */$ > >> + vbat-supply = <®_vbat_3v3>; >> + vddio-supply = <®_vbat_1v8>; >> + }; >> +}; >> -- >> 2.53.0 >> > Thanks, > Drew Best regards Thomas