From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2679C433DB for ; Wed, 20 Jan 2021 11:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FE4122AAA for ; Wed, 20 Jan 2021 11:34:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728346AbhATLdr (ORCPT ); Wed, 20 Jan 2021 06:33:47 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39052 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732248AbhATKR6 (ORCPT ); Wed, 20 Jan 2021 05:17:58 -0500 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 817EE813; Wed, 20 Jan 2021 11:17:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1611137836; bh=9LS1tzVULivXbxvsb4fOqaJBauUFKNy4KU9N+8aTcpo=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=cerHDvXdwMHMWqmvTHi+HwigwJqHXAIq2h/BlCbCQDg85zA6AdSOnF4T24kUMvaNB 4aQbtgMbJr9f4NqfdWTCo5iS9/tkWynjddiGFpSe682QaRKuVjYRmlPWK1r8cYg1YY JD1EI5xmeh4IqeREbcQMTx18ZK7S1BCSYTYBUVaM= Subject: Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor To: Lad Prabhakar , Sakari Ailus , Mauro Carvalho Chehab , Laurent Pinchart , Jacopo Mondi , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Biju Das , Prabhakar References: <20210120090148.30598-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Wed, 20 Jan 2021 10:17:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210120090148.30598-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lad, On 20/01/2021 09:01, Lad Prabhakar wrote: > Fix OV772x build breakage by selecting V4L2_FWNODE config: > > ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe': > ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse' > ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free' > ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse' > > Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties") > Reported-by: kernel test robot > Signed-off-by: Lad Prabhakar I see this driver uses subdev API too. Should the driver also select VIDEO_V4L2_SUBDEV_API? Or is that covered sufficiently already on any platforms that would use the driver? Reviewed-by: Kieran Bingham > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index eddb10220953..bb1b5a340431 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -1013,6 +1013,7 @@ config VIDEO_OV772X > tristate "OmniVision OV772x sensor support" > depends on I2C && VIDEO_V4L2 > select REGMAP_SCCB > + select V4L2_FWNODE > help > This is a Video4Linux2 sensor driver for the OmniVision > OV772x camera. >