From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F45C47088 for ; Wed, 30 Nov 2022 09:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232970AbiK3JX7 (ORCPT ); Wed, 30 Nov 2022 04:23:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232741AbiK3JX5 (ORCPT ); Wed, 30 Nov 2022 04:23:57 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5146C1837F; Wed, 30 Nov 2022 01:23:56 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7DB6D660036C; Wed, 30 Nov 2022 09:23:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1669800234; bh=b/rlfin9Tu9Zg934405VE93p9gBOHlJBLcSBvPpyPXY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TU92YAgRkOWnyIP3bvJqgwHT2x7OsuuBfGtxWnADsoddRRL8dVNwSOLIIq9iXGClu ZDyOpAR+4FH4w9JKcC44yCrAf4ixqxqnVDX5y+K75zqEWqfKgMip80ugRc6dDiETe/ 9zWuM7Na3x2jr/eQrOfmVK2+5Thg9HnFJ3w8hjUdULKHkDeHnNCs4Az1H4oJ0WlWNV UqX5DNxYmvAdcMmXYji0csNn9FYeBB0kM0zF4/9R/meuF9UXgo41Z+kOdQciVMRs4q yRajDFgWP2KaE6U/ctk5oMmNuB6ojJs5YGZigiTQW8HaZtO0YFNUeeqAjuRxQ/FBV2 DBUYJpgsDmQEg== Message-ID: Date: Wed, 30 Nov 2022 10:23:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/6] dt-bindings: mediatek: modify VDOSYS0 mmsys device tree Documentations for MT8188 Content-Language: en-US To: "nathan.lu" , Rob Herring , Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Maxime Coquelin , Alexandre Torgue , Matthias Brugger Cc: "jason-jh . lin" , CK Hu , Rex-BC Chen , Moudy Ho , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, lancelot.wu@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20221129143503.16638-1-nathan.lu@mediatek.com> <20221129143503.16638-3-nathan.lu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221129143503.16638-3-nathan.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 29/11/22 15:34, nathan.lu ha scritto: > From: Nathan Lu > > modify VDOSYS0 mmsys device tree Documentations for MT8188. > > Signed-off-by: Nathan Lu > --- > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > index 0711f1834fbd..3e7fb33201c5 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > @@ -47,6 +47,10 @@ properties: > - const: mediatek,mt2701-mmsys > - const: syscon > > + - items: > + - const: mediatek,mt8188-vdosys0 The devicetree node will be like: something: something@somewhere { compatible = "mediatek,mt8188-vdosys0", "syscon"; .... }; ....and will never get any additional compatible string, as when you'll add vdosys1 support, we'll get a similar node like: something_else: something_else@somewhere_else { comaptible = "mediatek,mt8188-vdosys1", "syscon"; .... }; ...so this should go upper in the enum that's listing all of the mediatek,mtXXXX-mmsys compatibles, specifically after `mediatek,mt8186-mmsys`. Please fix. Regards, Angelo