From: Alan Stern <stern@rowland.harvard.edu>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: gregkh@linuxfoundation.org, colin.i.king@gmail.com,
xuetao09@huawei.com, quic_eserrao@quicinc.com,
water.zhangjiantao@huawei.com, peter.chen@freescale.com,
balbi@ti.com, francesco@dolcini.it, alistair@alistair23.me,
stephan@gerhold.net, bagasdotme@gmail.com, luca@z3ntu.xyz,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v2] usb: gadget: udc: core: Offload usb_udc_vbus_handler processing
Date: Fri, 19 May 2023 11:07:25 -0400 [thread overview]
Message-ID: <a1d064e7-9847-4e2e-b74a-4ae4f39d3f04@rowland.harvard.edu> (raw)
In-Reply-To: <c181c8ef-f342-4a31-9b8c-e1fa14ad214e@rowland.harvard.edu>
On Fri, May 19, 2023 at 10:49:49AM -0400, Alan Stern wrote:
> On Fri, May 19, 2023 at 04:30:41AM +0000, Badhri Jagan Sridharan wrote:
> > chipidea udc calls usb_udc_vbus_handler from udc_start gadget
> > ops causing a deadlock. Avoid this by offloading usb_udc_vbus_handler
> > processing.
>
> Look, this is way overkill.
>
> usb_udc_vbus_handler() has only two jobs to do: set udc->vbus and call
> usb_udc_connect_control(). Furthermore, it gets called from only two
> drivers: chipidea and max3420.
>
> Why not have the callers set udc->vbus themselves and then call
> usb_gadget_{dis}connect() directly? Then we could eliminate
> usb_udc_vbus_handler() entirely. And the unnecessary calls -- the ones
> causing deadlocks -- from within udc_start() and udc_stop() handlers can
> be removed with no further consequence.
>
> This approach simplifies and removes code. Whereas your approach
> complicates and adds code for no good reason.
I changed my mind.
After looking more closely, I found the comment in gadget.h about
->disconnect() callbacks happening in interrupt context. This means we
cannot use a mutex to protect the associated state, and therefore the
connect_lock _must_ be a spinlock, not a mutex.
This also probably means that udc_start and udc_stop callbacks should
not be invoked with the lock held. In fact, you might want to avoid
using the lock at all with gadget_bind_driver() and
gadget_unbind_driver() -- use it only in the functions that these
routines call.
So it appears the whole connect_lock thing needs to be redesigned with
these ideas in mind. However, it's still true that the UDC drivers
shouldn't try to set the connection state from within their udc_start
and udc_stop callbacks, because the core takes care of this
automatically.
Alan Stern
next prev parent reply other threads:[~2023-05-19 15:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 4:30 Badhri Jagan Sridharan
2023-05-19 14:49 ` Alan Stern
2023-05-19 15:07 ` Alan Stern [this message]
2023-05-19 15:44 ` Badhri Jagan Sridharan
2023-05-19 17:27 ` Alan Stern
2023-05-22 7:48 ` Badhri Jagan Sridharan
2023-05-22 9:05 ` Badhri Jagan Sridharan
2023-05-22 15:55 ` Alan Stern
2023-05-27 2:42 ` Badhri Jagan Sridharan
2023-05-27 16:36 ` Alan Stern
2023-05-29 23:32 ` Badhri Jagan Sridharan
2023-05-30 0:42 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d064e7-9847-4e2e-b74a-4ae4f39d3f04@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=alistair@alistair23.me \
--cc=badhri@google.com \
--cc=bagasdotme@gmail.com \
--cc=balbi@ti.com \
--cc=colin.i.king@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=peter.chen@freescale.com \
--cc=quic_eserrao@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=stephan@gerhold.net \
--cc=water.zhangjiantao@huawei.com \
--cc=xuetao09@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®