From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B7BE334C2C for ; Mon, 29 Dec 2025 16:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767025936; cv=none; b=MVxJvrw2nfXtpeS1xsh1l0bRh6vOuZzfLLeinGzHeovUk1JC5rH7yy2y+zIQ6jYCs4T3WW6ahQV6ugS1+2oWXcf5vxRE1Zh+SUAv808Lxqlysb24jsWY2YvUHaALkQIef3h2ZBz0da5gqNnYOubm+UM3WFkRJakY5FB0UJabezg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767025936; c=relaxed/simple; bh=D/5qbu+6DCkne9hn8n6AtJW5EHUE67wjy4QQunH6wQY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=GlezhyfwyL4+8p4JbKXpDMKVgFjhOGGbn6gF/qV4yg82fherZm5z1TWAWg0K7e3vwNmdKp0C94AALO8KACBM5VY/uE1HNAYum6GXFoHJhToPeug6Z41QsWgpfC+BhgJd6ymOKo9JQWGLgZjPAvSvcGj+fzJ8QZZ+78if91wUn5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=OUtfCeto; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="OUtfCeto" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20251229163205euoutp018ffc02f4ab4909e21544ccf965f02056~FvLewAMCT0366403664euoutp011 for ; Mon, 29 Dec 2025 16:32:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20251229163205euoutp018ffc02f4ab4909e21544ccf965f02056~FvLewAMCT0366403664euoutp011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1767025925; bh=ExuLuxvl1jriYgk9lUcZeu3ugdqLUTCtudQjE6LZFdU=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=OUtfCeto9if+4bYrYwp+GWsRyDWuD6AyJW8UKJeGrqKoriGKr5kYlYTNdA2Lcs7no 2jmv7sB5rLPYTOX588jBaXA8gQjpZSs7EJ3XOVBFc2/E2i16RBNXcG3L9mhWnQKJgR WfjSDB8fkHclTM1JBTSCy+WyBwNwrJnNUdNzNAF0= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20251229163205eucas1p1e9395170d400ce20537e79156f44778b~FvLeQqbAc1226212262eucas1p11; Mon, 29 Dec 2025 16:32:05 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20251229163204eusmtip2db25adcf9b918fc714030cdbfc1150d0~FvLdReIoO2218922189eusmtip2Y; Mon, 29 Dec 2025 16:32:04 +0000 (GMT) Message-ID: Date: Mon, 29 Dec 2025 17:32:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/9] Verisilicon DC8200 driver (and adaption to TH1520) To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Heiko Stuebner , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Han Gao , Yao Zi , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20251229163205eucas1p1e9395170d400ce20537e79156f44778b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20251224161255eucas1p24c6de486b021f25007ed1ce24468cab2 X-EPHeader: CA X-CMS-RootMailID: 20251224161255eucas1p24c6de486b021f25007ed1ce24468cab2 References: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> On 12/24/25 17:11, Icenowy Zheng wrote: > This patchset tries to add a driver for Verisilicon DC8200 driver, and > demonstrates the driver on T-Head TH1520 with its HDMI output. > > This display controller IP is used on StarFive JH7110 too, but as the > HDMI controller used there isn't as common as the DesignWare one, I > choose to use TH1520 in this patchset. > > The DC driver is written with other DC-series (mainly DC8000, which is > known to be used on Eswin EIC7700 SoC) display controllers in mind, and > uses the identification registers available on all Vivante branded IPs. > A known exception is DCNano display controller, which is unlikely to be > supported by this driver because of totally different register map and > no known identification registers. (P.S. the in-tree loongson DRM driver > seems to be for some DCNano instances based on the register map.) > > The HDMI controller seems to come with some common PHY by Synopsys, the > DesignWare HDMI TX 2.0 PHY. By searching a few register names from the > BSP driver of that PHY, that PHY seems to be used by a in-tree dw-hdmi > glue, rcar_dw_hdmi -- an updated downstream version of rcar_dw_hdmi > contains all 6 registers set here in the th1520-dw-hdmi driver. Some > more suprising thing is that RK3288 uses the same PHY too, but the > in-tree dw_hdmi-rockchip driver writes the configuration data array in a > weird way to reuse the HDMI 3D TX PHY configuring function. It might be > valuable to add common configuring function and configuration data > definition for this HDMI 2.0 PHY too, but the current driver in this > patchset simply duplicated most configuration logic from rcar_dw_hdmi > driver (but with 3 extra configuration registers configured). > > Icenowy Zheng (9): > dt-bindings: vendor-prefixes: add verisilicon > dt-bindings: display: add verisilicon,dc > drm: verisilicon: add a driver for Verisilicon display controllers > dt-bindings: display/bridge: add binding for TH1520 HDMI controller > drm/bridge: add a driver for T-Head TH1520 HDMI controller > riscv: dts: thead: add DPU and HDMI device tree nodes > riscv: dts: thead: lichee-pi-4a: enable HDMI > MAINTAINERS: assign myself as maintainer for verisilicon DC driver > mailmap: map all Icenowy Zheng's mail addresses > I tested this patchset on the Lichee Pi 4A (TH1520). I successfully ran a fully hardware accelerated graphics stack using Weston and Zink over the HDMI output. I have documented the reproduction steps and test results here: [1] https://mwilczynski.dev/posts/riscv-gpu-zink/#building-the-stack-reproduction-guide Great work, thank you! Feel free to add to driver and DTS patches (3,5,6,7). Tested-by: Michal Wilczynski Best regards, -- Michal Wilczynski