From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752449AbdJFTE3 (ORCPT ); Fri, 6 Oct 2017 15:04:29 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:53787 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751759AbdJFTE1 (ORCPT ); Fri, 6 Oct 2017 15:04:27 -0400 X-Google-Smtp-Source: AOwi7QCG+pvNzbYQJe8Qsh/cnMf1j6hFd+usO8mTQY4TzvWV4j8boEMSXhFrOfzmppaXumn8PMuqyw== Subject: Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free() To: Tim Hansen Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com References: <20171005180920.GA121296@debian> From: Jens Axboe Message-ID: Date: Fri, 6 Oct 2017 13:04:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005180920.GA121296@debian> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2017 12:09 PM, Tim Hansen wrote: > mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks. > > This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch). Applied, but I had to fix up your commit message. Please line wrap at 72 chars, otherwise it turns into an unreadable mess when people try to view them. -- Jens Axboe