From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F521EB64D7 for ; Fri, 16 Jun 2023 20:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235564AbjFPUuB (ORCPT ); Fri, 16 Jun 2023 16:50:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjFPUt7 (ORCPT ); Fri, 16 Jun 2023 16:49:59 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A18335B0; Fri, 16 Jun 2023 13:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=nf8z9XousGG+fVE7OsptakvEUAwhGZgWUXM8tGBA97M=; b=jdEqE2Wn/cO1xvbzkNfLi+Atgo jR6e5hb9TOYewjSGCf0W1Httwa9X92uNwLzho6/sTGvZH3jUNpHgHOjya1oB0y2kMwB62re10s1zD MiydOAT7bkzDbqSpFuGWcBjS3q9Rql9zz53tgrdi0GO99joBx5vMwyjF9+pXq1A9tMM0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qAGOE-00Gl5j-KY; Fri, 16 Jun 2023 22:49:50 +0200 Date: Fri, 16 Jun 2023 22:49:50 +0200 From: Andrew Lunn To: "Radu Pirea (NXP OSS)" Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sebastian.tobuschat@nxp.com Subject: Re: [PATCH net-next v1 06/14] net: phy: add 1000baseT1 to phy_basic_t1_features Message-ID: References: <20230616135323.98215-1-radu-nicolae.pirea@oss.nxp.com> <20230616135323.98215-7-radu-nicolae.pirea@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616135323.98215-7-radu-nicolae.pirea@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 04:53:15PM +0300, Radu Pirea (NXP OSS) wrote: > Add 1000baseT1 bit to phy_basic_t1_features. Please add an explanation why this is safe. For example, why the RTL9000AA does not start saying it supports 1000BaseT1_Full. Has 1000BaseT1_Full been standardised? If there a feature bit in a register to indicate the hardware supports it? That would be the preferred method to determine what the hardware can do. Andrew