From: Paolo Abeni <pabeni@redhat.com>
To: Philo Lu <lulie@linux.alibaba.com>, netdev@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, dsahern@kernel.org,
horms@kernel.org, antony.antony@secunet.com,
steffen.klassert@secunet.com, linux-kernel@vger.kernel.org,
dust.li@linux.alibaba.com, jakub@cloudflare.com,
fred.cc@alibaba-inc.com, yubing.qiuyubing@alibaba-inc.com
Subject: Re: [PATCH v8 net-next 3/4] ipv4/udp: Add 4-tuple hash for connected socket
Date: Tue, 12 Nov 2024 15:58:05 +0100 [thread overview]
Message-ID: <a1db0c11-38ee-4932-86bc-a397a0ecf963@redhat.com> (raw)
In-Reply-To: <20241108054836.123484-4-lulie@linux.alibaba.com>
On 11/8/24 06:48, Philo Lu wrote:
[...]
> Signed-off-by: Philo Lu <lulie@linux.alibaba.com>
> Signed-off-by: Cambda Zhu <cambda@linux.alibaba.com>
> Signed-off-by: Fred Chen <fred.cc@alibaba-inc.com>
> Signed-off-by: Yubing Qiu <yubing.qiuyubing@alibaba-inc.com>
[...]
> @@ -2937,7 +3128,7 @@ struct proto udp_prot = {
> .owner = THIS_MODULE,
> .close = udp_lib_close,
> .pre_connect = udp_pre_connect,
> - .connect = ip4_datagram_connect,
> + .connect = udp_connect,
> .disconnect = udp_disconnect,
> .ioctl = udp_ioctl,
> .init = udp_init_sock,
2 minor notes, possibly not needing a repost:
- The SoB chain looks strange, do you mean co-developed-by actually?
- udplite is not touched. AFAICS should not be a problem - just the
feature will not be available for udplite. I'm wondering if syzbot could
prove me wrong about "not being a problem" (usually it's able to do that;)
/P
next prev parent reply other threads:[~2024-11-12 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 5:48 [PATCH v8 net-next 0/4] udp: Add 4-tuple hash for connected sockets Philo Lu
2024-11-08 5:48 ` [PATCH v8 net-next 1/4] net/udp: Add a new struct for hash2 slot Philo Lu
2024-11-08 5:48 ` [PATCH v8 net-next 2/4] net/udp: Add 4-tuple hash list basis Philo Lu
2024-11-08 5:48 ` [PATCH v8 net-next 3/4] ipv4/udp: Add 4-tuple hash for connected socket Philo Lu
2024-11-12 14:58 ` Paolo Abeni [this message]
2024-11-13 1:50 ` Philo Lu
2024-11-14 9:12 ` Paolo Abeni
2024-11-08 5:48 ` [PATCH v8 net-next 4/4] ipv6/udp: " Philo Lu
2024-11-11 17:58 ` [PATCH v8 net-next 0/4] udp: Add 4-tuple hash for connected sockets Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1db0c11-38ee-4932-86bc-a397a0ecf963@redhat.com \
--to=pabeni@redhat.com \
--cc=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=fred.cc@alibaba-inc.com \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yubing.qiuyubing@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®