mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Raslan, KarimAllah" <karahmed@amazon.de>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kernellwp@gmail.com" <kernellwp@gmail.com>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>
Subject: Re: cputime takes cstate into consideration
Date: Tue, 9 Jul 2019 11:27:54 -0700	[thread overview]
Message-ID: <a1dbbed2-17e4-89e5-d141-9c30dc352c5f@oracle.com> (raw)
In-Reply-To: <20190709123838.GA3402@hirez.programming.kicks-ass.net>

On 7/9/19 5:38 AM, Peter Zijlstra wrote:
> On Mon, Jul 08, 2019 at 07:00:08PM -0700, Ankur Arora wrote:
>> On 2019-06-26 12:23 p.m., Thomas Gleixner wrote:
>>> On Wed, 26 Jun 2019, Raslan, KarimAllah wrote:
>>>> On Wed, 2019-06-26 at 10:54 -0400, Konrad Rzeszutek Wilk wrote:
>>>>> There were some ideas that Ankur (CC-ed) mentioned to me of using the perf
>>>>> counters (in the host) to sample the guest and construct a better
>>>>> accounting idea of what the guest does. That way the dashboard
>>>>> from the host would not show 100% CPU utilization.
>>>>
>>>> You can either use the UNHALTED cycles perf-counter or you can use MPERF/APERF
>>>> MSRs for that. (sorry I got distracted and forgot to send the patch)
>>>
>>> Sure, but then you conflict with the other people who fight tooth and nail
>>> over every single performance counter.
>> How about using Intel PT PwrEvt extensions? This should allow us to
>> precisely track idle residency via just MWAIT and TSC packets. Should
>> be pretty cheap too. It's post Cascade Lake though.
> 
> That would fully claim PT just for this stupid accounting thing and be
> completely Intel specific.
> 
> Just stop this madness already.
I see the point about just accruing guest time (in mwait or not) as
guest CPU time.
But, to take this madness a little further, I'm not sure I see why it
fully claims PT. AFAICS, we should be able to enable PwrEvt and whatever
else simultaneously.

Ankur

> 

      reply	other threads:[~2019-07-09 18:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  9:43 Wanpeng Li
2019-06-26 10:13 ` Peter Zijlstra
2019-06-26 10:33 ` Thomas Gleixner
2019-06-26 14:54   ` Konrad Rzeszutek Wilk
2019-06-26 16:16     ` Peter Zijlstra
2019-06-26 18:30       ` Konrad Rzeszutek Wilk
2019-06-26 18:41         ` Thomas Gleixner
2019-06-26 18:55           ` Raslan, KarimAllah
2019-06-26 19:19             ` Thomas Gleixner
2019-06-26 19:21             ` Peter Zijlstra
2019-06-26 19:27               ` Raslan, KarimAllah
2019-06-26 19:32                 ` Thomas Gleixner
2019-06-26 20:01                 ` Peter Zijlstra
2019-06-26 20:09                   ` Thomas Gleixner
2019-12-10  0:44                 ` Wanpeng Li
2019-06-26 19:29               ` Thomas Gleixner
2019-06-26 18:58     ` Raslan, KarimAllah
2019-06-26 19:23       ` Thomas Gleixner
2019-07-09  2:00         ` Ankur Arora
2019-07-09  2:06           ` Wanpeng Li
2019-07-09 12:38           ` Peter Zijlstra
2019-07-09 18:27             ` Ankur Arora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1dbbed2-17e4-89e5-d141-9c30dc352c5f@oracle.com \
    --to=ankur.a.arora@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=joao.m.martins@oracle.com \
    --cc=karahmed@amazon.de \
    --cc=kernellwp@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome