From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbcHKJrq (ORCPT ); Thu, 11 Aug 2016 05:47:46 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:14103 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbcHKJrn (ORCPT ); Thu, 11 Aug 2016 05:47:43 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 11 Aug 2016 02:44:18 -0700 Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons To: Marc Zyngier , Linus Walleij , John Stultz References: <57AC3959.2030404@arm.com> CC: Thomas Gleixner , lkml , Bjorn Andersson From: Jon Hunter Message-ID: Date: Thu, 11 Aug 2016 10:47:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57AC3959.2030404@arm.com> X-Originating-IP: [10.21.132.102] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/16 09:37, Marc Zyngier wrote: > On 08/08/16 22:48, Linus Walleij wrote: >> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: >> >>> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct >>> irq_fwspec *fwspec) >>> * it now and return the interrupt number. >>> */ >>> if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) { >>> - irq_set_irq_type(virq, type); >>> + irq_data = irq_get_irq_data(virq); >>> + if (!irq_data) >>> + return 0; >>> + >>> + irqd_set_trigger_type(irq_data, type); >>> return virq; >>> } >>> >>> If I revert just that, it works again. >> >> This makes my platform work too. >> Tested-by: Linus Walleij > > Hmmm. I'm now booting your kernel on the APQ8060, and reverting this > hunk doesn't fix it for me. I'm confused... > > The interesting part is this: > 109: 100000 0 msmgpio 88 Level (null) 88 is the pm8058 parent interrupt and so I am surprised you would even see this in /proc/interrupts as it should be a chained interrupt, right? Are you seeing this with all the ethernet updates for the APQ8060 in Linus' branch? I am curious what you see with stock v4.8-rc1 and if interrupts work ok with the change I had proposed. Hard to tell if there is more than one issue here. Cheers Jon -- nvpublic