From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Don Brace <don.brace@microsemi.com>,
linux-scsi@vger.kernel.org, esc.storagedev@microsemi.com
Cc: "James E. J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [2/4] scsi: hpsa: Less function calls in hpsa_big_passthru_ioctl() after error detection
Date: Sat, 24 Mar 2018 10:01:07 +0100 [thread overview]
Message-ID: <a1e4dcf0-22fa-0b9b-a111-56beac441b24@users.sourceforge.net> (raw)
In-Reply-To: <1dc030776c924626b97594a18537f59c@microsemi.com>
>> @@ -6501,14 +6501,16 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info
>> *h, void __user *argp)
>> cleanup0:
>> cmd_free(h, c);
>> cleanup1:
>> - if (buff) {
>> + {
>> int i;
>>
>> for (i = 0; i < sg_used; i++)
>> kfree(buff[i]);
>> kfree(buff);
>> }
>
> Thanks for looking at the hpsa driver.
>
> This HUNK ends up with an unnamed block.
Which identifier would you like to use there?
> I would prefer to not have it structured like this.
Would you like to show a source code layout alternative?
Regards,
Markus
next prev parent reply other threads:[~2018-03-24 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 8:30 [PATCH 0/4] SCSI-HPSA: Adjustments for hpsa_big_passthru_ioctl() SF Markus Elfring
2018-03-05 8:31 ` [PATCH 1/4] scsi: hpsa: Use memdup_user() rather than duplicating its implementation SF Markus Elfring
2018-03-05 8:32 ` [PATCH 2/4] scsi: hpsa: Less function calls in hpsa_big_passthru_ioctl() after error detection SF Markus Elfring
[not found] ` <1dc030776c924626b97594a18537f59c@microsemi.com>
2018-03-24 9:01 ` SF Markus Elfring [this message]
2018-03-05 8:33 ` [PATCH 3/4] scsi: hpsa: Delete an unnecessary initialisation in hpsa_big_passthru_ioctl() SF Markus Elfring
2018-03-05 8:34 ` [PATCH 4/4] scsi: hpsa: Move a variable assignment " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1e4dcf0-22fa-0b9b-a111-56beac441b24@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome