From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965840AbdKQQtu (ORCPT ); Fri, 17 Nov 2017 11:49:50 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36131 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964780AbdKQQtn (ORCPT ); Fri, 17 Nov 2017 11:49:43 -0500 X-Google-Smtp-Source: AGs4zMZugk+FAfwQxlMPOljpG+1HX6VBZlwr0XM/3R1r/NEiVLGX1c/U+trGTqZfklCcW4Fz5458zA== Subject: Re: [PATCH] vlynq : Handle return value of platform_get_irq_byname and vlynq_probe To: Arvind Yadav Cc: linux-kernel@vger.kernel.org References: <1d87b593fd57869ad42701df6c3087efa9e74c94.1510935630.git.arvind.yadav.cs@gmail.com> From: Florian Fainelli Message-ID: Date: Fri, 17 Nov 2017 08:49:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1d87b593fd57869ad42701df6c3087efa9e74c94.1510935630.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2017 08:21 AM, Arvind Yadav wrote: > platform_get_irq_byname() can fail here and we must check its return value. > > device_register() can fail here, initialised 'result' variable > beforen'goto fail_register' otherwise vlynq_probe will return uninitialised > 'result' variable. > > Signed-off-by: Arvind Yadav > --- > drivers/vlynq/vlynq.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c > index c0227f9..bc735f9 100644 > --- a/drivers/vlynq/vlynq.c > +++ b/drivers/vlynq/vlynq.c > @@ -722,13 +722,19 @@ static int vlynq_probe(struct platform_device *pdev) > VLYNQ_REMOTE_OFFSET); > > dev->irq = platform_get_irq_byname(pdev, "irq"); > + if (dev->irq < 0) { > + result = dev->irq; > + goto fail_register; > + } That part looks fine. > dev->irq_start = irq_res->start; > dev->irq_end = irq_res->end; > dev->local_irq = dev->irq_end - dev->irq_start; > dev->remote_irq = dev->local_irq - 1; > > - if (device_register(&dev->dev)) > + if (device_register(&dev->dev)) { > + result = -ENXIO; > goto fail_register; > + } However here, we should propagate the return value of device_register() to be consistent with the changes earlier. > platform_set_drvdata(pdev, dev); > > printk(KERN_INFO "%s: regs 0x%p, irq %d, mem 0x%p\n", > -- Florian