From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C82B53F7873 for ; Thu, 20 Aug 2026 09:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218763; cv=none; b=ExNs9wNsu+R7fXWbQFJwOqfUilqiETReKwOjk1I1mCE40URuGyJhSeGuyI/KGLpVTNcxMzembthRlSQKeRG34rrfGEDAATdinizYI0e+K0Rt/8hi+hn9nnChC9qDjPm32N04bYHi8ByyL14MbCoV9wnXyArIaiNM+/QAUofapk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218763; c=relaxed/simple; bh=gCHq+FG2gjmyRs22Jko+N/AeFjlsl46980OH5DBp3pM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LveMzbTCyiBu55g7/fG+pd/IUK2jA56QA2fcqS9a5Xw3wxv4PF0RbKTt2lUuHgxG0mFs4+9eodQ/4ccKt5XmW46D+145qTha7dNn0Dem4RAy9fQu06OElCzHIhHRc1lO09Cr6RY3xranwwht4RWwZkHVFeTRHslQGYTDSgAx6Zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=ptEcjP/n; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="ptEcjP/n" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:From:Cc:To:Subject: MIME-Version:Date:Message-ID:From:Reply-To; bh=/n6MsS1mvFdLHKqJXuH44GkrGg+yQ2wOemYqPKtigoY=; b=ptEcjP/nGzF/KLiA6X4zMDrMMn q/wDPqu5umDSmohzaq/yEHBvref4PnKeJXr10ZtC8jDlHOYhfsNLa7pct4Se48yGYmPm6jedECPWg ieJ/cnE6YldKMb096YuXeO/N/8omxkCnoLfrplkbfn7yKsIvIiZbh6Z7BUNRZLrF2TuIjwjBeNR8F MgV1d9CKoPrsQa/3s4B7FBPdAJi/9AxUaAJg1kOm5aPDZ7NLr25nxM3HZVLPeSCu1AxIJqqnloi2M Hd7rPCtAuc75efXS/t03VZ4mA3zlLjApUiOwJKn1VoHf97Fjz9QNzQLmEVTr37kZvyo582a7R3CdX C3u0/8mQ==; Received: from 154.red-79-147-121.dynamicip.rima-tde.net ([79.147.121.154] helo=[192.168.1.204]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1wwzEl-006WS7-4u; Thu, 20 Aug 2026 11:39:03 +0200 Message-ID: Date: Thu, 20 Aug 2026 11:38:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] drm/amd/display: follow-up fixes for LUT segmentation To: Alex Hung , airlied@gmail.com, alexander.deucher@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, simona@ffwll.ch, siqueira@igalia.com, sunpeng.li@amd.com Cc: Krunoslav Kovac , "'Dr . David Alan Gilbert'" , Bhawanpreet Lakha , Aurabindo Pillai , Matthew Schwartz , pekka.paalanen@collabora.com, robert.mader@posteo.de, amd-gfx@lists.freedesktop.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, "Wheeler, Daniel" References: <20260819161106.27702-1-mwen@igalia.com> Content-Language: en-US From: Melissa Wen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19/08/2026 21:07, Alex Hung wrote: > Thanks Melissa. > > I tested kms_colorop on DCN3.5 DCN3.14 without any problems. There are > some comments regarding to commit messages which I replied to each patch. > > I will send this patchset to next week's promotion test. Nice! Thanks! I sent a v2 addressing your comments in the commit message. https://lore.kernel.org/amd-gfx/20260820093324.10201-1-mwen@igalia.com/ Regarding the duplicated word `segments`, this follows the same pattern in similar color helpers and seems correct to me, since they are in different sentences. Melissa > > On 8/19/26 10:00, Melissa Wen wrote: >> Extend halving distribution for all curves/custom-LUT in a >> encode-to-linear operation, not only PQ/SRGB. This fixes failures in IGT >> kms_colorop test after [1]. Also use the CM3 degamma helper that >> translates curves to hw points for DCN30-based family, not only DCN32, >> since the banding issue is present on both. >> >> [1] >> https://lore.kernel.org/amd-gfx/20260623160112.1636801-1-mwen@igalia.com/ >> >> Melissa >> >> Melissa Wen (2): >>    drm/amd/display: use halving distribution for all encode-to-linear >>      curves >>    drm/amd/display: use translate_curve_to_degamma_hw_format on DCN30 >> >>   .../amd/display/dc/dcn30/dcn30_cm_common.c    | 34 ++++++------------- >>   .../amd/display/dc/hwss/dcn30/dcn30_hwseq.c   | 10 +++--- >>   2 files changed, 14 insertions(+), 30 deletions(-) >> >