From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=165.173.180.11 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794816762; b=bEmzTomXGOijjS+39C1DPz19BJZMSg4/w1UEv6e8WtxM4JSPVzIUiGyYzpWp7uKJVaI7 IEXiAypk5QFfbm3l3ZbVEGucLISppnQx7gKzhos92kHsHEdNWWaCWYuYj5f5rqCC0adRx XhmDTy78F0UT8qo8G/Ciepqorsn/Golmtju3ZKkPJuvto6h8ooafKPY2JngkF/Dzgy8/0 U+BSbZU7Ect+S+RX98Y2tWUAxaq9knCeIfDxtcedqr4Fesc3JBU7jDDo9c4ihU7id6n2h GRbsHDSwf2cPOptGOVvlAt+CXLqWe6XF2AZrTP0TznEPmPEXmKEYV3waY/Sg+5F3laQ== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794816762; h=DMARC-Filter:DKIM-Signature:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=qnNiZniQ7hU/5TWkcm4nRDnYdoUdBrV52jNGrhHKE60=; b=X2Iv04aOgqZznKtStptz/yLi3SZpDQWdWyFVHqf4WQv/gywqzwrTMWtmNCp7u9cFIas1 2yuVrbLjpIkDHvMT2QT8VL44SucYYMFxLxfY6xR0SR2YPUl60NDkd9Hyov3+dL8nHTQUu LWWIoOfjGI7fCXgtAjwjLrhw7cgLTCHE3oCRQysf2TZxGXr5ddHJHQrAPIkNddZNym4Wp Vd8sv0ITtzv4YhADH3SBiF/AFcPRl0YPBpkFLD/NSPTlN/Jniv9bxRlXKWhZ982IwaJHf kUS2WH/d3uB+GfFRs4gyUFePaWozS/s9RR3Yo3O/DOrVQCifnlVHFaabticw3P6W5Tg== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=Tg7GJN8V; arc=pass header.oldest-pass=0 smtp.remote-ip=165.173.180.11 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9F40606A33E for ; Mon, 16 Nov 2026 08:12:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E9F40606A33E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=Tg7GJN8V ARC-Seal: i=1; a=rsa-sha256; t=1794816753; cv=none; d=zohomail.com; s=zohoarc; b=A532Ekd+Z2KsibURE7m1nmvLs513y7ECYzW+jU413ILxQ0XEirO/uNZRNWRDJMryciASh2hXEw+mFskk1wlJHsNWcPDTQIaUcXuojMu6wdg8qBv/UUuiJJMV1wMt00USf9J/wE8M6XVRzJjqqWAExMCKWNo3KzBEmiBYHrqm5Ck= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1794816753; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=qnNiZniQ7hU/5TWkcm4nRDnYdoUdBrV52jNGrhHKE60=; b=ktg3NpXwjvTLmAwoCah4C/MMhMZRPn8fkt3OFd2o3X7y6q3BUk0l1YTdz7dH5sklazeDk+eF3mIgqM7SJCXE1dM49Lzqq3chGiS+C8cL1BaofJB202vgIkEhE+CmhUQDaRiIyXRxhrMaoEKfBd8tXDYum/wejO+exHxYPpezFfI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=benjamin.gaignard@collabora.com; dmarc=pass header.from= DKIM-Signature: a=rsa-sha256; b=Tg7GJN8V9orHnn3nGD2SqAtPDe8zQI5S9EytKgr6QkrMt/3fyTMFK5wnQIY9wzjnkYJoCPba0aIiGVcSbXCId5cenXQJwHZRuQvikZ/RQazcOSeGuB4ggapXs5+W+QFTuIa7unoazV9sFLNGxbqbrsJygCbRhLK/CS2bXXWSfH8=; c=relaxed/relaxed; s=zohomail; d=collabora.com; v=1; bh=qnNiZniQ7hU/5TWkcm4nRDnYdoUdBrV52jNGrhHKE60=; h=Content-Description:Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Sender:Resent-Cc:Resent-Date:Resent-To:Reply-To:Resent-Message-ID:Resent-From:Sender:Subject:To:Date:From:Message-Id:Reply-To:Subject:To:Cc; Received: by smtp.zohomail.com with SMTPS id 1794816752585120.90548357908153; Mon, 16 Nov 2026 00:12:32 -0800 (PST) Message-ID: Date: Mon, 16 Nov 2026 09:12:29 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iommu/vsi: Don't write the enable register on suspend To: aiyengar1990@gmail.com, "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org References: <20261113-vsi-iommu-disable-v1-1-94f7f44540b3@gmail.com> Content-Language: en-US From: Benjamin Gaignard In-Reply-To: <20261113-vsi-iommu-disable-v1-1-94f7f44540b3@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 13/11/2026 à 21:06, Arun Iyengar via B4 Relay a écrit : > From: Arun Iyengar > > Benjamin Gaignard pointed out that, per the IOMMU documentation, the > IOMMU can't be disabled once enabled. Drop the write on suspend: > resume reprograms the IOMMU anyway. > > Suggested-by: Benjamin Gaignard > Signed-off-by: Arun Iyengar Reviewed-by: Benjamin Gaignard > --- > Benjamin suggested this in the hantro-robust review: > https://lore.kernel.org/r/f212840b-92fd-4d97-a6a7-2768a55483f7@collabora.com > > Identity attach keeps the write. On RK3588 it does clear the enable > bit (AHB_CONTROL reads 0x1 before, 0x0 after), and without it the > IOMMU would keep using the old domain's page table. Benjamin, should > that one go too? > > Tested on RK3588S (Orange Pi 5), v7.3-based kernel with [1] and > hantro-robust v3 [2]: AV1 fluster unchanged (203/242), 20 AV1 decoder > unbind/bind cycles, 3 s2idle cycles. The IOMMU runtime suspended > after each step; no SError or IOMMU fault. > Not tested: identity domains, suspend to RAM. > No conflict with [1] or with patch 10 of [2]. > > Developed with Claude (Anthropic), which wrote the code and the commit > message. I reviewed it. > > [1] https://lore.kernel.org/r/20261113-vsi-iommu-pm-ref-v1-0-fd917eebdf18@gmail.com > [2] https://lore.kernel.org/r/20261113-hantro-robust-v3-0-82383c722ad2@gmail.com > --- > drivers/iommu/vsi-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/vsi-iommu.c b/drivers/iommu/vsi-iommu.c > index 5dac20b143a5..bd984060253b 100644 > --- a/drivers/iommu/vsi-iommu.c > +++ b/drivers/iommu/vsi-iommu.c > @@ -740,7 +740,7 @@ static int __maybe_unused vsi_iommu_suspend(struct device *dev) > { > struct vsi_iommu *iommu = dev_get_drvdata(dev); > > - vsi_iommu_disable(iommu); > + iommu->enable = false; > > clk_bulk_disable(iommu->num_clocks, iommu->clocks); > > > --- > base-commit: 2cf4be57b301ed2d7af82e70cff5dfd96894d8de > change-id: 20261113-vsi-iommu-disable-42edd626d009 > > Best regards, > -- > Arun Iyengar