From: Bryan O'Donoghue <bod@kernel.org>
To: Wangao Wang <wangao.wang@oss.qualcomm.com>,
vikash.garodia@oss.qualcomm.com,
dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev,
mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_qiweil@quicinc.com,
quic_renjiang@quicinc.com
Subject: Re: [PATCH v1 1/4] media: qcom: iris: Add support for scale and improve format alignment
Date: Wed, 15 Oct 2025 17:00:10 +0100 [thread overview]
Message-ID: <a1edafeb-af41-4c96-8c39-a327528e0802@kernel.org> (raw)
In-Reply-To: <20251015092708.3703-2-wangao.wang@oss.qualcomm.com>
On 15/10/2025 10:27, Wangao Wang wrote:
> Add output width and height settings in iris_venc_s_fmt_output to
> enable scaling functionality.
>
> Add members enc_raw_width, enc_raw_height, enc_bitstream_width and
> enc_bitstream_height to the struct iris_inst to support codec
> alignment requirements.
>
> HFI_PROP_CROP_OFFSETS is used to inform the firmware of the region
> of interest, rather than indicating that the codec supports crop.
> Therefore, the crop handling has been corrected accordingly.
>
> Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
Generally a patch that contains and "and" could be split into two patches.
Please do that here.
- One patch for your alignment changes
- One patch to support scaling
in whatever order is more logical.
---
bod
next prev parent reply other threads:[~2025-10-15 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 9:27 [PATCH v1 0/4] media: qcom: iris: encoder feature enhancements Wangao Wang
2025-10-15 9:27 ` [PATCH v1 1/4] media: qcom: iris: Add support for scale and improve format alignment Wangao Wang
2025-10-15 16:00 ` Bryan O'Donoghue [this message]
2025-10-17 5:43 ` Wangao Wang
2025-10-28 10:39 ` Vikash Garodia
2025-10-31 7:12 ` Dikshita Agarwal
2025-10-15 9:27 ` [PATCH v1 2/4] media: qcom: iris: Add rotation support for encoder Wangao Wang
2025-10-15 16:08 ` Bryan O'Donoghue
2025-10-17 5:54 ` Wangao Wang
2025-10-31 7:14 ` Dikshita Agarwal
2025-10-15 9:27 ` [PATCH v1 3/4] media: qcom: iris: Add flip " Wangao Wang
2025-10-15 9:27 ` [PATCH v1 4/4] media: qcom: iris: Add intra refresh " Wangao Wang
2025-10-17 9:55 ` [PATCH v1 0/4] media: qcom: iris: encoder feature enhancements Neil Armstrong
2025-10-27 7:40 ` Wangao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1edafeb-af41-4c96-8c39-a327528e0802@kernel.org \
--to=bod@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=wangao.wang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®