From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Mark Brown <broonie@kernel.org>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH][V2][next] ASoC: rt712-sdca: remove redundant else path of if statement
Date: Thu, 8 May 2025 16:17:42 +0100 [thread overview]
Message-ID: <a1f5fa12-1e0d-429c-bc15-79911c2571d1@gmail.com> (raw)
In-Reply-To: <174671514156.7345.16339489109303663127.b4-ty@kernel.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1599 bytes --]
Hi Mark,
Looking at your repo I think you applied the V1 of the patch and not the
V2.
Colin
On 08/05/2025 15:39, Mark Brown wrote:
> On Thu, 08 May 2025 09:45:27 +0100, Colin Ian King wrote:
>> There is an if/else check where the else part is executed if
>> adc_vol_flag is true, this else path checks if adc_vol_flag
>> is true (which is a redundant second check) and the if path is
>> always taken. Remove the redundant check and remove the else
>> path since that can never occur.
>>
>>
>> [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/1] ASoC: rt712-sdca: remove redundant else path of if statement
> commit: 8147e75bd5f0977f6d389f6cdb4f10956cc3d88f
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2025-05-08 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 8:45 Colin Ian King
2025-05-08 14:39 ` Mark Brown
2025-05-08 15:17 ` Colin King (gmail) [this message]
2025-05-09 1:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f5fa12-1e0d-429c-bc15-79911c2571d1@gmail.com \
--to=colin.i.king@gmail.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®