From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD04C61DA4 for ; Thu, 9 Mar 2023 13:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231442AbjCIN5W convert rfc822-to-8bit (ORCPT ); Thu, 9 Mar 2023 08:57:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231449AbjCINzP (ORCPT ); Thu, 9 Mar 2023 08:55:15 -0500 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFD2D460A4; Thu, 9 Mar 2023 05:55:09 -0800 (PST) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1paGjS-003nVv-BY; Thu, 09 Mar 2023 14:54:58 +0100 Received: from dynamic-077-188-003-023.77.188.pool.telefonica.de ([77.188.3.23] helo=[192.168.1.11]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1paGjS-002ozW-3O; Thu, 09 Mar 2023 14:54:58 +0100 Message-ID: Subject: Re: [PATCH] sh: mach-x3proto: Add missing #include From: John Paul Adrian Glaubitz To: Geert Uytterhoeven , Linus Walleij , Andy Shevchenko Cc: Yoshinori Sato , Rich Felker , linux-gpio@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Kernel Functional Testing Date: Thu, 09 Mar 2023 14:54:56 +0100 In-Reply-To: <20230309135255.3861308-1-geert+renesas@glider.be> References: <20230309135255.3861308-1-geert+renesas@glider.be> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 77.188.3.23 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert! On Thu, 2023-03-09 at 14:52 +0100, Geert Uytterhoeven wrote: > shx3_defconfig: > > arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’: > arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’ > 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i; > | ^ > > Reported-by: Linux Kernel Functional Testing > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy consumer-only") > Signed-off-by: Geert Uytterhoeven > --- > arch/sh/boards/mach-x3proto/setup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/boards/mach-x3proto/setup.c b/arch/sh/boards/mach-x3proto/setup.c > index 95b85f2e13dda75b..7f39fca95e57a109 100644 > --- a/arch/sh/boards/mach-x3proto/setup.c > +++ b/arch/sh/boards/mach-x3proto/setup.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include Thanks. You were much faster than me. I didn't even have the time to have a look at the problem yet ;-). Is it sufficient to pick this up for 6.4? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913