From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Jorge Lopez <jorgealtxwork@gmail.com>
Cc: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 00/13] HP BIOSCFG driver
Date: Mon, 8 May 2023 22:42:02 +0200 [thread overview]
Message-ID: <a1f87dd8-6547-4d6d-9fc8-d7986d9e2c93@t-8ch.de> (raw)
In-Reply-To: <CAOOmCE_DMb6ejprALCfmWa0eA3WQquFnS+Z3D0TjsqqPiytbQw@mail.gmail.com>
On 2023-05-08 09:05:22-0500, Jorge Lopez wrote:
> On Sat, May 6, 2023 at 1:57 AM Thomas Weißschuh <thomas@t-8ch.de> wrote:
> >
> > On 2023-05-05 17:00:30-0500, Jorge Lopez wrote:
> > <snip>
> >
> > > Jorge Lopez (13):
> > > HP BIOSCFG driver - Documentation
> > > HP BIOSCFG driver - biosattr-interface
> > > HP BIOSCFG driver - bioscfg
> > > HP BIOSCFG driver - int-attributes
> > > HP BIOSCFG driver - ordered-attributes
> > > HP BIOSCFG driver - passwdobj-attributes
> > > HP BIOSCFG driver - string-attributes
> > > HP BIOSCFG driver - bioscfg-h
> > > HP BIOSCFG driver - enum-attributes
> > > HP BIOSCFG driver - spmobj-attributes
> > > HP BIOSCFG driver - surestart-attributes
> > > HP BIOSCFG driver - Makefile
> > > HP BIOSCFG driver - MAINTAINERS
> >
> > These could be reordered a bit to be easier to read.
> >
> > * Documentation
> > * bioscfg-h
> > * bioscfg
> > * biosattr-interface
> > * *-attributes
> > * Makefile
> > * MAINTAINERS
> >
>
> the order is determined when a particular commit took place and as
> reported by git.
> I will reorder the list in the cover-letter in future submissions.
The commits should be ordered in a way that make the most sense.
This should indeed match the order of commits/patches, you could reorder
the commits to match the proposed order.
> > Also currently the subject spacing is currently inconsistent.
> > Something like "hp-bioscfg: foo" would be more in line with the rest of
> > the kernel.
> >
>
> Noted. I will update the subject spacing as indicated. "hp-bioscfg: foo"
>
> > >
> > > .../testing/sysfs-class-firmware-attributes | 117 ++-
> > > MAINTAINERS | 6 +
> > > drivers/platform/x86/hp/Kconfig | 16 +
> > > drivers/platform/x86/hp/Makefile | 1 +
> > > drivers/platform/x86/hp/hp-bioscfg/Makefile | 12 +
> > > .../x86/hp/hp-bioscfg/biosattr-interface.c | 319 ++++++
> > > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 982 ++++++++++++++++++
> > > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 523 ++++++++++
> > > .../x86/hp/hp-bioscfg/enum-attributes.c | 482 +++++++++
> > > .../x86/hp/hp-bioscfg/int-attributes.c | 448 ++++++++
> > > .../x86/hp/hp-bioscfg/ordered-attributes.c | 443 ++++++++
> > > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 584 +++++++++++
> > > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 381 +++++++
> > > .../x86/hp/hp-bioscfg/string-attributes.c | 415 ++++++++
> > > .../x86/hp/hp-bioscfg/surestart-attributes.c | 133 +++
> > > 15 files changed, 4860 insertions(+), 2 deletions(-)
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c
> > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
> > >
> > > --
> > > 2.34.1
> > >
next prev parent reply other threads:[~2023-05-08 20:42 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 22:00 Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 01/13] HP BIOSCFG driver - Documentation Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 02/13] HP BIOSCFG driver - biosattr-interface Jorge Lopez
2023-05-08 14:31 ` Ilpo Järvinen
2023-05-08 20:59 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 03/13] HP BIOSCFG driver - bioscfg Jorge Lopez
2023-05-08 15:26 ` Ilpo Järvinen
2023-05-05 22:00 ` [PATCH v12 04/13] HP BIOSCFG driver - int-attributes Jorge Lopez
2023-05-08 14:45 ` Ilpo Järvinen
2023-05-08 21:33 ` Jorge Lopez
2023-05-09 10:24 ` Ilpo Järvinen
2023-05-10 19:01 ` Jorge Lopez
2023-05-08 21:16 ` Thomas Weißschuh
2023-05-09 21:23 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 05/13] HP BIOSCFG driver - ordered-attributes Jorge Lopez
2023-05-08 21:35 ` Thomas Weißschuh
2023-05-09 22:17 ` Jorge Lopez
2023-05-09 13:15 ` Ilpo Järvinen
2023-05-10 20:29 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 06/13] HP BIOSCFG driver - passwdobj-attributes Jorge Lopez
2023-05-09 12:34 ` Ilpo Järvinen
2023-05-10 20:10 ` Jorge Lopez
2023-05-11 9:09 ` Ilpo Järvinen
2023-05-11 13:52 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 07/13] HP BIOSCFG driver - string-attributes Jorge Lopez
2023-05-09 13:18 ` Ilpo Järvinen
2023-05-10 20:35 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 08/13] HP BIOSCFG driver - bioscfg-h Jorge Lopez
2023-05-06 7:15 ` Thomas Weißschuh
2023-05-08 15:36 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 09/13] HP BIOSCFG driver - enum-attributes Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 10/13] HP BIOSCFG driver - spmobj-attributes Jorge Lopez
2023-05-09 13:48 ` Ilpo Järvinen
2023-05-10 21:56 ` Jorge Lopez
2023-05-11 9:23 ` Ilpo Järvinen
2023-05-15 14:12 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 11/13] HP BIOSCFG driver - surestart-attributes Jorge Lopez
2023-05-09 13:57 ` Ilpo Järvinen
2023-05-10 22:13 ` Jorge Lopez
2023-05-11 9:32 ` Ilpo Järvinen
2023-05-12 13:54 ` Jorge Lopez
2023-05-12 14:12 ` Ilpo Järvinen
2023-05-12 15:34 ` Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 12/13] HP BIOSCFG driver - Makefile Jorge Lopez
2023-05-05 22:00 ` [PATCH v12 13/13] HP BIOSCFG driver - MAINTAINERS Jorge Lopez
2023-05-06 6:57 ` [PATCH v12 00/13] HP BIOSCFG driver Thomas Weißschuh
2023-05-08 14:05 ` Jorge Lopez
2023-05-08 20:42 ` Thomas Weißschuh [this message]
2023-05-08 20:48 ` Jorge Lopez
2023-05-08 20:57 ` Thomas Weißschuh
2023-05-08 21:02 ` Jorge Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f87dd8-6547-4d6d-9fc8-d7986d9e2c93@t-8ch.de \
--to=thomas@t-8ch.de \
--cc=hdegoede@redhat.com \
--cc=jorgealtxwork@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®