From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943BE2E40E for ; Wed, 28 Jan 2026 04:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769572994; cv=none; b=acv9DDpCOHXiZNYsLeXbFHV2VazBpL4ert3pMqydM+RHOw38N3f+B0brYMCrWYSswD8Wo47Id8IvnNkb3IrvENpdlTAZqM+EHDqrs2CKiJECNEQezzGytQaZPDPzJYh6PLU73LElgQ3wKk5qPt/01dopyeQg0jWs+m/cx9TJGVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769572994; c=relaxed/simple; bh=kB8xsjBTb/gFKpjEArBn86GeVi12fURxDbiZebCBmFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=avJFJVNQtO/h5pxT3fJNnTaZQvHF979gHP01jHBntaT53S4PQ8HlTmEzJ/DbfiR7RfE8RM/CLAJqR67CkC23tJoD4xD02Y0Uzp+yW/JVxF3wED/bd1QWdG7wRT2JmQ4tG1Zky2qzbCoG9RNljxasNlsg9uPvA7kbE+j6YiToTXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vdr9VO0s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AjPgLQfz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vdr9VO0s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AjPgLQfz" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60RNHeug2973472 for ; Wed, 28 Jan 2026 04:03:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MUoswFlJ+yiIr8sXirOxgbmRv5wfMSzY+cd2zV55w+o=; b=Vdr9VO0sywE/pNOl cvkUInN2H/mY+ukQm+6Te9BjAS9eIS6Clv94KXYjt80lk8CESFHoi+tAuzd44KFF VZyO+qJcIqwkl/Ss03/kVgfVyc8WZgOOF8KiqsDUIHA1kpgvXAcjTqKbFzdpd/XD ZrlM3PDxGbrmVVYZjkZtApcpO5THE/FyXZAfEwXvpF0Dv/OXxf9lsjifLue+s1kF s2QS78uBaSscwvHcDnbDUOYbnLrMkHP3U3S+FAnndVEeP2kO4FpqB69nFZU2MlL2 G3d0YecyOCG7SYawKbZskcVy6VgS0dU4HYFmJTRy7Zzx8UlMJEEe97fVTg5ovmX7 Fc2R4g== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by355sf46-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 04:03:12 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2b74766fae7so5363937eec.0 for ; Tue, 27 Jan 2026 20:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769572992; x=1770177792; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MUoswFlJ+yiIr8sXirOxgbmRv5wfMSzY+cd2zV55w+o=; b=AjPgLQfzp+wg7nGNRZZVjOdc80e3+c3KjneAHSAcPhxmoXIKCYud0r8Q54N4PmeYlW 5NifFYN/YpDNkvQas2J0cemBeu2LH4VNfcrfBEhEk6EkzNuM6FAsYlKcDXeSRDo1CZl0 V1G1AjmzDBVkRWW/01CEtmOcPpZUhSZxppPYD0+aKOu+Afysy91ZUGB/xCBznfy5g+sv Yq7mFmREE68jQm6RMxKRYwhUcwZcVg4EjBTwTh7ODKlZoElVxHPdIpN7KmFa9Ivlyhbn wk7ZwFCvRmU6dh/UVZdp7k10HZT/hbiB1z7W3+tdDvtMrJ0+w2UzyuR+lLHfzFE4mRu/ JKyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769572992; x=1770177792; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MUoswFlJ+yiIr8sXirOxgbmRv5wfMSzY+cd2zV55w+o=; b=jfOZO56wztkLKtvEz+fl4olB6peMxZWUoI4jTZoK6eLufp1qoIxlIR6wm/KIxdalw3 M+pIpomdAulsFPcok4CgRoJbWDyYbSlRbbBl09zcQTTXyejXVs/7Uhsonx9Y5uxPNKn6 2AOtq6Rq9topCFcC3bwqroijb7GarJYGK5hwxjgrtlDqcKoVW4PY4VueP8TzZTGd0Gtf vtRhLyk/t6aKGAcD7zhQguqMT0PhSg9yirfkJg2Gg9gx7aHxtKpy40uIP9mxRPAdDz9R dvRoCTfPTkHTmJv+JPjCy7CCzHToRbAQ9PyrVMPqgMfD/AoEFLQ6yYzgmKEZbEwienO2 fJrw== X-Forwarded-Encrypted: i=1; AJvYcCUZvDkmkoF6h60tTJ2AzTkSOu8ipwGE1iiJ/NAJe+sVLVug82NCA4GbmNi78KJaZjNags7aGJ7cy0jRdQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxPsjpYwUtF1/Qg9HBRXPMwR2t1BEjYclxu0Cki3CM+xqNCrUBQ XhwQcr9i2gljpROvGrG6fSbl4ovXv+RSJu/ecgjW8R5FXRC47jZAQ1sawlxNL9CWBJKfpCEf6fN ANjv2Em3rddyU0r1NK3SGmV2rb81gZMX98rwKsXfzyZgPMVJ4u8o9o348CwSB2pZvFuA= X-Gm-Gg: AZuq6aK/xfCifKJxBqeTT5vTW1FHkhDlvGxNmTvJ9CMkJJGwwsjwKDCfdKBOJJzwO9R wFbGmFEwJmVf3SPxTmXCiwG/YL/OhqTqebfUGgaDs9NEwCHIYolcI81S8JWyee4wrl1O2+5uD5X nfyOa3HU/gaz/yWJlFrzljfxFTks3XumCA4tektPvsP54wGtAWf7nDje+96HyhqwFC2FzjkSbiN xX8YJbKsWQsm+ejZ+fyHsmDaEt52w/Eo5eDqT2b9L93oy7L3ZwZVjzcIWIs6cXgcZBdCmwWMDHn CKesTVZ7GteAljnDDXq2Nx5jqQr6Uumzcn2XRDu9eXFxu7jPFNnUX/5dRCWHnv2sv7j/0MLftlx H8Rqbh3BkO5AIo0ovlqJncxwU9CJGOGXK9WhyFVeG/7weYW4rL1bUgZzFQBKFr6KQ X-Received: by 2002:a05:7300:8c9f:b0:2ab:ca55:89c6 with SMTP id 5a478bee46e88-2b78da3eea0mr2595601eec.41.1769572991943; Tue, 27 Jan 2026 20:03:11 -0800 (PST) X-Received: by 2002:a05:7300:8c9f:b0:2ab:ca55:89c6 with SMTP id 5a478bee46e88-2b78da3eea0mr2595561eec.41.1769572991167; Tue, 27 Jan 2026 20:03:11 -0800 (PST) Received: from [10.110.57.207] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a1af88c4sm976319eec.31.2026.01.27.20.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 20:03:10 -0800 (PST) Message-ID: Date: Wed, 28 Jan 2026 12:03:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 To: Luiz Augusto von Dentz , Dmitry Baryshkov Cc: Bartosz Golaszewski , Marcel Holtmann , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, shuai.zhang@oss.qualcomm.com, cheng.jiang@oss.qualcomm.com, chezhou@qti.qualcomm.com, wei.deng@oss.qualcomm.com, yiboz@qti.qualcomm.com References: <20260126162444.4194293-1-mengshi.wu@oss.qualcomm.com> <20260126162444.4194293-3-mengshi.wu@oss.qualcomm.com> <7b9fec28-2272-4ff7-9575-76e72cecada5@oss.qualcomm.com> Content-Language: en-US From: Mengshi Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=YNWSCBGx c=1 sm=1 tr=0 ts=69798a80 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=jLO2Fxiw5Y3_fRslxeUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-ORIG-GUID: frYhzg4twMWziOEBC678Mc8Hjra3qWcf X-Proofpoint-GUID: frYhzg4twMWziOEBC678Mc8Hjra3qWcf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDAyOSBTYWx0ZWRfX5sSd0uUonzpm I/gJgUihHDjIBTUHzJhtPUWly2YR5IIvCvRF7ly9zLxkw72t5U8bzt4jd7LowMf4RZ1P9BJBZW8 godZlqAGgL9XwYBFsXyeZgE72NhO3V8pIadXijvZ2I/8aqf0XoCIJH+Likja1P1OKnJMAPJzBsl Ygw9Hhh1QTJHe8752A+UGWHvDwa5nnbwCRTfzmc3Bgz/JZZT5Xlmnj9qz9IQ/Jc2HMR9e4cJckn sj112zGUzsz0/DIHlAb+5kxtcfp+j+ufg/m610LTcfpOJaSfR+2MZXc4Bf35NT+r/aa0TeXUyCM XQsymWW3EY4z9zgx+gzNYgiNXaRljdQAvJ8JK6Q/8h9OR79RBfVN8zSC2EwcFARYx8tyHcH/+Ia K3HRQzcRtnhxPZNzmpSlQs7/DsXgUYkDvHS8BsGsGnUZMZMZ3DlS0R0sJ/KlkW7VPUdPjRdSW7Z TivD9UQpcqYxSUemjqQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_05,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280029 Hi, On 1/27/2026 11:47 PM, Luiz Augusto von Dentz wrote: > Hi, > > On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov > wrote: >> >> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: >>> >>> >>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: >>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: >>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device >>>>> data structures to enable Hands-Free Profile (HFP) hardware >>>>> offload support on these Qualcomm Bluetooth chipsets. >>>>> >>>>> Signed-off-by: Mengshi Wu >>>>> --- >>>>> drivers/bluetooth/hci_qca.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>> >>>> Any other chips which would benefit from this flag? If you are setting >>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be >>>> set for WCN6750? >>>> >>> >>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not >>> considered at this time. >> >> What does it mean? It either supports HFP ofload, or not. Does it? > > Or does that mean offload is considered the default over HCI, and in > that case does it actually work with the likes of Linux > distros/Pipewire or it is Android only? The fact that it is mentioning > HFP rather than SCO is already concerning to me, the kernel driver > shouldn't be involved with profile layers other than core. > > Offload over HCI is the default way in most cases, but I don't mean it here. Offload over non-HCI ways (such as I2S, Slimbus) need other supports from software aspect, but these supports are not ready for other chips yet. I use HFP because I noticed that it was used before, like qca_configure_hfp_offload(). Should I change to use SCO if HFP is not proper here? >> >> -- >> With best wishes >> Dmitry > > >