From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61DDC2DFA4A for ; Fri, 12 Jun 2026 03:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781233260; cv=none; b=HSy8U8BhymZeg12fXx9Hguk57UdtkobqSOIEti0xrDRCjpe8DgJEkt69WJtlAhlSTJZ9towELLkJVPx/xAhOvNTEH1QqQ8Qar8DK5PdEKx8GrnaMuWxQ6Ugt+DWIgyyzsuyMp3xqwIE+XDHVwpR/PT6/1WB1ejYbXoFAYkIFKvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781233260; c=relaxed/simple; bh=ejqs2vcPR76zBzb0TQ0RAYoHipYbI5Sn6UDxEfajQPM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fh0bMvnwvC+Es+thGtM1DYHDtwQ3qxvN8zfJWdmqJRJzXhnkmTBiQ/eMz/9ZXHnD1VkfWwE5Gj5vw1oEBWK5o/+BdbJ1d7LslFXBVbjS3d2hz82e2TWbfAYQrrDRCjiYkN5+hkUlNi6aogCVJXa8wqtibMVra2Ov9dZMvY6Wfn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K01hXvlt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B+Tb5jwB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K01hXvlt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B+Tb5jwB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BMVKe81920882 for ; Fri, 12 Jun 2026 03:00:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ohkNRy/pAe7gT67/lP8i9MPg3N+KSvVizD9FWIPxTu8=; b=K01hXvltaUDbj+I6 zW5lIvcJFDTCNCWE32dGadxFsR9NDoDyqOlzpFz/Tmd9nM9Rr5xWEf0PJhONg+zq hxavEzpTLLER3cP637G6CVJGxUAq4ZL7zSUjNy8PSkwp7T10kKvFV+2eznKb97Ye c+/+V11SIVbRkGkyQvlgvipZG/G5laNQj7sB8VQPVT7Pe0voauczyjJpgnFH+GO9 AuB/BZn+ZOKlaxaTlERO5VLlriq11h+7pvDwZZYtI9AQkluNtHeRQemeFbtme4Dl prztOlg3MloIXo0TAe7+4+CaS6USOrC3qyDgMrWa2xb9seKTEiDpR7RLSzq9bTlQ t0TH4Q== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1cbhw4r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 03:00:58 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84240b58211so395054b3a.1 for ; Thu, 11 Jun 2026 20:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781233257; x=1781838057; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ohkNRy/pAe7gT67/lP8i9MPg3N+KSvVizD9FWIPxTu8=; b=B+Tb5jwBM7DZg65x7Nkr6HlSzFsLn34ymqZwMTPuAAA9j+LCKJKffl7vEHmpjiZtYJ DPERedx1j0Zu8MF6LUd8Z4ZAguQCLV3CWQIMZA537lAWAOVnL+kP2JNjWWSBwsFOU0eP 3e3BDsLzD6PV67g5rCACK6jMAyUT6jo3NFciwDai8A0k/mi0xzOnYaWumRjaXeSjZ+1w 9jVERL+yNMELR365d1vm1y6MRtUcuZrbgkNcCqAe0kDDrGvhH6cl/BufzZKyvQ/mKOMO ms2+KZuaTpr7txMZkZkhZM+rZklYrMkXLwAethAumblpeuClfbnPAwpNrUiXlTk4NYRA Ekdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781233257; x=1781838057; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ohkNRy/pAe7gT67/lP8i9MPg3N+KSvVizD9FWIPxTu8=; b=BYiHHKM+DYlX8tk9WiUMXQToPZOAaVeF42mUcGlF+EUp/vwgUEoLyzwdL/4+1xP0tY VQmoBfFB+assXfV5hnThwjLLO8jWGxOJH5B00avXwQAkeZsRnqVC+IQpzts5Ub2lXfgg eY3iBmvP8MOoNf3HqNklUS9j4Dzs4RUrIgWUEa3qiyiPOk8UQ5VyGl4PzA3OCpmK+4qO MVZ9H3xbctHShhXAOaBfeWCwoolbXz4e6+z1v/8PYWmaYQDmknBeG0MlltUj3k266Z6A 7Z/DcwXb0ev20Otdt3Ztm6v98zyJtsel878y1TDIEUTb0xIxgYMa0+PXyJOh/9BxUvAO 0wag== X-Forwarded-Encrypted: i=1; AFNElJ9N7salx2SEyG1me7eVvdBFoi35JCv6NtP3Kq3+P+TQMZXjsw0Bxdnt6RJaeDp4xB/+ojNA67eQy4eyKK4=@vger.kernel.org X-Gm-Message-State: AOJu0YxpE0pX+WQUusbRbuP63JQre0f18kcmOoqxE+3zGgZhjH4a7Do/ jC6nUVk6Zv/wJNF6k01XMqu2Kc4kR4pXRl1oDps0AX9yyShEVIGjhC2FSGPnW4loaLd4KYtFM9k Hda3QUCUyb+dM1ceq8OOyvUnGS/amIbqagxQU6LGskwmnpD/Xj1v9/k+KL6ISEPYU3pE= X-Gm-Gg: Acq92OG9SEf0yFXKSrEgYmRriqEcpRrlsvDskHu8IOngMzZQt3pDQr/iyoXoyRFhP92 LV+44Hb5sIf2UdhPwWUekYN8m1ct+JL9n3+5T22ugAllwFsInrm71T7XC36iSBVrGxcxo/ziHiF SFeC6H6OwZPlenQWqWGDYfV0VHOwrjQqBi4V7+1+nWxNYS18FZ3qrygI5tSyQw1KXpeOdhcnYjB ke1sYUTTDlXRwUsYWsIlY0w61ACUJKC+a0yQ6laZkyavIljSBQ1500kd7+NrjDYPnFQ/MacrT9Q 73jLIuK8+zgIbjqplitdQY8EN1wiKM/sZxCvoOBHmFypliovmu6btE2tHrGXpRO6DwHoZFOzby9 SonOpk5Swsd4cZaW3GyngheVa3LcPKxbfQGovg4f5mdOna2PdDMiGJw605Kpbn2g= X-Received: by 2002:a05:6a00:1391:b0:82a:5d55:5807 with SMTP id d2e1a72fcca58-8434cb01ac7mr914531b3a.6.1781233257137; Thu, 11 Jun 2026 20:00:57 -0700 (PDT) X-Received: by 2002:a05:6a00:1391:b0:82a:5d55:5807 with SMTP id d2e1a72fcca58-8434cb01ac7mr914476b3a.6.1781233256700; Thu, 11 Jun 2026 20:00:56 -0700 (PDT) Received: from [192.168.1.8] ([122.164.81.0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434acd96d8sm592157b3a.19.2026.06.11.20.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 20:00:56 -0700 (PDT) Message-ID: Date: Fri, 12 Jun 2026 08:30:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC To: Dmitry Baryshkov Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260611-ipq9650_refgen-v2-0-d96a91d5b99e@oss.qualcomm.com> <20260611-ipq9650_refgen-v2-3-d96a91d5b99e@oss.qualcomm.com> <367u4tqrx4wkwepm3pwlbdbqhsquilhmloxkzugvgmzk2iw6dw@ul25u2ynoyzn> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: <367u4tqrx4wkwepm3pwlbdbqhsquilhmloxkzugvgmzk2iw6dw@ul25u2ynoyzn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: EZat6u0ozAvbeLWyX--EDFiwFrZ8J20y X-Proofpoint-ORIG-GUID: EZat6u0ozAvbeLWyX--EDFiwFrZ8J20y X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDAyNSBTYWx0ZWRfX2yrRl2AtArTu kE+aaUIbjxlNMQjAxV1Yta5x+cXNSkPxIFOnYf040Ss9mfL6SuFpnpa0EEoYHM4tQq/o4AsgO73 QtEmXSdDOBUR5GZ40OiF+DUzVWZhxhE= X-Authority-Analysis: v=2.4 cv=S57pBosP c=1 sm=1 tr=0 ts=6a2b766a cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=DVNErGSwdtF8OHn2hLoakQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Is6qsO8886F9CyN_g2gA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDAyNSBTYWx0ZWRfX9iDoJvJwD7CE DQDZc5iMDo+b8QmKjSbU5OLa4hZMDojrl+b6ViKVzkETg/gkvoSP5H+P8AfnKbrNsMXQzPsUTcb 0vDM/u6Z/uXF8D4e2gPOPkmxpxY4hsZKm0CbO+sVets3LBkPASc6djNSkNBjy2ehxBcj+eNSWMY h1JeTDcLhJV7bZVX9pKNTWPyK4frpx0c+plIiFMoS8j6xQT7XjlAZx9D6j0tXCxALKjCl6x1pBY YXBL4HMxkX3IPcZAVJLkOCWX4qnQL9c9jznBBXsxUZZyAhR0mgO+K5HpXYFGTGq6rQux1X0A6bf DpeQusxlASAU7BnAVlSvV3dOrCPgn9QVbQMsfC3plAJwHEYob6hwJOH51WN3y2bdK8q82kt+bDb dSEy1mdBcYlhkO0x+dCEZLK1nuY7JkvG7IAsWYFjRv3jvxS30iApaeEtKJSlUjwRnfW6na90ymR VrfCA/Wro4zkL8ipplg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_05,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120025 On 6/12/2026 6:26 AM, Dmitry Baryshkov wrote: > On Thu, Jun 11, 2026 at 02:33:18PM +0530, Kathiravan Thirumoorthy wrote: >> IPQ9650 SoC has 2 REFGEN blocks providing the reference current to the >> PCIe and USB, UNIPHY PHYs. For the other SoCs, clocks for this block is >> enabled on power up but that's not the case for IPQ9650 and we have to >> enable those clocks explicitly to bring up the PHYs properly. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> drivers/regulator/qcom-refgen-regulator.c | 89 +++++++++++++++++++++++++++++-- >> 1 file changed, 85 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/regulator/qcom-refgen-regulator.c b/drivers/regulator/qcom-refgen-regulator.c >> index 6a3795469927..e8821f159ff1 100644 >> --- a/drivers/regulator/qcom-refgen-regulator.c >> +++ b/drivers/regulator/qcom-refgen-regulator.c >> @@ -3,6 +3,7 @@ >> // Copyright (c) 2023, Linaro Limited >> >> #include >> +#include >> #include >> #include >> #include >> @@ -16,6 +17,10 @@ >> #define REFGEN_BIAS_EN_ENABLE 0x7 >> #define REFGEN_BIAS_EN_DISABLE 0x6 >> >> +#define REFGEN_REG_REFGEN_STATUS 0xC > Lowercase hex, please. Ack. > > With that fixed: > > > Reviewed-by: Dmitry Baryshkov Thanks! > > > >> +#define REFGEN_STATUS_OUT_MASK BIT(3) >> + #define REFGEN_STATUS_OUT_ENABLE 0x8 >> +