From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lukasz Luba <l.luba@partner.samsung.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: b.zolnierkie@samsung.com, krzk@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, kyungmin.park@samsung.com,
m.szyprowski@samsung.com, s.nawrocki@samsung.com,
myungjoo.ham@samsung.com, kgene@kernel.org,
willy.mh.wolff.ml@gmail.com
Subject: Re: [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos
Date: Tue, 30 Apr 2019 13:56:23 +0900 [thread overview]
Message-ID: <a1ff3566-6117-b670-a2f3-b60a2bbec14a@samsung.com> (raw)
In-Reply-To: <1555681688-19643-2-git-send-email-l.luba@partner.samsung.com>
Hi,
I agree of this patch. But, I add the minor comments.
If you edit them according to my comment, feel free to add my following tag:
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
On 19. 4. 19. 오후 10:48, Lukasz Luba wrote:
> This patch add support of a new feature which can be used in DT:
> Performance Monitoring Unit with defined event data type.
> In this patch the event data types are defined for Exynos PPMU.
> The patch also updates the MAINTAINERS file accordingly and
> adds the header file to devfreq event subsystem.
>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> MAINTAINERS | 1 +
> include/dt-bindings/pmu/exynos_ppmu.h | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+)
> create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3671fde..1ba4b9b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4560,6 +4560,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git
> S: Supported
> F: drivers/devfreq/event/
> F: drivers/devfreq/devfreq-event.c
> +F: include/dt-bindings/pmu/exynos_ppmu.h
> F: include/linux/devfreq-event.h
> F: Documentation/devicetree/bindings/devfreq/event/
>
> diff --git a/include/dt-bindings/pmu/exynos_ppmu.h b/include/dt-bindings/pmu/exynos_ppmu.h
> new file mode 100644
> index 0000000..08fdce9
> --- /dev/null
> +++ b/include/dt-bindings/pmu/exynos_ppmu.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Samsung Exynos PPMU event types for counting in regs
> + *
> + * Copyright (c) 2019, Samsung
Mabye, "Samsung Electronics" instead of 'Samsung'.
> + * Author: Lukasz Luba <l.luba@partner.samsung.com>
> + */
> +
> +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H
> +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H
> +
> +
Remove unneeded blank line.
> +#define PPMU_RO_BUSY_CYCLE_CNT 0x0
> +#define PPMU_WO_BUSY_CYCLE_CNT 0x1
> +#define PPMU_RW_BUSY_CYCLE_CNT 0x2
> +#define PPMU_RO_REQUEST_CNT 0x3
> +#define PPMU_WO_REQUEST_CNT 0x4
> +#define PPMU_RO_DATA_CNT 0x5
> +#define PPMU_WO_DATA_CNT 0x6
> +#define PPMU_RO_LATENCY 0x12
> +#define PPMU_WO_LATENCY 0x16
> +#define PPMU_V2_RO_DATA_CNT 0x4
> +#define PPMU_V2_WO_DATA_CNT 0x5
> +#define PPMU_V2_EVT3_RW_DATA_CNT 0x22
> +
> +#endif
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-04-30 4:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190419134818eucas1p1d121f99f6c018c27254f0af8cab5ea64@eucas1p1.samsung.com>
2019-04-19 13:48 ` [PATCH v3 0/4] Exynos Performance Monitoring Counters enhancements Lukasz Luba
[not found] ` <CGME20190419134820eucas1p154e839769af0e1b8bae17ce3efa0ba93@eucas1p1.samsung.com>
2019-04-19 13:48 ` [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos Lukasz Luba
2019-04-30 4:56 ` Chanwoo Choi [this message]
2019-04-30 20:36 ` Lukasz Luba
2019-04-30 22:33 ` Rob Herring
2019-05-02 9:16 ` Lukasz Luba
[not found] ` <CGME20190419134821eucas1p2461a27e28387ff2b87c149f09582d2a0@eucas1p2.samsung.com>
2019-04-19 13:48 ` [PATCH v3 2/4] drivers: devfreq: events: extend events by type of counted data Lukasz Luba
2019-04-30 7:34 ` Chanwoo Choi
2019-04-30 21:19 ` Lukasz Luba
2019-05-02 1:25 ` Chanwoo Choi
2019-05-02 9:07 ` Lukasz Luba
[not found] ` <CGME20190419134822eucas1p29c6eff0f500311749b33c4f556123cf0@eucas1p2.samsung.com>
2019-04-19 13:48 ` [PATCH v3 3/4] Documentation: devicetree: add PPMU events description Lukasz Luba
2019-04-30 6:16 ` Chanwoo Choi
2019-04-30 21:23 ` Lukasz Luba
2019-05-02 10:11 ` Lukasz Luba
2019-04-30 22:36 ` Rob Herring
2019-05-02 8:52 ` Lukasz Luba
2019-05-02 20:24 ` Rob Herring
2019-05-06 10:29 ` Lukasz Luba
2019-05-07 9:05 ` Lukasz Luba
2019-05-07 16:50 ` Rob Herring
2019-05-08 8:28 ` Lukasz Luba
[not found] ` <CGME20190419134823eucas1p1ff852194b1db655ed2dbce72b5f7f3a6@eucas1p1.samsung.com>
2019-04-19 13:48 ` [PATCH v3 4/4] DT: arm: exynos4412: add event data type which is monitored Lukasz Luba
2019-04-30 6:10 ` Chanwoo Choi
2019-04-30 21:24 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1ff3566-6117-b670-a2f3-b60a2bbec14a@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.luba@partner.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®