From: Rik van Riel <riel@surriel.com>
To: Jann Horn <jannh@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Fix flush_tlb_range() when used for zapping normal PMDs
Date: Fri, 03 Jan 2025 16:55:25 -0500 [thread overview]
Message-ID: <a1fff596435121b01766bed27e401e8a27bf8f92.camel@surriel.com> (raw)
In-Reply-To: <20250103-x86-collapse-flush-fix-v1-1-3c521856cfa6@google.com>
On Fri, 2025-01-03 at 19:39 +0100, Jann Horn wrote:
> 02fc2aa06e9e0ecdba3fe948cafe5892b72e86c0..3da645139748538daac70166618d
> 8ad95116eb74 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -242,7 +242,7 @@ void flush_tlb_multi(const struct cpumask
> *cpumask,
> flush_tlb_mm_range((vma)->vm_mm, start,
> end, \
> ((vma)->vm_flags &
> VM_HUGETLB) \
> ?
> huge_page_shift(hstate_vma(vma)) \
> - : PAGE_SHIFT, false)
> + : PAGE_SHIFT, true)
>
>
The code looks good, but should this macro get
a comment indicating that code that only frees
pages, but not page tables, should be calling
flush_tlb() instead?
--
All Rights Reversed.
next prev parent reply other threads:[~2025-01-03 21:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 18:39 Jann Horn
2025-01-03 21:55 ` Rik van Riel [this message]
2025-01-03 22:11 ` Jann Horn
2025-01-04 3:09 ` Rik van Riel
2025-01-06 13:25 ` Jann Horn
2025-01-22 10:33 ` Peter Zijlstra
2025-02-03 12:50 ` [tip: x86/mm] " tip-bot2 for Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1fff596435121b01766bed27e401e8a27bf8f92.camel@surriel.com \
--to=riel@surriel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®