From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DADC433B4 for ; Fri, 16 Apr 2021 12:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62A8861184 for ; Fri, 16 Apr 2021 12:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241701AbhDPMMm (ORCPT ); Fri, 16 Apr 2021 08:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbhDPMMh (ORCPT ); Fri, 16 Apr 2021 08:12:37 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F3AC061574 for ; Fri, 16 Apr 2021 05:12:13 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id f15so18691699iob.5 for ; Fri, 16 Apr 2021 05:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QRWAPmW5vvyXZA3k3epSuvNabZYcpW8oDtvws6ZLKbA=; b=UplxDcY1zQ2EymDQcSIbvMLZOmcYU+jYX9/g74rwXA5evWnhYH2I9jwlXZbhmKe7Uh BBL/g4ZhSoQxAKX6VGDn/XV7n1XMaw6imZ9hdGoNH7UWlZGIK5x8DpzwiAJwTdc1K+kl EZm6mITn17YLMUY775amwjKD5aBATgC6P+giA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QRWAPmW5vvyXZA3k3epSuvNabZYcpW8oDtvws6ZLKbA=; b=hvn31M34d5SKZyENIFks+lmnGT/J36y2t+Rod6HqILi7ZKEIqD8s+QyJg0xvXaFZo8 sU0L7uIzn2QNo7qFchNLCxwgOEhdlxIiNMa+2qNBFU7KDTSxf47wgZ1qnptWgcHJe5QZ uNzJ8/mpsulQW6kSW9kYzBFPIzMvZ5VzTXIKwOcQKpdmFp+ixGHqtk221Hzj1EzvNcTh fWiKuwZ8bfDwemKjundrPja8S/OrHAXB4rGj/Hz1C/No3SPes5WGni9/kKvrqLyY8SGb O8jgdalKfGFiM1boieJd5rVAkNxVFrstZrF8BxNvuuELnH18PXebe6jsUnO37GI2xCGg K+qQ== X-Gm-Message-State: AOAM531yPlMH/n39bk6L25RDld0Kip05l17XnUzq6cbNec/wtf+x152E 3Ji8/XtjXAGvBzLUpOrx7CpJVy1ar8XNUg== X-Google-Smtp-Source: ABdhPJzonT2xqujZWT52oa9/fLNipZhY74sU/pHLYeFmZAfsUf5mQYtA00rRFIFW13DMjp/348GLWw== X-Received: by 2002:a05:6638:1390:: with SMTP id w16mr3705553jad.83.1618575132189; Fri, 16 Apr 2021 05:12:12 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id s1sm308665iov.52.2021.04.16.05.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 05:12:11 -0700 (PDT) Subject: Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler To: zhuguangqing83@gmail.com, Alex Elder , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210416034007.31222-1-zhuguangqing83@gmail.com> From: Alex Elder Message-ID: Date: Fri, 16 Apr 2021 07:12:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416034007.31222-1-zhuguangqing83@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/15/21 10:40 PM, zhuguangqing83@gmail.com wrote: > From: Guangqing Zhu This is not required here. -Alex https://lore.kernel.org/netdev/d57e0a43-4d87-93cf-471c-c8185ea85ced@ieee.org/ > Coccinelle noticed: > drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu > --- > drivers/net/ipa/ipa_smp2p.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c > index a5f7a79a1923..74e04427a711 100644 > --- a/drivers/net/ipa/ipa_smp2p.c > +++ b/drivers/net/ipa/ipa_smp2p.c > @@ -183,7 +183,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name, > } > irq = ret; > > - ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p); > + ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT, > + name, smp2p); > if (ret) { > dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name); > return ret; >