From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED0D199385; Tue, 4 Nov 2025 15:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762271231; cv=none; b=b4sz6JbkhpFbpE5kUzPc1AcK+0sV1pKMqmEU/cFmRrDwVrfzHZ7Nr8jI9XkGF6gEPn67Ms3nIkGwG8I8euAZ/3SDPxAdqdGyp6xIaPkalEPIPTQbOiJ1620PBuQl5blgMCyX+z2WlVkHEnAryX7m4MAzLdtLYuTsIrWg7OqGz4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762271231; c=relaxed/simple; bh=YNHMR9Jla3bG3jY/KBByy+ewldizloJMXcS50QhJ6WU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E+L5JocTv7l8YYvv8y+orQ3xv87xAljl2Dk6Z+svBteSHNFkfTq85WDmn+OIzgPQMeJm+WISx75Sur4ajw6NAb0elMcBDAcS93TyyA7jIyFpNlpu+j5oO6SHBKRgzbO9AOz/nSyhTA6tlz8hyxq+r/9aeqzQiUAIicnSZv4464U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=FROoWnct; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FROoWnct" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=sVcWQWRT/+ZC9br9URqsUiBuXIHakkuM4BbnSgXDHBs=; b=FROoWnct9Blk3q9zFvsBTNanRL i66HcfkFOMBKYACUKX8NY45oV5cBlt85ZjXszbXUQ2m+RLn8lywt2qR39eknMv/StojUeD6spjzAh etK4DkOORAJxSWfN0ghaxyNg7kThnrvDb6AV3HNmZUiwbOvaIRzZ4fgHgJtdu+SByNDc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vGJFC-00Cu4T-FU; Tue, 04 Nov 2025 16:46:50 +0100 Date: Tue, 4 Nov 2025 16:46:50 +0100 From: Andrew Lunn To: Parthiban Veerasooran Cc: piergiorgio.beruto@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: phy: phy-c45: add OATC14 10BASE-T1S PHY cable diagnostic support Message-ID: References: <20251104102013.63967-1-parthiban.veerasooran@microchip.com> <20251104102013.63967-2-parthiban.veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251104102013.63967-2-parthiban.veerasooran@microchip.com> > +/* Bus Short/Open Status: > + * 0 0 - no fault; everything is ok. (Default) > + * 0 1 - detected as an open or missing termination(s) > + * 1 0 - detected as a short or extra termination(s) > + * 1 1 - fault but fault type not detectable. More details can be available by > + * vender specific register if supported. > + */ > +enum oatc14_hdd_status { > + OATC14_HDD_STATUS_CABLE_OK, > + OATC14_HDD_STATUS_OPEN, > + OATC14_HDD_STATUS_SHORT, > + OATC14_HDD_STATUS_NOT_DETECTABLE, You frequently see the first enum has an = 0 at the end. I don't know what the C standard allows the compiler to do, in terms of assigning values to these enums, but it won't work if it uses 42, 43, 44, 45. etc. Otherwise, this looks O.K. Andrew