mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] scsi: ufs: core: Use reg_lock to protect UTMRLCLR
Date: Mon, 21 Oct 2024 13:25:03 -0700	[thread overview]
Message-ID: <a20841e9-4ec3-4965-8563-3b82673313c4@acm.org> (raw)
In-Reply-To: <20241021120313.493371-3-avri.altman@wdc.com>

On 10/21/24 5:03 AM, Avri Altman wrote:
>   	if (!test_bit(tag, &hba->outstanding_tasks))
>   		goto out;
>   
> -	spin_lock_irqsave(hba->host->host_lock, flags);
> +	spin_lock_irqsave(&hba->reg_lock, flags);
>   	ufshcd_utmrl_clear(hba, tag);
> -	spin_unlock_irqrestore(hba->host->host_lock, flags);
> +	spin_unlock_irqrestore(&hba->reg_lock, flags);
>   
>   	/* poll for max. 1 sec to clear door bell register by h/w */
>   	err = ufshcd_wait_for_register(hba,

Hi Avri,

ufshcd_utmrl_clear() performs a single write so I assume that calls of
that function do not have to be serialized?

Thanks,

Bart.

  reply	other threads:[~2024-10-21 20:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 12:03 [PATCH 0/4] Untie the host lock entanglement - part 1 Avri Altman
2024-10-21 12:03 ` [PATCH 1/4] scsi: ufs: core: Introduce a new host register lock Avri Altman
2024-10-21 18:35   ` Bart Van Assche
2024-10-22  6:02     ` Avri Altman
2024-10-21 12:03 ` [PATCH 2/4] scsi: ufs: core: Use reg_lock to protect UTMRLCLR Avri Altman
2024-10-21 20:25   ` Bart Van Assche [this message]
2024-10-22  6:02     ` Avri Altman
2024-10-21 12:03 ` [PATCH 3/4] scsi: ufs: core: Use reg_lock to protect UTRLCLR Avri Altman
2024-10-21 20:26   ` Bart Van Assche
2024-10-22  6:03     ` Avri Altman
2024-10-21 12:03 ` [PATCH 4/4] scsi: ufs: core: Use reg_lock to protect HCE register Avri Altman
2024-10-21 20:02   ` Bart Van Assche
2024-10-22  6:01     ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a20841e9-4ec3-4965-8563-3b82673313c4@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®