From: Hans de Goede <hdegoede@redhat.com>
To: "Juri Vitali" <juri@dividebyzero.it>,
"James John" <me@donjajo.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: asus_nb_wmi sends KEY_BRIGHTNESSDOWN on pressing CAPS Lock and PrntScrn on Zenbook S 13 UX5304VA
Date: Sun, 3 Dec 2023 16:44:17 +0100 [thread overview]
Message-ID: <a20c201e-7e81-4575-ab12-76f872c96499@redhat.com> (raw)
In-Reply-To: <77b3eed7-825d-41c5-a802-ea891a16f992@redhat.com>
Hi Juri,
On 11/25/23 15:25, Hans de Goede wrote:
> Hi Juri,
>
> On 11/24/23 16:54, Juri Vitali wrote:
>> Hi,
>> Unfortunately those patches have broken the backlight reporting on older
>> laptops, which do rely on the old mechanism.
>
> Thank you for reporting this and sorry about the regression.
>
> And thank you for writing a good bug report with as much info
> included as possible, that is much appreciated.
>
>> For instance, on my Asus UX32A/VD when pressing the backlight up/down button
>> the backlight changes accordingly,
>
> Ok, so the embedded-controller (EC) is adjusting the brightness
> itself in reaction to the key presses, which means that
> the old behavior of sending KEY_BRIGHTNESSDOWN /
> KEY_BRIGHTNESSUP was not really correct because that will
> cause e.g. GNOME to then increase the brightness itself
> which means that if the new brightness is correctly reflected
> when reading it GNOME may increase the brightness an
> additional step on top of the step it has already been
> increased by the EC itself.
>
> Which makes me wonder how to properly solve this,
> so I have a bunch of questions:
>
> 1. What desktop environment are you using ?
>
> 2. Assuming you are using GNOME (for now) I guess that with older
> kernels you got an on-screen-display (OSD) notification about
> the brightness changing? Do you notice any difference in how
> many total steps you have going from min to max with older
> kernels vs the new kernel ? If the double increase problem
> happens I guess you only get 5 brightness levels in GNOME /
> 4 steps from going from minimal to maximum ?
>
>
> Note below questions should all be answered with the new kernel
> with the unknown key messages in dmesg.
>
>
> 3. Can you do:
>
> ls /sys/class/backlight
>
> And let me know the output, I wonder what method is being
> used to control backlight on your machine.
>
> 4. Can you do:
>
> cat /sys/class/backlight/$name/max_brightness
>
> What does this say?
>
> With $name being the name from 3.
>
> 5. Can you do:
>
> cat /sys/class/backlight/$name/brightness
>
> And then change the brightness using the keys, and then
> again do:
>
> cat /sys/class/backlight/$name/brightness
>
> What are the values shown before / after changing it ?
>
> 6. Can you repeat 5 but then do:
>
> cat /sys/class/backlight/$name/actual_brightness
>
> 7. Can you run:
>
> sudo acpidump -o acpidump.txt
>
> And then email me the generated acpidump.txt file
> in a private email ?
I guess you have not been able to make some time to answer
the above questions yet.
Any chance you can make some time to gather this info soon ?
Regards,
Hans
next prev parent reply other threads:[~2023-12-03 15:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 8:11 James John
2023-10-01 9:28 ` Hans de Goede
2023-10-01 8:46 ` James John
2023-10-01 13:45 ` Hans de Goede
2023-10-01 14:16 ` James John
2023-10-01 14:18 ` James John
2023-10-01 15:09 ` James John
2023-10-11 10:44 ` Hans de Goede
2023-10-11 15:43 ` Hans de Goede
2023-11-24 15:54 ` Juri Vitali
2023-11-25 14:25 ` Hans de Goede
2023-12-03 15:44 ` Hans de Goede [this message]
2023-12-04 0:32 ` juri
2023-12-04 0:32 ` juri
2023-12-04 13:06 ` juri
2023-12-04 13:54 ` Hans de Goede
2023-12-04 15:52 ` juri
2023-10-17 8:50 ` Hans de Goede
2023-10-18 0:17 ` me
2023-10-18 19:35 ` Hans de Goede
2023-10-19 23:22 ` James John
2023-10-21 9:46 ` Hans de Goede
2023-10-21 9:53 ` James John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20c201e-7e81-4575-ab12-76f872c96499@redhat.com \
--to=hdegoede@redhat.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=juri@dividebyzero.it \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=me@donjajo.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®